From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.74962.1674743716471526063
 for <devel@edk2.groups.io>;
 Thu, 26 Jan 2023 06:35:16 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=URJuUxgM;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 2989920DFE6C;
	Thu, 26 Jan 2023 06:35:15 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2989920DFE6C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1674743716;
	bh=vGqxasaOdqocwNqCN1RLi1QmHRfsikNUnjtTHQKa7YE=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=URJuUxgM4a+iWFNKOH6Y/hygXtioV2jmRVhIfkI5qNiwpozgox+J8zvcxY+lhB5z5
	 diulBFp9SW/+xZhLYkcEThQ2h6/tDhJ0Py+3I+IEoyPJnvLvdPtf9ByZXH+YrwAfR9
	 QiCLsbLzka1mlJ6AhMqtKiTol8S/5Pt53lnmwvNE=
Message-ID: <4bd46a52-c73e-ffc5-2756-705402244ea6@linux.microsoft.com>
Date: Thu, 26 Jan 2023 09:35:14 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v2 4/6] ArmVirtPkg/PlatformCI: Enable optional features on Qemu AARCH64 builds
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Oliver Steffen <osteffen@redhat.com>
References: <20230124163417.584727-1-ardb@kernel.org>
 <20230124163417.584727-5-ardb@kernel.org>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230124163417.584727-5-ardb@kernel.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 1/24/2023 11:34 AM, Ard Biesheuvel wrote:
> To increase the CI coverage, enable secure boot, TPM2 support and HTTPS
> boot on ArmVirtQemu builds used in CI.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index b1526ae8e50b..44a1d3da6742 100644
> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -32,21 +32,21 @@ jobs:
>             QEMU_AARCH64_DEBUG:
> 
>               Build.File: "$(package)/PlatformCI/QemuBuild.py"
> 
>               Build.Arch: "AARCH64"
> 
> -            Build.Flags: ""
> 
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
> 
>               Build.Target: "DEBUG"
> 
>               Run.Flags: $(run_flags)
> 
>               Run: $(should_run)
> 
>             QEMU_AARCH64_RELEASE:
> 
>               Build.File: "$(package)/PlatformCI/QemuBuild.py"
> 
>               Build.Arch: "AARCH64"
> 
> -            Build.Flags: ""
> 
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
> 
>               Build.Target: "RELEASE"
> 
>               Run.Flags: $(run_flags)
> 
>               Run: $(should_run)
> 
>             QEMU_AARCH64_NOOPT:
> 
>               Build.File: "$(package)/PlatformCI/QemuBuild.py"
> 
>               Build.Arch: "AARCH64"
> 
> -            Build.Flags: ""
> 
> +            Build.Flags: "BLD_*_SECURE_BOOT_ENABLE=1 BLD_*_TPM2_ENABLE=1 BLD_*_NETWORK_TLS_ENABLE=1 BLD_*_NETWORK_IP6_ENABLE=1 BLD_*_NETWORK_HTTP_BOOT_ENABLE=1"
> 
>               Build.Target: "NOOPT"
> 
>               Run.Flags: $(run_flags)
> 
>               Run: $(should_run)
>