From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B4283D8030C for ; Mon, 28 Aug 2023 09:16:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=C+oAiReVPUNXTLpNLUJWWhcASZBDB5R724evmWzKcUE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1693214192; v=1; b=oGwkH9loG0kCJ+k+V4pqSL1kk5Ngr/DM1MSemj6v1WKq/dSSIKim+mBNFYvxvW+P/eKGjeFk qJEew3XgV1gJOhzcAoKGrsh0qQLoHxHHs1BqadpprFkv8HCnW8JZbbAI/2uDpF1TxFre3JwBerf nNcA5J7gUR5tUN1QNIzNPSLw= X-Received: by 127.0.0.2 with SMTP id yCWdYY7687511xCJIB6LuN69; Mon, 28 Aug 2023 02:16:32 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.9527.1693214191743146711 for ; Mon, 28 Aug 2023 02:16:31 -0700 X-Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-0NAAdAxqNbSVfHatC1IsMg-1; Mon, 28 Aug 2023 05:16:26 -0400 X-MC-Unique: 0NAAdAxqNbSVfHatC1IsMg-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A84929A9D36; Mon, 28 Aug 2023 09:16:26 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD84140C6F4C; Mon, 28 Aug 2023 09:16:25 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9170718007A1; Mon, 28 Aug 2023 11:16:24 +0200 (CEST) Date: Mon, 28 Aug 2023 11:16:24 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: Pedro Falcato , devel@edk2.groups.io, Jiewen Yao , Michael Brown , Tom Lendacky , Michael Roth Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy Message-ID: <4bd53ehby2cto5n2venjfkucot5ayj2xtsl7z6diegh6llrpm2@tj5oh6txxjck> References: <20230720134557.3903923-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eDStql4nh3z5kaSLzWkieBfgx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oGwkH9lo; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) Hi, > I have tried the patch below, and I don't see any slowdowns with or > without the patch, running both DEBUG and RELEASE builds under > ordinary KVM/nested-virt. Note that the change in the first hunk will > cause the ASSERT()s removed in the other hunks to trigger so the code > is definitely being exercised. QE team tested again with fresh builds, the slowdown isn't there any more. Not fully clear where it came from, but most likely not from this patch. Only 20 successful test runs so far, which a good start, but with a reproduce rate below 20% not that much. I'll post an update when it I get more results. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108054): https://edk2.groups.io/g/devel/message/108054 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-