From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 08 Aug 2019 15:24:06 -0700 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D29143CA1D; Thu, 8 Aug 2019 22:24:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-28.ams2.redhat.com [10.36.116.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C9F660BE1; Thu, 8 Aug 2019 22:24:04 +0000 (UTC) Subject: Re: [PATCH V3 03/15] ArmVirtPkg/ArmVirtQemu.dsc: Add ResetUtilityLib to dsc file To: Leif Lindholm Cc: Zhichao Gao , devel@edk2.groups.io, Ard Biesheuvel , Liming Gao References: <20190808010825.16784-1-zhichao.gao@intel.com> <20190808010825.16784-4-zhichao.gao@intel.com> <58ed45db-3249-75ea-9604-dbada90ba41b@redhat.com> <20190808203936.GG25813@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <4bd9f47a-8a6a-02d9-3234-6ca457db37dc@redhat.com> Date: Fri, 9 Aug 2019 00:24:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190808203936.GG25813@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 08 Aug 2019 22:24:05 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/08/19 22:39, Leif Lindholm wrote: > On Thu, Aug 08, 2019 at 10:21:16PM +0200, Laszlo Ersek wrote: >> On 08/08/19 03:08, Zhichao Gao wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 >>> >>> ResetUtilityLib would be consumed by CapsuleRuntimeDxe. >>> So add it for the platform dsc file. >>> >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Leif Lindholm >>> Cc: Liming Gao >>> Signed-off-by: Zhichao Gao >>> --- >>> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >>> index 7ae6702ac1..4b8130f8e7 100644 >>> --- a/ArmVirtPkg/ArmVirtQemu.dsc >>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >>> @@ -73,6 +73,7 @@ >>> PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >>> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >>> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >>> + ResetUtilityLib|MdeModulePkg/Library/ResetUtilityLib/ResetUtilityLib.inf >>> >>> [LibraryClasses.common.PEIM] >>> ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf >>> >> >> Can you please update your git configuration for displaying the DSC >> section headers near the hunk markers (@@), when a patch is formatted? >> So that it's easier to see, during review, what DSC section is being >> modified? > > Even better, run BaseTools/Scripts/SetupGit.py and get *all* of the > correct settings that are possible to configure statically. Argh, sorry, you are right. I've completely forgotten about that script! To my excuse, the expected usage model *is* to run it once, and then forget about it :) Thanks! Laszlo > > / > Leif > > p.s. > Yes, I really should update the wiki to mention this. > >> * >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05 >> >> $ git config diff.ini.xfuncname '^\[[A-Za-z0-9_., ]+]' >> >> * >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09 >> >> $ cat > .git/info/attributes <> *.efi -diff >> *.EFI -diff >> *.bin -diff >> *.BIN -diff >> *.raw -diff >> *.RAW -diff >> *.bmp -diff >> *.BMP -diff >> *.dec diff=ini >> *.dsc diff=ini >> *.dsc.inc diff=ini >> *.fdf diff=ini >> *.fdf.inc diff=ini >> *.inf diff=ini >> EOT >> >> Can you please reformat & repost the series like that? >> >> Thanks, >> Laszlo