From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web11.87417.1674249778490420958 for ; Fri, 20 Jan 2023 13:22:58 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=tzuyMMMH; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C05DC5C014D; Fri, 20 Jan 2023 16:22:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 20 Jan 2023 16:22:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1674249777; x=1674336177; bh=ifAzoHHRa6 geqrqkmbgq1iUKE4X9F82H2tViqdr/0C0=; b=tzuyMMMHUhT+ekGTqYmUJ5EsfJ vsqO0ui6GmEFV1hwhnjPvcP+0/Y/59yweS8zJckKUbQF5+ChMLFQaYQq7k6PifDv Yj9T8j6oCZ95tOQ1BVCwCWGMB6id+xkfHJaRkMDH9YoZrwQBMjt0b0HfCeBXnNax fA1/66Z00P0snD6z3RBeM5TrM8may8qqkSb9iOKrP5E/GGCrrdWPBtPJzYiBhtXQ QBZE7F0UDvxarqVDF8qSsYRHJ8DBvM9nwwxDxWPn2dxBWvLYsPZoH7yhMa7Nzljz 7Jfw7KCtAGtScLtyrHdkY3SYPbw9N6sSky4N5ziDu90Wy+Aoq6uf1LlNA5aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674249777; x=1674336177; bh=ifAzoHHRa6geqrqkmbgq1iUKE4X9 F82H2tViqdr/0C0=; b=lL2sAawgnwqTJzpWQXWABR2wqWWZ3jVMMRxwiNI1p88H sWWyv4Kmnbxm+JazsuabJdj3qikJjSGEyATAoHVDWh5mfEWoqmKBChiAoX8Ok0aO DzruVj93raf2zo8vHsKX9to321lLjm02mY/aexX1J35EejZDMna8Dvx9NR8CXIig kKTUG3pG6K6bLIlGH8OtWtRZiyXJriRwMScMhpnLs9Cw/FKD8v9v8v/0RAMSeke/ EYVmxk8MxrdBcNKFW/8C81IvcKFt2dLQNRjaL5OOBJAIBk1LbZWMCN1ZyU/9LYvK MLlcBOEkIyYrrN8oyJFetZ6Yg/y6vDR9kPHRip7CSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudduvddgudehudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfuffvvehfhfgjsegrtderredtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeetjeejgedtuedtuedvgfdtffffffdvvddvueegjeduieekjedtgfdvgfeg gfefkeenucffohhmrghinhepghhithhhuhgsrdgtohhmpdgtohhnthgrihhnvghrshdrug gvvhdpghhhtghrrdhiohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Jan 2023 16:22:56 -0500 (EST) Message-ID: <4be046eb-ea12-2e0c-2bd8-5b735c5028b1@bsdio.com> Date: Fri, 20 Jan 2023 14:22:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Andrew Fish , Chris Fernald , Leif Lindholm , Michael D Kinney , Oliver Steffen References: <20230120205157.167-1-mikuback@linux.microsoft.com> From: "Rebecca Cran" In-Reply-To: <20230120205157.167-1-mikuback@linux.microsoft.com> Content-Type: multipart/alternative; boundary="------------v8KYmuLFJXLOsqKCST0uOMo0" Content-Language: en-US --------------v8KYmuLFJXLOsqKCST0uOMo0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? Also perhaps a .editorconfig file? -- Rebecca Cran On 1/20/23 13:51, Michael Kubacki wrote: > From: Michael Kubacki > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish > Cc: Chris Fernald > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Oliver Steffen > Signed-off-by: Michael Kubacki > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki [makubacki] > R: Michael D Kinney [mdkinney] > R: Liming Gao [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki [makubacki] > +R: Chris Fernald [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan [spbrogan] --------------v8KYmuLFJXLOsqKCST0uOMo0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit 
Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)?
Also perhaps a .editorconfig file?

    
-- 


    
Rebecca Cran

    


    

    
On 1/20/23 13:51, Michael Kubacki
      wrote:

    

    

      
From: Michael Kubacki <michael.kubacki@microsoft.com>

Tianocore maintains container images in the tianocore/containers repo
and stores container images within the GitHub container registry.

https://github.com/tianocore/containers

This change adds a devcontainer.json file to the edk2 repo. This
file's metadata and settings to configurate a development container
for a given well-defined tool and runtime stack.

More information about the devcontainer.json file is available here:
https://containers.dev/implementors/json_reference/

This file is recognized by popular tools such as GitHub Codespaces
and VS Code. In VS Code in particular, it makes it much easier for
a user to be aware a dev container exists (via UI notifications)
and to load the container.

A minimal number of VS Code extensions are specified that are useful
for edk2 development or to assist in complying with CI checks in
place in edk2.

Cc: Andrew Fish <afish@apple.com>
Cc: Chris Fernald <chris.fernald@outlook.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Oliver Steffen <osteffen@redhat.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 .devcontainer/devcontainer.json | 16 ++++++++++++++++
 Maintainers.txt                 |  5 +++++
 2 files changed, 21 insertions(+)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
new file mode 100644
index 000000000000..592bb8cf6626
--- /dev/null
+++ b/.devcontainer/devcontainer.json
@@ -0,0 +1,16 @@
+{
+  "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest",
+  "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt",
+  "customizations": {
+    "vscode": {
+      "extensions": [
+        "DavidAnson.vscode-markdownlint",
+        "ms-azuretools.vscode-docker",
+        "ms-vscode-remote.remote-containers",
+        "ms-vscode.cpptools",
+        "walonli.edk2-vscode",
+        "zachflower.uncrustify"
+      ]
+    }
+  }
+}
diff --git a/Maintainers.txt b/Maintainers.txt
index 68f603b48398..4aa7973d5156 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
 R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney]
 R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
 
+.devcontainer/
+F: .devcontainer/
+M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki]
+R: Chris Fernald <chris.fernald@outlook.com> [cfernald]
+
 .github/
 F: .github/
 M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan]


    

  


--------------v8KYmuLFJXLOsqKCST0uOMo0--