* [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file @ 2023-01-20 20:51 Michael Kubacki 2023-01-20 21:22 ` [edk2-devel] " Rebecca Cran 0 siblings, 1 reply; 14+ messages in thread From: Michael Kubacki @ 2023-01-20 20:51 UTC (permalink / raw) To: devel Cc: Andrew Fish, Chris Fernald, Leif Lindholm, Michael D Kinney, Oliver Steffen From: Michael Kubacki <michael.kubacki@microsoft.com> Tianocore maintains container images in the tianocore/containers repo and stores container images within the GitHub container registry. https://github.com/tianocore/containers This change adds a devcontainer.json file to the edk2 repo. This file's metadata and settings to configurate a development container for a given well-defined tool and runtime stack. More information about the devcontainer.json file is available here: https://containers.dev/implementors/json_reference/ This file is recognized by popular tools such as GitHub Codespaces and VS Code. In VS Code in particular, it makes it much easier for a user to be aware a dev container exists (via UI notifications) and to load the container. A minimal number of VS Code extensions are specified that are useful for edk2 development or to assist in complying with CI checks in place in edk2. Cc: Andrew Fish <afish@apple.com> Cc: Chris Fernald <chris.fernald@outlook.com> Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Oliver Steffen <osteffen@redhat.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> --- .devcontainer/devcontainer.json | 16 ++++++++++++++++ Maintainers.txt | 5 +++++ 2 files changed, 21 insertions(+) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json new file mode 100644 index 000000000000..592bb8cf6626 --- /dev/null +++ b/.devcontainer/devcontainer.json @@ -0,0 +1,16 @@ +{ + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", + "customizations": { + "vscode": { + "extensions": [ + "DavidAnson.vscode-markdownlint", + "ms-azuretools.vscode-docker", + "ms-vscode-remote.remote-containers", + "ms-vscode.cpptools", + "walonli.edk2-vscode", + "zachflower.uncrustify" + ] + } + } +} diff --git a/Maintainers.txt b/Maintainers.txt index 68f603b48398..4aa7973d5156 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] +.devcontainer/ +F: .devcontainer/ +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] + .github/ F: .github/ M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] -- 2.28.0.windows.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-01-20 20:51 [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file Michael Kubacki @ 2023-01-20 21:22 ` Rebecca Cran 2023-01-20 21:57 ` Michael Kubacki 2023-01-23 9:23 ` Oliver Steffen 0 siblings, 2 replies; 14+ messages in thread From: Rebecca Cran @ 2023-01-20 21:22 UTC (permalink / raw) To: devel, mikuback Cc: Andrew Fish, Chris Fernald, Leif Lindholm, Michael D Kinney, Oliver Steffen [-- Attachment #1: Type: text/plain, Size: 2954 bytes --] Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? Also perhaps a .editorconfig file? -- Rebecca Cran On 1/20/23 13:51, Michael Kubacki wrote: > From: Michael Kubacki<michael.kubacki@microsoft.com> > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish<afish@apple.com> > Cc: Chris Fernald<chris.fernald@outlook.com> > Cc: Leif Lindholm<quic_llindhol@quicinc.com> > Cc: Michael D Kinney<michael.d.kinney@intel.com> > Cc: Oliver Steffen<osteffen@redhat.com> > Signed-off-by: Michael Kubacki<michael.kubacki@microsoft.com> > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki<mikuback@linux.microsoft.com> [makubacki] > R: Michael D Kinney<michael.d.kinney@intel.com> [mdkinney] > R: Liming Gao<gaoliming@byosoft.com.cn> [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki<mikuback@linux.microsoft.com> [makubacki] > +R: Chris Fernald<chris.fernald@outlook.com> [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan<sean.brogan@microsoft.com> [spbrogan] [-- Attachment #2: Type: text/html, Size: 4517 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-01-20 21:22 ` [edk2-devel] " Rebecca Cran @ 2023-01-20 21:57 ` Michael Kubacki 2023-01-23 9:23 ` Oliver Steffen 1 sibling, 0 replies; 14+ messages in thread From: Michael Kubacki @ 2023-01-20 21:57 UTC (permalink / raw) To: devel, rebecca Cc: Andrew Fish, Chris Fernald, Leif Lindholm, Michael D Kinney, Oliver Steffen I think that's a good idea. edk2-pytool-extensions has a .vscode/settings.json file that has been useful for local python linting and testing that helps catch issues before CI. For example: https://github.com/tianocore/edk2-pytool-extensions/blob/master/.vscode/settings.json On 1/20/2023 4:22 PM, Rebecca Cran wrote: > Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? > > Also perhaps a .editorconfig file? > > -- > > Rebecca Cran > > > On 1/20/23 13:51, Michael Kubacki wrote: >> From: Michael Kubacki<michael.kubacki@microsoft.com> >> >> Tianocore maintains container images in the tianocore/containers repo >> and stores container images within the GitHub container registry. >> >> https://github.com/tianocore/containers >> >> This change adds a devcontainer.json file to the edk2 repo. This >> file's metadata and settings to configurate a development container >> for a given well-defined tool and runtime stack. >> >> More information about the devcontainer.json file is available here: >> https://containers.dev/implementors/json_reference/ >> >> This file is recognized by popular tools such as GitHub Codespaces >> and VS Code. In VS Code in particular, it makes it much easier for >> a user to be aware a dev container exists (via UI notifications) >> and to load the container. >> >> A minimal number of VS Code extensions are specified that are useful >> for edk2 development or to assist in complying with CI checks in >> place in edk2. >> >> Cc: Andrew Fish<afish@apple.com> >> Cc: Chris Fernald<chris.fernald@outlook.com> >> Cc: Leif Lindholm<quic_llindhol@quicinc.com> >> Cc: Michael D Kinney<michael.d.kinney@intel.com> >> Cc: Oliver Steffen<osteffen@redhat.com> >> Signed-off-by: Michael Kubacki<michael.kubacki@microsoft.com> >> --- >> .devcontainer/devcontainer.json | 16 ++++++++++++++++ >> Maintainers.txt | 5 +++++ >> 2 files changed, 21 insertions(+) >> >> diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json >> new file mode 100644 >> index 000000000000..592bb8cf6626 >> --- /dev/null >> +++ b/.devcontainer/devcontainer.json >> @@ -0,0 +1,16 @@ >> +{ >> + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", >> + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", >> + "customizations": { >> + "vscode": { >> + "extensions": [ >> + "DavidAnson.vscode-markdownlint", >> + "ms-azuretools.vscode-docker", >> + "ms-vscode-remote.remote-containers", >> + "ms-vscode.cpptools", >> + "walonli.edk2-vscode", >> + "zachflower.uncrustify" >> + ] >> + } >> + } >> +} >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 68f603b48398..4aa7973d5156 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -117,6 +117,11 @@ M: Michael Kubacki<mikuback@linux.microsoft.com> [makubacki] >> R: Michael D Kinney<michael.d.kinney@intel.com> [mdkinney] >> R: Liming Gao<gaoliming@byosoft.com.cn> [lgao4] >> >> +.devcontainer/ >> +F: .devcontainer/ >> +M: Michael Kubacki<mikuback@linux.microsoft.com> [makubacki] >> +R: Chris Fernald<chris.fernald@outlook.com> [cfernald] >> + >> .github/ >> F: .github/ >> M: Sean Brogan<sean.brogan@microsoft.com> [spbrogan] > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-01-20 21:22 ` [edk2-devel] " Rebecca Cran 2023-01-20 21:57 ` Michael Kubacki @ 2023-01-23 9:23 ` Oliver Steffen 2023-01-23 10:46 ` Ard Biesheuvel 1 sibling, 1 reply; 14+ messages in thread From: Oliver Steffen @ 2023-01-23 9:23 UTC (permalink / raw) To: Rebecca Cran, devel, mikuback Cc: Andrew Fish, Chris Fernald, Leif Lindholm, Michael D Kinney Quoting Rebecca Cran (2023-01-20 22:22:55) > Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? As long as project settings for other IDEs (should there be a reasonable user base) would be accepted in the future, why not? > > Also perhaps a .editorconfig file? I like the idea, because it is understood by many IDEs and text editors. > > -- > > Rebecca Cran > > > On 1/20/23 13:51, Michael Kubacki wrote: > > From: Michael Kubacki [1]<michael.kubacki@microsoft.com> > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > [2]https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > [3]https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish [4]<afish@apple.com> > Cc: Chris Fernald [5]<chris.fernald@outlook.com> > Cc: Leif Lindholm [6]<quic_llindhol@quicinc.com> > Cc: Michael D Kinney [7]<michael.d.kinney@intel.com> > Cc: Oliver Steffen [8]<osteffen@redhat.com> > Signed-off-by: Michael Kubacki [9]<michael.kubacki@microsoft.com> > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki [10]<mikuback@linux.microsoft.com> [makubacki] > R: Michael D Kinney [11]<michael.d.kinney@intel.com> [mdkinney] > R: Liming Gao [12]<gaoliming@byosoft.com.cn> [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki [13]<mikuback@linux.microsoft.com> [makubacki] > +R: Chris Fernald [14]<chris.fernald@outlook.com> [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan [15]<sean.brogan@microsoft.com> [spbrogan] > > -Oliver ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-01-23 9:23 ` Oliver Steffen @ 2023-01-23 10:46 ` Ard Biesheuvel 0 siblings, 0 replies; 14+ messages in thread From: Ard Biesheuvel @ 2023-01-23 10:46 UTC (permalink / raw) To: devel, osteffen Cc: Rebecca Cran, mikuback, Andrew Fish, Chris Fernald, Leif Lindholm, Michael D Kinney On Mon, 23 Jan 2023 at 10:23, Oliver Steffen <osteffen@redhat.com> wrote: > > Quoting Rebecca Cran (2023-01-20 22:22:55) > > Related to this, I've been wondering if we might want to commit a .vscode directory with project configuration file(s)? > > As long as project settings for other IDEs (should > there be a reasonable user base) would be accepted in the future, why not? > > > > > Also perhaps a .editorconfig file? > I like the idea, because it is understood by many IDEs and text editors. > Yes, please, this would be very useful. ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <173C1FA3C96CC3CD.14781@groups.io>]
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file [not found] <173C1FA3C96CC3CD.14781@groups.io> @ 2023-01-20 20:54 ` Michael Kubacki 2023-01-24 9:52 ` Oliver Steffen 2023-01-26 14:44 ` Michael Kubacki [not found] ` <173DE310BC2140E3.21537@groups.io> 2 siblings, 1 reply; 14+ messages in thread From: Michael Kubacki @ 2023-01-20 20:54 UTC (permalink / raw) To: Oliver Steffen, devel Hi Oliver, Please let me know if you would like to be added to the maintainer list for this directory. I'm happy to update the patch and sent that in a v2. Thanks, Michael On 1/20/2023 3:51 PM, Michael Kubacki wrote: > From: Michael Kubacki <michael.kubacki@microsoft.com> > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish <afish@apple.com> > Cc: Chris Fernald <chris.fernald@outlook.com> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Oliver Steffen <osteffen@redhat.com> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] > R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-01-20 20:54 ` Michael Kubacki @ 2023-01-24 9:52 ` Oliver Steffen 0 siblings, 0 replies; 14+ messages in thread From: Oliver Steffen @ 2023-01-24 9:52 UTC (permalink / raw) To: devel, mikuback [-- Attachment #1: Type: text/plain, Size: 3447 bytes --] Hi Michael, Thanks for thinking of me. But I must admit I do not use devcontainers or vscode, and I am not sure how much help I can be here. It looks like a nice feature though, and I might try it out sometime. Thanks, Oliver On Fri, Jan 20, 2023 at 9:54 PM Michael Kubacki < mikuback@linux.microsoft.com> wrote: > Hi Oliver, > > Please let me know if you would like to be added to the maintainer list > for this directory. I'm happy to update the patch and sent that in a v2. > > Thanks, > Michael > > On 1/20/2023 3:51 PM, Michael Kubacki wrote: > > From: Michael Kubacki <michael.kubacki@microsoft.com> > > > > Tianocore maintains container images in the tianocore/containers repo > > and stores container images within the GitHub container registry. > > > > https://github.com/tianocore/containers > > > > This change adds a devcontainer.json file to the edk2 repo. This > > file's metadata and settings to configurate a development container > > for a given well-defined tool and runtime stack. > > > > More information about the devcontainer.json file is available here: > > https://containers.dev/implementors/json_reference/ > > > > This file is recognized by popular tools such as GitHub Codespaces > > and VS Code. In VS Code in particular, it makes it much easier for > > a user to be aware a dev container exists (via UI notifications) > > and to load the container. > > > > A minimal number of VS Code extensions are specified that are useful > > for edk2 development or to assist in complying with CI checks in > > place in edk2. > > > > Cc: Andrew Fish <afish@apple.com> > > Cc: Chris Fernald <chris.fernald@outlook.com> > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Oliver Steffen <osteffen@redhat.com> > > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > > --- > > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > > Maintainers.txt | 5 +++++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/.devcontainer/devcontainer.json > b/.devcontainer/devcontainer.json > > new file mode 100644 > > index 000000000000..592bb8cf6626 > > --- /dev/null > > +++ b/.devcontainer/devcontainer.json > > @@ -0,0 +1,16 @@ > > +{ > > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > > + "postCreateCommand": "git config --global --add safe.directory * && > pip install --upgrade -r pip-requirements.txt", > > + "customizations": { > > + "vscode": { > > + "extensions": [ > > + "DavidAnson.vscode-markdownlint", > > + "ms-azuretools.vscode-docker", > > + "ms-vscode-remote.remote-containers", > > + "ms-vscode.cpptools", > > + "walonli.edk2-vscode", > > + "zachflower.uncrustify" > > + ] > > + } > > + } > > +} > > diff --git a/Maintainers.txt b/Maintainers.txt > > index 68f603b48398..4aa7973d5156 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> > [makubacki] > > R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] > > R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] > > > > +.devcontainer/ > > +F: .devcontainer/ > > +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > > +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] > > + > > .github/ > > F: .github/ > > M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] > > [-- Attachment #2: Type: text/html, Size: 6198 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file [not found] <173C1FA3C96CC3CD.14781@groups.io> 2023-01-20 20:54 ` Michael Kubacki @ 2023-01-26 14:44 ` Michael Kubacki [not found] ` <173DE310BC2140E3.21537@groups.io> 2 siblings, 0 replies; 14+ messages in thread From: Michael Kubacki @ 2023-01-26 14:44 UTC (permalink / raw) To: devel, Michael D Kinney, Leif Lindholm, Andrew Fish Cc: Chris Fernald, Oliver Steffen I've seen interest on the patch but no R-b yet. I believe those in the TO line might be the best to provide that since this is a new directory. If anyone is interested in being a maintainer/reviewer, let me know and I'll update the file. Thanks, Michael On 1/20/2023 3:51 PM, Michael Kubacki wrote: > From: Michael Kubacki <michael.kubacki@microsoft.com> > > Tianocore maintains container images in the tianocore/containers repo > and stores container images within the GitHub container registry. > > https://github.com/tianocore/containers > > This change adds a devcontainer.json file to the edk2 repo. This > file's metadata and settings to configurate a development container > for a given well-defined tool and runtime stack. > > More information about the devcontainer.json file is available here: > https://containers.dev/implementors/json_reference/ > > This file is recognized by popular tools such as GitHub Codespaces > and VS Code. In VS Code in particular, it makes it much easier for > a user to be aware a dev container exists (via UI notifications) > and to load the container. > > A minimal number of VS Code extensions are specified that are useful > for edk2 development or to assist in complying with CI checks in > place in edk2. > > Cc: Andrew Fish <afish@apple.com> > Cc: Chris Fernald <chris.fernald@outlook.com> > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Oliver Steffen <osteffen@redhat.com> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > --- > .devcontainer/devcontainer.json | 16 ++++++++++++++++ > Maintainers.txt | 5 +++++ > 2 files changed, 21 insertions(+) > > diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json > new file mode 100644 > index 000000000000..592bb8cf6626 > --- /dev/null > +++ b/.devcontainer/devcontainer.json > @@ -0,0 +1,16 @@ > +{ > + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > + "postCreateCommand": "git config --global --add safe.directory * && pip install --upgrade -r pip-requirements.txt", > + "customizations": { > + "vscode": { > + "extensions": [ > + "DavidAnson.vscode-markdownlint", > + "ms-azuretools.vscode-docker", > + "ms-vscode-remote.remote-containers", > + "ms-vscode.cpptools", > + "walonli.edk2-vscode", > + "zachflower.uncrustify" > + ] > + } > + } > +} > diff --git a/Maintainers.txt b/Maintainers.txt > index 68f603b48398..4aa7973d5156 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] > R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] > > +.devcontainer/ > +F: .devcontainer/ > +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] > + > .github/ > F: .github/ > M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <173DE310BC2140E3.21537@groups.io>]
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file [not found] ` <173DE310BC2140E3.21537@groups.io> @ 2023-02-05 18:34 ` Michael Kubacki 2023-02-05 19:54 ` Michael D Kinney 2023-02-08 3:49 ` Michael Kubacki 0 siblings, 2 replies; 14+ messages in thread From: Michael Kubacki @ 2023-02-05 18:34 UTC (permalink / raw) To: devel, Michael D Kinney, Leif Lindholm, Andrew Fish, Gao, Liming Cc: Chris Fernald, Oliver Steffen, Sean Brogan With the soft freeze starting soon, I wanted to bring attention to this patch again. It has not received feedback in 2+ weeks on the list. It is simple and intended to help users more easily use Tianocore containers. Can you please review and include this in the stable tag? Thanks, Michael On 1/26/2023 9:44 AM, Michael Kubacki wrote: > I've seen interest on the patch but no R-b yet. I believe those in the > TO line might be the best to provide that since this is a new directory. > > If anyone is interested in being a maintainer/reviewer, let me know and > I'll update the file. > > Thanks, > Michael > > On 1/20/2023 3:51 PM, Michael Kubacki wrote: >> From: Michael Kubacki <michael.kubacki@microsoft.com> >> >> Tianocore maintains container images in the tianocore/containers repo >> and stores container images within the GitHub container registry. >> >> https://github.com/tianocore/containers >> >> This change adds a devcontainer.json file to the edk2 repo. This >> file's metadata and settings to configurate a development container >> for a given well-defined tool and runtime stack. >> >> More information about the devcontainer.json file is available here: >> https://containers.dev/implementors/json_reference/ >> >> This file is recognized by popular tools such as GitHub Codespaces >> and VS Code. In VS Code in particular, it makes it much easier for >> a user to be aware a dev container exists (via UI notifications) >> and to load the container. >> >> A minimal number of VS Code extensions are specified that are useful >> for edk2 development or to assist in complying with CI checks in >> place in edk2. >> >> Cc: Andrew Fish <afish@apple.com> >> Cc: Chris Fernald <chris.fernald@outlook.com> >> Cc: Leif Lindholm <quic_llindhol@quicinc.com> >> Cc: Michael D Kinney <michael.d.kinney@intel.com> >> Cc: Oliver Steffen <osteffen@redhat.com> >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> >> --- >> .devcontainer/devcontainer.json | 16 ++++++++++++++++ >> Maintainers.txt | 5 +++++ >> 2 files changed, 21 insertions(+) >> >> diff --git a/.devcontainer/devcontainer.json >> b/.devcontainer/devcontainer.json >> new file mode 100644 >> index 000000000000..592bb8cf6626 >> --- /dev/null >> +++ b/.devcontainer/devcontainer.json >> @@ -0,0 +1,16 @@ >> +{ >> + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", >> + "postCreateCommand": "git config --global --add safe.directory * && >> pip install --upgrade -r pip-requirements.txt", >> + "customizations": { >> + "vscode": { >> + "extensions": [ >> + "DavidAnson.vscode-markdownlint", >> + "ms-azuretools.vscode-docker", >> + "ms-vscode-remote.remote-containers", >> + "ms-vscode.cpptools", >> + "walonli.edk2-vscode", >> + "zachflower.uncrustify" >> + ] >> + } >> + } >> +} >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 68f603b48398..4aa7973d5156 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> >> [makubacki] >> R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] >> R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] >> +.devcontainer/ >> +F: .devcontainer/ >> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] >> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] >> + >> .github/ >> F: .github/ >> M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-02-05 18:34 ` Michael Kubacki @ 2023-02-05 19:54 ` Michael D Kinney 2023-02-08 3:49 ` Michael Kubacki 1 sibling, 0 replies; 14+ messages in thread From: Michael D Kinney @ 2023-02-05 19:54 UTC (permalink / raw) To: devel@edk2.groups.io, mikuback@linux.microsoft.com, Leif Lindholm, Andrew Fish, Gao, Liming Cc: Chris Fernald, Oliver Steffen, Sean Brogan, Kinney, Michael D Acked-by: Michael D Kinney <michael.d.kinney@intel.com> > -----Original Message----- > From: Michael Kubacki <mikuback@linux.microsoft.com> > Sent: Sunday, February 5, 2023 10:34 AM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Andrew Fish > <afish@apple.com>; Gao, Liming <gaoliming@byosoft.com.cn> > Cc: Chris Fernald <chris.fernald@outlook.com>; Oliver Steffen <osteffen@redhat.com>; Sean Brogan <spbrogan@outlook.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file > > With the soft freeze starting soon, I wanted to bring attention to this > patch again. It has not received feedback in 2+ weeks on the list. > > It is simple and intended to help users more easily use Tianocore > containers. > > Can you please review and include this in the stable tag? > > Thanks, > Michael > > On 1/26/2023 9:44 AM, Michael Kubacki wrote: > > I've seen interest on the patch but no R-b yet. I believe those in the > > TO line might be the best to provide that since this is a new directory. > > > > If anyone is interested in being a maintainer/reviewer, let me know and > > I'll update the file. > > > > Thanks, > > Michael > > > > On 1/20/2023 3:51 PM, Michael Kubacki wrote: > >> From: Michael Kubacki <michael.kubacki@microsoft.com> > >> > >> Tianocore maintains container images in the tianocore/containers repo > >> and stores container images within the GitHub container registry. > >> > >> https://github.com/tianocore/containers > >> > >> This change adds a devcontainer.json file to the edk2 repo. This > >> file's metadata and settings to configurate a development container > >> for a given well-defined tool and runtime stack. > >> > >> More information about the devcontainer.json file is available here: > >> https://containers.dev/implementors/json_reference/ > >> > >> This file is recognized by popular tools such as GitHub Codespaces > >> and VS Code. In VS Code in particular, it makes it much easier for > >> a user to be aware a dev container exists (via UI notifications) > >> and to load the container. > >> > >> A minimal number of VS Code extensions are specified that are useful > >> for edk2 development or to assist in complying with CI checks in > >> place in edk2. > >> > >> Cc: Andrew Fish <afish@apple.com> > >> Cc: Chris Fernald <chris.fernald@outlook.com> > >> Cc: Leif Lindholm <quic_llindhol@quicinc.com> > >> Cc: Michael D Kinney <michael.d.kinney@intel.com> > >> Cc: Oliver Steffen <osteffen@redhat.com> > >> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > >> --- > >> .devcontainer/devcontainer.json | 16 ++++++++++++++++ > >> Maintainers.txt | 5 +++++ > >> 2 files changed, 21 insertions(+) > >> > >> diff --git a/.devcontainer/devcontainer.json > >> b/.devcontainer/devcontainer.json > >> new file mode 100644 > >> index 000000000000..592bb8cf6626 > >> --- /dev/null > >> +++ b/.devcontainer/devcontainer.json > >> @@ -0,0 +1,16 @@ > >> +{ > >> + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > >> + "postCreateCommand": "git config --global --add safe.directory * && > >> pip install --upgrade -r pip-requirements.txt", > >> + "customizations": { > >> + "vscode": { > >> + "extensions": [ > >> + "DavidAnson.vscode-markdownlint", > >> + "ms-azuretools.vscode-docker", > >> + "ms-vscode-remote.remote-containers", > >> + "ms-vscode.cpptools", > >> + "walonli.edk2-vscode", > >> + "zachflower.uncrustify" > >> + ] > >> + } > >> + } > >> +} > >> diff --git a/Maintainers.txt b/Maintainers.txt > >> index 68f603b48398..4aa7973d5156 100644 > >> --- a/Maintainers.txt > >> +++ b/Maintainers.txt > >> @@ -117,6 +117,11 @@ M: Michael Kubacki <mikuback@linux.microsoft.com> > >> [makubacki] > >> R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] > >> R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] > >> +.devcontainer/ > >> +F: .devcontainer/ > >> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > >> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] > >> + > >> .github/ > >> F: .github/ > >> M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] > > > > > > > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-02-05 18:34 ` Michael Kubacki 2023-02-05 19:54 ` Michael D Kinney @ 2023-02-08 3:49 ` Michael Kubacki 2023-02-10 5:01 ` Michael D Kinney 1 sibling, 1 reply; 14+ messages in thread From: Michael Kubacki @ 2023-02-08 3:49 UTC (permalink / raw) To: devel, Gao, Liming Cc: Chris Fernald, Oliver Steffen, Sean Brogan, Michael D Kinney, Leif Lindholm, Andrew Fish Hi Liming, I put the patch with received review tags in the following PR: https://github.com/tianocore/edk2/pull/4015 Thanks, Michael On 2/5/2023 1:34 PM, Michael Kubacki wrote: > With the soft freeze starting soon, I wanted to bring attention to this > patch again. It has not received feedback in 2+ weeks on the list. > > It is simple and intended to help users more easily use Tianocore > containers. > > Can you please review and include this in the stable tag? > > Thanks, > Michael > > On 1/26/2023 9:44 AM, Michael Kubacki wrote: >> I've seen interest on the patch but no R-b yet. I believe those in the >> TO line might be the best to provide that since this is a new directory. >> >> If anyone is interested in being a maintainer/reviewer, let me know >> and I'll update the file. >> >> Thanks, >> Michael >> >> On 1/20/2023 3:51 PM, Michael Kubacki wrote: >>> From: Michael Kubacki <michael.kubacki@microsoft.com> >>> >>> Tianocore maintains container images in the tianocore/containers repo >>> and stores container images within the GitHub container registry. >>> >>> https://github.com/tianocore/containers >>> >>> This change adds a devcontainer.json file to the edk2 repo. This >>> file's metadata and settings to configurate a development container >>> for a given well-defined tool and runtime stack. >>> >>> More information about the devcontainer.json file is available here: >>> https://containers.dev/implementors/json_reference/ >>> >>> This file is recognized by popular tools such as GitHub Codespaces >>> and VS Code. In VS Code in particular, it makes it much easier for >>> a user to be aware a dev container exists (via UI notifications) >>> and to load the container. >>> >>> A minimal number of VS Code extensions are specified that are useful >>> for edk2 development or to assist in complying with CI checks in >>> place in edk2. >>> >>> Cc: Andrew Fish <afish@apple.com> >>> Cc: Chris Fernald <chris.fernald@outlook.com> >>> Cc: Leif Lindholm <quic_llindhol@quicinc.com> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com> >>> Cc: Oliver Steffen <osteffen@redhat.com> >>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> >>> --- >>> .devcontainer/devcontainer.json | 16 ++++++++++++++++ >>> Maintainers.txt | 5 +++++ >>> 2 files changed, 21 insertions(+) >>> >>> diff --git a/.devcontainer/devcontainer.json >>> b/.devcontainer/devcontainer.json >>> new file mode 100644 >>> index 000000000000..592bb8cf6626 >>> --- /dev/null >>> +++ b/.devcontainer/devcontainer.json >>> @@ -0,0 +1,16 @@ >>> +{ >>> + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", >>> + "postCreateCommand": "git config --global --add safe.directory * >>> && pip install --upgrade -r pip-requirements.txt", >>> + "customizations": { >>> + "vscode": { >>> + "extensions": [ >>> + "DavidAnson.vscode-markdownlint", >>> + "ms-azuretools.vscode-docker", >>> + "ms-vscode-remote.remote-containers", >>> + "ms-vscode.cpptools", >>> + "walonli.edk2-vscode", >>> + "zachflower.uncrustify" >>> + ] >>> + } >>> + } >>> +} >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> index 68f603b48398..4aa7973d5156 100644 >>> --- a/Maintainers.txt >>> +++ b/Maintainers.txt >>> @@ -117,6 +117,11 @@ M: Michael Kubacki >>> <mikuback@linux.microsoft.com> [makubacki] >>> R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] >>> R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] >>> +.devcontainer/ >>> +F: .devcontainer/ >>> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] >>> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] >>> + >>> .github/ >>> F: .github/ >>> M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] >> >> >> >> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-02-08 3:49 ` Michael Kubacki @ 2023-02-10 5:01 ` Michael D Kinney 2023-02-13 14:13 ` Michael Kubacki 0 siblings, 1 reply; 14+ messages in thread From: Michael D Kinney @ 2023-02-10 5:01 UTC (permalink / raw) To: devel@edk2.groups.io, mikuback@linux.microsoft.com, Gao, Liming Cc: Chris Fernald, Oliver Steffen, Sean Brogan, Leif Lindholm, Andrew Fish, Kinney, Michael D Hi Michael, Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Please update commit message from Ab to Rb and I will merge. Thanks, Mike > -----Original Message----- > From: Michael Kubacki <mikuback@linux.microsoft.com> > Sent: Tuesday, February 7, 2023 7:50 PM > To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn> > Cc: Chris Fernald <chris.fernald@outlook.com>; Oliver Steffen <osteffen@redhat.com>; Sean Brogan <spbrogan@outlook.com>; Kinney, > Michael D <michael.d.kinney@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Andrew Fish <afish@apple.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file > > Hi Liming, > > I put the patch with received review tags in the following PR: > > https://github.com/tianocore/edk2/pull/4015 > > Thanks, > Michael > > On 2/5/2023 1:34 PM, Michael Kubacki wrote: > > With the soft freeze starting soon, I wanted to bring attention to this > > patch again. It has not received feedback in 2+ weeks on the list. > > > > It is simple and intended to help users more easily use Tianocore > > containers. > > > > Can you please review and include this in the stable tag? > > > > Thanks, > > Michael > > > > On 1/26/2023 9:44 AM, Michael Kubacki wrote: > >> I've seen interest on the patch but no R-b yet. I believe those in the > >> TO line might be the best to provide that since this is a new directory. > >> > >> If anyone is interested in being a maintainer/reviewer, let me know > >> and I'll update the file. > >> > >> Thanks, > >> Michael > >> > >> On 1/20/2023 3:51 PM, Michael Kubacki wrote: > >>> From: Michael Kubacki <michael.kubacki@microsoft.com> > >>> > >>> Tianocore maintains container images in the tianocore/containers repo > >>> and stores container images within the GitHub container registry. > >>> > >>> https://github.com/tianocore/containers > >>> > >>> This change adds a devcontainer.json file to the edk2 repo. This > >>> file's metadata and settings to configurate a development container > >>> for a given well-defined tool and runtime stack. > >>> > >>> More information about the devcontainer.json file is available here: > >>> https://containers.dev/implementors/json_reference/ > >>> > >>> This file is recognized by popular tools such as GitHub Codespaces > >>> and VS Code. In VS Code in particular, it makes it much easier for > >>> a user to be aware a dev container exists (via UI notifications) > >>> and to load the container. > >>> > >>> A minimal number of VS Code extensions are specified that are useful > >>> for edk2 development or to assist in complying with CI checks in > >>> place in edk2. > >>> > >>> Cc: Andrew Fish <afish@apple.com> > >>> Cc: Chris Fernald <chris.fernald@outlook.com> > >>> Cc: Leif Lindholm <quic_llindhol@quicinc.com> > >>> Cc: Michael D Kinney <michael.d.kinney@intel.com> > >>> Cc: Oliver Steffen <osteffen@redhat.com> > >>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> > >>> --- > >>> .devcontainer/devcontainer.json | 16 ++++++++++++++++ > >>> Maintainers.txt | 5 +++++ > >>> 2 files changed, 21 insertions(+) > >>> > >>> diff --git a/.devcontainer/devcontainer.json > >>> b/.devcontainer/devcontainer.json > >>> new file mode 100644 > >>> index 000000000000..592bb8cf6626 > >>> --- /dev/null > >>> +++ b/.devcontainer/devcontainer.json > >>> @@ -0,0 +1,16 @@ > >>> +{ > >>> + "image": "ghcr.io/tianocore/containers/fedora-35-dev:latest", > >>> + "postCreateCommand": "git config --global --add safe.directory * > >>> && pip install --upgrade -r pip-requirements.txt", > >>> + "customizations": { > >>> + "vscode": { > >>> + "extensions": [ > >>> + "DavidAnson.vscode-markdownlint", > >>> + "ms-azuretools.vscode-docker", > >>> + "ms-vscode-remote.remote-containers", > >>> + "ms-vscode.cpptools", > >>> + "walonli.edk2-vscode", > >>> + "zachflower.uncrustify" > >>> + ] > >>> + } > >>> + } > >>> +} > >>> diff --git a/Maintainers.txt b/Maintainers.txt > >>> index 68f603b48398..4aa7973d5156 100644 > >>> --- a/Maintainers.txt > >>> +++ b/Maintainers.txt > >>> @@ -117,6 +117,11 @@ M: Michael Kubacki > >>> <mikuback@linux.microsoft.com> [makubacki] > >>> R: Michael D Kinney <michael.d.kinney@intel.com> [mdkinney] > >>> R: Liming Gao <gaoliming@byosoft.com.cn> [lgao4] > >>> +.devcontainer/ > >>> +F: .devcontainer/ > >>> +M: Michael Kubacki <mikuback@linux.microsoft.com> [makubacki] > >>> +R: Chris Fernald <chris.fernald@outlook.com> [cfernald] > >>> + > >>> .github/ > >>> F: .github/ > >>> M: Sean Brogan <sean.brogan@microsoft.com> [spbrogan] > >> > >> > >> > >> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-02-10 5:01 ` Michael D Kinney @ 2023-02-13 14:13 ` Michael Kubacki 2023-02-14 1:28 ` Michael D Kinney 0 siblings, 1 reply; 14+ messages in thread From: Michael Kubacki @ 2023-02-13 14:13 UTC (permalink / raw) To: Michael D Kinney, devel [-- Attachment #1: Type: text/plain, Size: 130 bytes --] Hi Mike, I rebased the PR branch and updated the Ab to Rb. https://github.com/tianocore/edk2/pull/4015 Thanks, Michael [-- Attachment #2: Type: text/html, Size: 305 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file 2023-02-13 14:13 ` Michael Kubacki @ 2023-02-14 1:28 ` Michael D Kinney 0 siblings, 0 replies; 14+ messages in thread From: Michael D Kinney @ 2023-02-14 1:28 UTC (permalink / raw) To: Michael Kubacki, devel@edk2.groups.io; +Cc: Kinney, Michael D [-- Attachment #1: Type: text/plain, Size: 509 bytes --] Merged Commit: https://github.com/tianocore/edk2/commit/540522fec06b87bf11ad5624abe23b515f282d60 Mike From: Michael Kubacki <mikuback@linux.microsoft.com> Sent: Monday, February 13, 2023 6:14 AM To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file Hi Mike, I rebased the PR branch and updated the Ab to Rb. https://github.com/tianocore/edk2/pull/4015 Thanks, Michael [-- Attachment #2: Type: text/html, Size: 39472 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-02-14 1:29 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-20 20:51 [PATCH v1 1/1] .devcontainer/devcontainer.json: Add devcontainer file Michael Kubacki 2023-01-20 21:22 ` [edk2-devel] " Rebecca Cran 2023-01-20 21:57 ` Michael Kubacki 2023-01-23 9:23 ` Oliver Steffen 2023-01-23 10:46 ` Ard Biesheuvel [not found] <173C1FA3C96CC3CD.14781@groups.io> 2023-01-20 20:54 ` Michael Kubacki 2023-01-24 9:52 ` Oliver Steffen 2023-01-26 14:44 ` Michael Kubacki [not found] ` <173DE310BC2140E3.21537@groups.io> 2023-02-05 18:34 ` Michael Kubacki 2023-02-05 19:54 ` Michael D Kinney 2023-02-08 3:49 ` Michael Kubacki 2023-02-10 5:01 ` Michael D Kinney 2023-02-13 14:13 ` Michael Kubacki 2023-02-14 1:28 ` Michael D Kinney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox