public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: kettenis@xs4all.nl, devel@edk2.groups.io
Cc: Mark Kettenis <kettenis@openbsd.org>
Subject: Re: [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs
Date: Tue, 5 May 2020 18:18:33 +0200	[thread overview]
Message-ID: <4c07a094-6211-75b5-1c40-a119d996b723@arm.com> (raw)
In-Reply-To: <20200505160221.51129-1-kettenis@xs4all.nl>

On 5/5/20 6:02 PM, kettenis@xs4all.nl wrote:
> From: Mark Kettenis <kettenis@xs4all.nl>
> 
> The SoftIron Overdrive 1000 does not have a BMC so don't advertise
> the IPMI KCS interface.
> 
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>

Thanks Mark

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 72d6a1e804cb..03fb86be4146

> ---
>   Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index 005ffad..5cf865d 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -405,8 +405,6 @@ DEFINE NUM_CORES    = 4
>     # map the stack as non-executable when entering the DXE phase
>     gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
>   
> -  gAmdStyxTokenSpaceGuid.PcdEnableKcs|TRUE
> -
>   [PcdsPatchableInModule]
>   # PCIe Configuration: x4x2x2 (=2 See Include/FDKGionb.h)
>     gAmdModulePkgTokenSpaceGuid.PcdPcieCoreConfiguration|2
> 


      reply	other threads:[~2020-05-05 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 16:02 [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs kettenis
2020-05-05 16:18 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c07a094-6211-75b5-1c40-a119d996b723@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox