From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.651.1588695519914342617 for ; Tue, 05 May 2020 09:18:40 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 62CFA1FB; Tue, 5 May 2020 09:18:38 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.179]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 563FF3F71F; Tue, 5 May 2020 09:18:37 -0700 (PDT) Subject: Re: [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs To: kettenis@xs4all.nl, devel@edk2.groups.io Cc: Mark Kettenis References: <20200505160221.51129-1-kettenis@xs4all.nl> From: "Ard Biesheuvel" Message-ID: <4c07a094-6211-75b5-1c40-a119d996b723@arm.com> Date: Tue, 5 May 2020 18:18:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200505160221.51129-1-kettenis@xs4all.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/5/20 6:02 PM, kettenis@xs4all.nl wrote: > From: Mark Kettenis > > The SoftIron Overdrive 1000 does not have a BMC so don't advertise > the IPMI KCS interface. > > Signed-off-by: Mark Kettenis Thanks Mark Reviewed-by: Ard Biesheuvel Pushed as 72d6a1e804cb..03fb86be4146 > --- > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index 005ffad..5cf865d 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -405,8 +405,6 @@ DEFINE NUM_CORES = 4 > # map the stack as non-executable when entering the DXE phase > gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE > > - gAmdStyxTokenSpaceGuid.PcdEnableKcs|TRUE > - > [PcdsPatchableInModule] > # PCIe Configuration: x4x2x2 (=2 See Include/FDKGionb.h) > gAmdModulePkgTokenSpaceGuid.PcdPcieCoreConfiguration|2 >