* [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs
@ 2020-05-05 16:02 kettenis
2020-05-05 16:18 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: kettenis @ 2020-05-05 16:02 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, Mark Kettenis, Mark Kettenis
From: Mark Kettenis <kettenis@xs4all.nl>
The SoftIron Overdrive 1000 does not have a BMC so don't advertise
the IPMI KCS interface.
Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 --
1 file changed, 2 deletions(-)
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 005ffad..5cf865d 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -405,8 +405,6 @@ DEFINE NUM_CORES = 4
# map the stack as non-executable when entering the DXE phase
gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
- gAmdStyxTokenSpaceGuid.PcdEnableKcs|TRUE
-
[PcdsPatchableInModule]
# PCIe Configuration: x4x2x2 (=2 See Include/FDKGionb.h)
gAmdModulePkgTokenSpaceGuid.PcdPcieCoreConfiguration|2
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs
2020-05-05 16:02 [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs kettenis
@ 2020-05-05 16:18 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-05-05 16:18 UTC (permalink / raw)
To: kettenis, devel; +Cc: Mark Kettenis
On 5/5/20 6:02 PM, kettenis@xs4all.nl wrote:
> From: Mark Kettenis <kettenis@xs4all.nl>
>
> The SoftIron Overdrive 1000 does not have a BMC so don't advertise
> the IPMI KCS interface.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
Thanks Mark
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Pushed as 72d6a1e804cb..03fb86be4146
> ---
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index 005ffad..5cf865d 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -405,8 +405,6 @@ DEFINE NUM_CORES = 4
> # map the stack as non-executable when entering the DXE phase
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
>
> - gAmdStyxTokenSpaceGuid.PcdEnableKcs|TRUE
> -
> [PcdsPatchableInModule]
> # PCIe Configuration: x4x2x2 (=2 See Include/FDKGionb.h)
> gAmdModulePkgTokenSpaceGuid.PcdPcieCoreConfiguration|2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-05 16:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-05 16:02 [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs kettenis
2020-05-05 16:18 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox