From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mx.groups.io with SMTP id smtpd.web12.6965.1598329017453776564 for ; Mon, 24 Aug 2020 21:16:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=DAQeryFT; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.208.44, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-ed1-f44.google.com with SMTP id l23so9982619edv.11 for ; Mon, 24 Aug 2020 21:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=6ifSxVb8q7mdVn3IF/45+h0bHhl2SY9Fz5SPAT+qcXg=; b=DAQeryFTt7VU7TaMy52uCQ5Tjvg6sKDWcL84D62ntjHMW5JcFhgU4e8yOOs4KEgjS4 jXiLqmxpwXpWPh686yZDHDrQCFE/3M/E9Cjejftaq7FPtDwa1acSgGovHokcl+2d/Y5Q Kudz8u3lAkKuL0rt/AU08iUo8ZMhM9uv0Qclo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=6ifSxVb8q7mdVn3IF/45+h0bHhl2SY9Fz5SPAT+qcXg=; b=YY35mA+tyviWo7u/L74kDl82NhcXtQb3PLEo2RjmQZVqJDnkrQpI2zQVUqluY50lD/ KlbA35nPwovOo445sWWr6MCagdZLaWjQOoqxxdAsR72GA8iMyZzK3skfybqrg4IuIuPy FShZEVwqHi3SqK0dyrriiEYONu/7m71Akv5WWyk0v8LVX1VC1Awtf3ldht4JpAK9mQF/ WYLr7Ll9g3n8N1Iq/qYcO6QO8RDxuZc/8kD6u8zsKNp9W9J9tfQig3zvUDGD5UZp29+b 8sdHfIieKNSCzttdws1C553q/mYFguocLpvOirkJjSyOC5KYwQeyA+sWMXHg9+IZmPro G+fw== X-Gm-Message-State: AOAM530kly+IjYnJ/P3dQDO35JL7jOgjMsN22S8WANRL+X6K6FaxSO+i I59ipx6j+DKtk2PRGnRrEB/U6sf/PNxljx9PTMoDCA== X-Google-Smtp-Source: ABdhPJzxKh1khrg/MMcA/Sa7w+wWtF5/PmqAwVuJss6er+2QtjuQ6FeeiOMDU5aEfxHsfuiYgWQAH78jJgzDAOK5KPM= X-Received: by 2002:a50:ec90:: with SMTP id e16mr8564977edr.234.1598329015766; Mon, 24 Aug 2020 21:16:55 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200821160555.21436-1-vladimir.olovyannikov@broadcom.com> <20200821160555.21436-2-vladimir.olovyannikov@broadcom.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQE6eo4XhQB8xmbDp5R2QLUMGGowAQJAGVYAAXgws7OqYnUnsA== Date: Mon, 24 Aug 2020 21:16:54 -0700 Message-ID: <4c300ea0874f19d4138084a4c4bed9a2@mail.gmail.com> Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Laszlo Ersek , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd Content-Type: text/plain; charset="UTF-8" Hi Laszlo, Sorry, I should've checked. No, there was no intention at all to even touch an OpenSSL lib. I will re-send tomorrow morning. Thank you, Vladimir > -----Original Message----- > From: Laszlo Ersek > Sent: Monday, August 24, 2020 12:43 PM > To: devel@edk2.groups.io; vladimir.olovyannikov@broadcom.com > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v6 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > On 08/21/20 18:05, Vladimir Olovyannikov via groups.io wrote: > > Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > > image downloading from http/https servers. > > HTTP download speed is usually faster than tftp. > > The client is based on the same approach as tftp dynamic command, and > > uses the same UEFI Shell command line parameters. This makes it easy > > integrating http into existing UEFI Shell scripts. > > Note that to enable HTTP download, feature Pcd > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to > > TRUE. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > > > Signed-off-by: Vladimir Olovyannikov > > > > Cc: Samer El-Haj-Mahmoud > > Cc: Laszlo Ersek > > Cc: Zhichao Gao > > Cc: Maciej Rabeda > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Cc: Ray Ni > > Cc: Liming Gao > > Cc: Nd > > --- > > ShellPkg/ShellPkg.dec | 1 + > > ShellPkg/ShellPkg.dsc | 5 + > > .../HttpDynamicCommand/HttpApp.inf | 58 + > > .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > > .../DynamicCommand/HttpDynamicCommand/Http.h | 88 + > > ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > > .../DynamicCommand/HttpDynamicCommand/Http.c | 1693 > +++++++++++++++++ > > .../HttpDynamicCommand/HttpApp.c | 61 + > > .../HttpDynamicCommand/HttpDynamicCommand.c | 137 ++ > > CryptoPkg/Library/OpensslLib/openssl | 2 +- > > .../HttpDynamicCommand/Http.uni | 116 ++ > > 11 files changed, 2228 insertions(+), 1 deletion(-) create mode > > 100644 ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > > create mode 100644 > > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf > > create mode 100644 > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > > create mode 100644 > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > > create mode 100644 > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > > create mode 100644 > > > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .c > > create mode 100644 > > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni > > [...] > > > diff --git a/CryptoPkg/Library/OpensslLib/openssl > > b/CryptoPkg/Library/OpensslLib/openssl > > index e2e09d9fba11..c3656cc594da 160000 > > --- a/CryptoPkg/Library/OpensslLib/openssl > > +++ b/CryptoPkg/Library/OpensslLib/openssl > > @@ -1 +1 @@ > > -Subproject commit e2e09d9fba1187f8d6aafaa34d4172f56f1ffb72 > > +Subproject commit c3656cc594daac8167721dde7220f0e59ae146fc > > your patch includes a hunk that moves our openssl submodule from 1.1.1g > back to ~1.1.1d. > > I think that must be unintentional; can you please drop this hunk and post > v7? > > Thanks > Laszlo