From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path
Date: Mon, 8 Oct 2018 14:43:10 +0800 [thread overview]
Message-ID: <4c35d6e1-a769-912a-af77-77fdfa3e483f@Intel.com> (raw)
In-Reply-To: <20181008033158.10652-1-dandan.bi@intel.com>
On 10/8/2018 11:31 AM, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225
>
> According to UEFI spec, the string expression of UTF8 vendor
> device node should be displayed as: VenUtf8(). Current code
> display it as: VenUft8() by mistake when convert device
> path node to text.
>
> This commit is to fix this bug.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> index 7d8d304f6f..85f5e97131 100644
> --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c
> @@ -193,11 +193,11 @@ DevPathToTextVendor (
> return ;
> } else if (CompareGuid (&Vendor->Guid, &gEfiVT100PlusGuid)) {
> UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()");
> return ;
> } else if (CompareGuid (&Vendor->Guid, &gEfiVTUTF8Guid)) {
> - UefiDevicePathLibCatPrint (Str, L"VenUft8()");
> + UefiDevicePathLibCatPrint (Str, L"VenUtf8()");
> return ;
> } else if (CompareGuid (&Vendor->Guid, &gEfiUartDevicePathGuid)) {
> FlowControlMap = (((UART_FLOW_CONTROL_DEVICE_PATH *) Vendor)->FlowControlMap);
> switch (FlowControlMap & 0x00000003) {
> case 0:
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
next prev parent reply other threads:[~2018-10-08 6:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 3:31 [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path Dandan Bi
2018-10-08 3:31 ` [patch 2/5] MdePkg: Correct the string order of ACPI Expanded Device Path Dandan Bi
2018-10-08 6:45 ` Ni, Ruiyu
2018-10-08 3:31 ` [patch 3/5] MdePkg: Correct condition check for AcpiExp text format Dandan Bi
2018-10-08 6:49 ` Ni, Ruiyu
2018-10-08 3:31 ` [patch 4/5] MdePkg: Add PciRoot/PcieRoot text for ACPI Expanded Device Path Dandan Bi
2018-10-08 6:50 ` Ni, Ruiyu
2018-10-08 3:31 ` [patch 5/5] MdePkg: Use VENDOR_DEVICE_PATH structure for Debug Port device path Dandan Bi
2018-10-08 6:54 ` Ni, Ruiyu
2018-10-08 6:43 ` Ni, Ruiyu [this message]
2018-10-08 11:54 ` [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor " Laszlo Ersek
2018-10-08 14:36 ` Bi, Dandan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c35d6e1-a769-912a-af77-77fdfa3e483f@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox