From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7C3EA21160A2E for ; Sun, 7 Oct 2018 23:42:03 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2018 23:42:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,355,1534834800"; d="scan'208";a="79578550" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2018 23:42:02 -0700 To: Dandan Bi , edk2-devel@lists.01.org Cc: Michael D Kinney , Liming Gao References: <20181008033158.10652-1-dandan.bi@intel.com> From: "Ni, Ruiyu" Message-ID: <4c35d6e1-a769-912a-af77-77fdfa3e483f@Intel.com> Date: Mon, 8 Oct 2018 14:43:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181008033158.10652-1-dandan.bi@intel.com> Subject: Re: [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 06:42:03 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/8/2018 11:31 AM, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225 > > According to UEFI spec, the string expression of UTF8 vendor > device node should be displayed as: VenUtf8(). Current code > display it as: VenUft8() by mistake when convert device > path node to text. > > This commit is to fix this bug. > > Cc: Ruiyu Ni > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > index 7d8d304f6f..85f5e97131 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > @@ -193,11 +193,11 @@ DevPathToTextVendor ( > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiVT100PlusGuid)) { > UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()"); > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiVTUTF8Guid)) { > - UefiDevicePathLibCatPrint (Str, L"VenUft8()"); > + UefiDevicePathLibCatPrint (Str, L"VenUtf8()"); > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiUartDevicePathGuid)) { > FlowControlMap = (((UART_FLOW_CONTROL_DEVICE_PATH *) Vendor)->FlowControlMap); > switch (FlowControlMap & 0x00000003) { > case 0: > Reviewed-by: Ruiyu Ni -- Thanks, Ray