From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, tphan@ventanamicro.com
Cc: michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
zhiguang.liu@intel.com, kraxel@redhat.com,
rahul1.kumar@intel.com, ray.ni@intel.com,
sunilvl@ventanamicro.com, jiewen.yao@intel.com,
andrei.warkentin@intel.com, ardb+tianocore@kernel.org
Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/RiscVVirt: Override Svpbmt extension
Date: Wed, 7 Feb 2024 21:02:40 +0100 [thread overview]
Message-ID: <4c3eab2b-c7e9-21cd-3bfc-47c7d0e6de6a@redhat.com> (raw)
In-Reply-To: <20240207012910.2133-4-tphan@ventanamicro.com>
On 2/7/24 02:29, Tuan Phan wrote:
> Override Svpbmt extension that be disabled by default.
>
> Signed-off-by: Tuan Phan <tphan@ventanamicro.com>
> ---
> OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> index 6bc7c90f31dc..b8338d2eb5f5 100644
> --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc
> @@ -203,7 +203,7 @@
> gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE
>
> [PcdsFixedAtBuild.common]
> - gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
> + gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFF8
> gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
> gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000
> gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
(Meaning that, IMO, the patch does what it says on the tin. *Why* the
disablement is justified / necessary, I can't say, neither does the
commit message. It's probably that QEMU/KVM don't implement Svpbmt.)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115247): https://edk2.groups.io/g/devel/message/115247
Mute This Topic: https://groups.io/mt/104211196/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-02-07 20:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 1:29 [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension Tuan Phan
2024-02-07 1:29 ` [edk2-devel] [PATCH v2 1/3] MdePkg.dec: RISC-V: Define override bit for " Tuan Phan
2024-02-07 18:01 ` Laszlo Ersek
2024-02-07 1:29 ` [edk2-devel] [PATCH v2 2/3] UefiCpuPkg: RISC-V: MMU: Support " Tuan Phan
2024-02-07 18:15 ` Laszlo Ersek
2024-02-28 18:00 ` Tuan Phan
2024-02-07 1:29 ` [edk2-devel] [PATCH v2 3/3] OvmfPkg/RiscVVirt: Override " Tuan Phan
2024-02-07 20:02 ` Laszlo Ersek [this message]
2024-02-07 20:08 ` Tuan Phan
2024-02-15 5:42 ` [edk2-devel] [PATCH v2 0/3] RISC-V: Support " Andrei Warkentin
2024-02-15 6:16 ` Tuan Phan
[not found] ` <17B3F4C51A165C5A.28807@groups.io>
2024-02-27 4:34 ` Tuan Phan
2024-02-28 4:42 ` Sunil V L
2024-02-28 17:22 ` Tuan Phan
2024-03-02 3:36 ` Andrei Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c3eab2b-c7e9-21cd-3bfc-47c7d0e6de6a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox