From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1AAC21E87984 for ; Thu, 14 Sep 2017 12:53:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9412DC058EA3; Thu, 14 Sep 2017 19:56:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9412DC058EA3 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-80.rdu2.redhat.com [10.10.121.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CA545D9C8; Thu, 14 Sep 2017 19:56:21 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Jordan Justen , Tom Lendacky , Ard Biesheuvel References: <20170914110822.112540-1-brijesh.singh@amd.com> <20170914110822.112540-7-brijesh.singh@amd.com> From: Laszlo Ersek Message-ID: <4c556ce4-356c-1126-d111-a735a9a9f8ea@redhat.com> Date: Thu, 14 Sep 2017 21:56:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170914110822.112540-7-brijesh.singh@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 14 Sep 2017 19:56:23 +0000 (UTC) Subject: Re: [PATCH v3 6/8] OvmfPkg/VirtioNetDxe: add Tx packet map/unmap helper functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 19:53:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/14/17 13:08, Brijesh Singh wrote: > When device is behind IOMMU, driver is require to pass the device address > of TxBuf in the Tx VRING. The patch adds helper functions and data > structure to map and unmap the TxBuf system physical address to a device > address. > > Since the TxBuf is returned back to caller from VirtioNetGetStatus() hence > we use OrderedCollection interface to save the TxBuf system physical to > device address mapping. After the TxBuf is succesfully transmitted > VirtioNetUnmapTxBuf() does the reverse lookup in OrderedCollection data > structure to get the system physical address of TxBuf for a given device > address. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Tom Lendacky > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh > --- > OvmfPkg/VirtioNetDxe/VirtioNet.inf | 1 + > OvmfPkg/VirtioNetDxe/VirtioNet.h | 38 ++++ > OvmfPkg/VirtioNetDxe/SnpInitialize.c | 18 +- > OvmfPkg/VirtioNetDxe/SnpSharedHelpers.c | 224 ++++++++++++++++++++ > 4 files changed, 279 insertions(+), 2 deletions(-) Reviewed-by: Laszlo Ersek