public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "GuoMinJ" <newexplorerj@gmail.com>
To: devel@edk2.groups.io
Cc: GuoMinJ <newexplorerj@gmail.com>
Subject: [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2.
Date: Thu, 13 Feb 2020 16:33:48 +0800	[thread overview]
Message-ID: <4c586ce34f95b14d8c62de2eaafc1905705246d9.1581494371.git.newexplorerj@gmail.com> (raw)
In-Reply-To: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com>
In-Reply-To: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=2515

Change the SecurityPkg to match the ECC check rule

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
 SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
index 1fe1955cab..9a5f987e68 100644
--- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
+++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
@@ -772,7 +772,7 @@ Tcg2GetEventLog (
   return EFI_SUCCESS;
 }
 
-/*
+/**
   Return if this is a Tcg800155PlatformIdEvent.
 
   @param[in]      NewEventHdr         Pointer to a TCG_PCR_EVENT_HDR/TCG_PCR_EVENT_EX data structure.
@@ -783,7 +783,7 @@ Tcg2GetEventLog (
   @retval TRUE   This is a Tcg800155PlatformIdEvent.
   @retval FALSE  This is NOT a Tcg800155PlatformIdEvent.
 
-*/
+**/
 BOOLEAN
 Is800155Event (
   IN      VOID                      *NewEventHdr,
diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
index 7e94a8e1ed..4852d86906 100644
--- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
+++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
@@ -460,7 +460,7 @@ MeasureCRTMVersion (
            );
 }
 
-/*
+/**
   Get the FvName from the FV header.
 
   Causion: The FV is untrusted input.
@@ -470,7 +470,7 @@ MeasureCRTMVersion (
 
   @return FvName pointer
   @retval NULL   FvName is NOT found
-*/
+**/
 VOID *
 GetFvName (
   IN EFI_PHYSICAL_ADDRESS           FvBase,
-- 
2.17.1


  parent reply	other threads:[~2020-02-13  8:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13  8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
2020-02-13  8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
2020-02-14  1:17   ` [edk2-devel] " Liming Gao
2020-02-14  6:36   ` Wu, Hao A
2020-02-13  8:33 ` GuoMinJ [this message]
2020-02-13 10:23   ` [edk2-devel] [PATCH 3/3] SecurityPkg: " Yao, Jiewen
2020-02-13  9:18 ` [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: " Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c586ce34f95b14d8c62de2eaafc1905705246d9.1581494371.git.newexplorerj@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox