From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by mx.groups.io with SMTP id smtpd.web12.3513.1581582860365729637 for ; Thu, 13 Feb 2020 00:34:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LJyZ9rsO; spf=pass (domain: gmail.com, ip: 209.85.215.194, mailfrom: newexplorerj@gmail.com) Received: by mail-pg1-f194.google.com with SMTP id w21so2690823pgl.9 for ; Thu, 13 Feb 2020 00:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=6gwDX6MAYzYRSfcedG7QUWN4ZESriyiDehOz8Uz4wyU=; b=LJyZ9rsOVWEy+YlcxtrgrpTK2U5OFY1jBV+SN6gcC1rFg0qOqCfSWW7m2LtEgE0ieE N+SISB7V961Urg7vIsSGAh0B8sOI8AlHbglCDm09BLHw54xVz3wzOv8w+ciia3c8rf6R dUcOmZyc4vKQTySN7rqCjaQCIZmH1st29XXR6IHShv5o38tVxkFGxOV4Bf0DrL+MHW9i Ol3JGnzHF7j00YluOBq5PW2j7m0T47zebFHYwwNbKZLDRRyg5bjsna6cdHlXGumjiBYT OcJ4pCVpaoc2OuTI57w4KoJ4IkYeIWzy6QTEq0UYfA8Q8DBcpVvXVAwzCuUjg0xA8OdS G/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=6gwDX6MAYzYRSfcedG7QUWN4ZESriyiDehOz8Uz4wyU=; b=V/JwL67V054++jiN8IM5itxtUG8jczknVta8+QXrrYF7XOaHfYXnwul9DBCbHjhs+V fZrdyIf/8dIHOixWdog+cZDYohncnMlb2Ul97OFHQtZapNbAzyYalGgvhggVx+dCOOdg y1P8z2DrcGwbSocfT4tIMCqyAJvoNad6DJfMYzXgdp8B0k0it7fPPRnS4I1K51oa3LKO KfEv47eO9LYfNA4roG0Tpcp6Muf6fXnePp9Bf0jM7JZ3wQh9UuqnCX6H0F9ZBxg8j4N/ QB8Khzz70wadVpzGWWKsfbQ4oSm6mJEt+mURgd/wPgGVFx3A7LIxKhCUaYlVoV57PJEp ibcA== X-Gm-Message-State: APjAAAXmw7+BzOLAm59iJvsOkgLebx/nFAw9xgdpBin6lsP0HetSI8Ab +HpOe32U28a+tocTSeffqimkSRek4C/zkw== X-Google-Smtp-Source: APXvYqx6AuMf6fQpW+BzNscx37PdkckQUTqaHgTB3pu26m5dT0Nfqydx4KYNF2hPf7Lg7BSoNI6XSQ== X-Received: by 2002:a62:8e0a:: with SMTP id k10mr13217655pfe.49.1581582859519; Thu, 13 Feb 2020 00:34:19 -0800 (PST) Return-Path: Received: from localhost.localdomain ([45.135.186.76]) by smtp.gmail.com with ESMTPSA id n2sm2019886pfq.50.2020.02.13.00.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 00:34:18 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2. Date: Thu, 13 Feb 2020 16:33:48 +0800 Message-Id: <4c586ce34f95b14d8c62de2eaafc1905705246d9.1581494371.git.newexplorerj@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> References: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> In-Reply-To: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> References: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> https://bugzilla.tianocore.org/show_bug.cgi?id=2515 Change the SecurityPkg to match the ECC check rule Signed-off-by: GuoMinJ --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c index 1fe1955cab..9a5f987e68 100644 --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c @@ -772,7 +772,7 @@ Tcg2GetEventLog ( return EFI_SUCCESS; } -/* +/** Return if this is a Tcg800155PlatformIdEvent. @param[in] NewEventHdr Pointer to a TCG_PCR_EVENT_HDR/TCG_PCR_EVENT_EX data structure. @@ -783,7 +783,7 @@ Tcg2GetEventLog ( @retval TRUE This is a Tcg800155PlatformIdEvent. @retval FALSE This is NOT a Tcg800155PlatformIdEvent. -*/ +**/ BOOLEAN Is800155Event ( IN VOID *NewEventHdr, diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c index 7e94a8e1ed..4852d86906 100644 --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c @@ -460,7 +460,7 @@ MeasureCRTMVersion ( ); } -/* +/** Get the FvName from the FV header. Causion: The FV is untrusted input. @@ -470,7 +470,7 @@ MeasureCRTMVersion ( @return FvName pointer @retval NULL FvName is NOT found -*/ +**/ VOID * GetFvName ( IN EFI_PHYSICAL_ADDRESS FvBase, -- 2.17.1