public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.
@ 2020-02-13  8:33 newexplorerj
  2020-02-13  8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: newexplorerj @ 2020-02-13  8:33 UTC (permalink / raw)
  To: devel; +Cc: GuoMinJ

https://bugzilla.tianocore.org/show_bug.cgi?id=2515

Change the FmpDevicePkg to match the ECC check rule

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 FmpDevicePkg/FmpDxe/Dependency.c | 4 ++--
 FmpDevicePkg/FmpDxe/Dependency.h | 2 +-
 FmpDevicePkg/FmpDxe/FmpDxe.c     | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/FmpDevicePkg/FmpDxe/Dependency.c b/FmpDevicePkg/FmpDxe/Dependency.c
index b63a36b989..8f97c42916 100644
--- a/FmpDevicePkg/FmpDxe/Dependency.c
+++ b/FmpDevicePkg/FmpDxe/Dependency.c
@@ -163,8 +163,8 @@ Push (
 /**
   Pop an element from the stack.
 
-  @param[in]  Value                  Element to pop.
-  @param[in]  Type                   Type of element.
+  @param[out]  Element                Element to pop.
+  @param[in]   Type                   Type of element.
 
   @retval EFI_SUCCESS            The value was popped onto the stack.
   @retval EFI_ACCESS_DENIED      The pop operation underflowed the stack.
diff --git a/FmpDevicePkg/FmpDxe/Dependency.h b/FmpDevicePkg/FmpDxe/Dependency.h
index a2aaaceeae..badd2542d6 100644
--- a/FmpDevicePkg/FmpDxe/Dependency.h
+++ b/FmpDevicePkg/FmpDxe/Dependency.h
@@ -56,7 +56,7 @@ EvaluateImageDependencies (
   IN CONST EFI_GUID                ImageTypeId,
   IN CONST UINT32                  Version,
   IN CONST EFI_FIRMWARE_IMAGE_DEP  *Dependencies,
-  IN CONST UINT32                  DependenciesSize,
+  IN CONST UINT32                  DepexSize,
   OUT BOOLEAN                      *IsSatisfied
   );
 
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index aa92331966..5b523291e4 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -413,7 +413,7 @@ PopulateDescriptor (
     }
     if (!EFI_ERROR (Status) && Image != NULL) {
       IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, ImageSize, &DepexSize);
-      if (IsDepexValid == TRUE) {
+      if (IsDepexValid) {
         Private->Descriptor.Dependencies = AllocatePool (DepexSize);
         if (Private->Descriptor.Dependencies != NULL) {
           CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, DepexSize);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-14  6:36 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-13  8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
2020-02-13  8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
2020-02-14  1:17   ` [edk2-devel] " Liming Gao
2020-02-14  6:36   ` Wu, Hao A
2020-02-13  8:33 ` [PATCH 3/3] SecurityPkg: " GuoMinJ
2020-02-13 10:23   ` [edk2-devel] " Yao, Jiewen
2020-02-13  9:18 ` [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: " Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox