Re: [edk2-devel] [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build

["Laszlo Ersek" <lersek@redhat.com>]

On 04/25/19 14:37, Liming Gao wrote:
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  NetworkPkg/NetworkPkg.dsc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index 66d43bec12..955e45e84d 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -55,6 +55,7 @@
>    FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>    FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

"MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf" seems to be
ARM/AARCH64 only. Packages that are not inherently specific to
ARM/AARCH64 include this library resolution only in the following sections:

[LibraryClasses.ARM, LibraryClasses.AARCH64]

But the above hunk, from NetworkPkg.dsc, seems to fall under
[LibraryClasses]. I think that might break NetworkPkg.dsc builds on
IA32/X64.

>  
>  [LibraryClasses.common.UEFI_DRIVER]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> @@ -72,6 +73,7 @@
>    # [LibraryClasses.ARM] and NULL mean link this library into all ARM images.
>    #
>    NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>  
>  [PcdsFeatureFlag]
>    gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE

I'll let Ard & Leif comment on this.


> @@ -115,7 +117,7 @@
>    NetworkPkg/Application/IpsecConfig/IpSecConfig.inf
>    NetworkPkg/Application/VConfig/VConfig.inf
>  
> -[Components.IA32, Components.X64]
> +[Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
>    NetworkPkg/IpSecDxe/IpSecDxe.inf
>    NetworkPkg/IScsiDxe/IScsiDxe.inf
>    NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> 

Shouldn't we just merge this section into [Components] above?

Or are these modules unsuitable for EBC?

Thanks
Laszlo