From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Fri, 26 Apr 2019 15:04:23 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2E341317556F;
	Fri, 26 Apr 2019 22:04:23 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-104.rdu2.redhat.com [10.10.121.104])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 8FF211001E78;
	Fri, 26 Apr 2019 22:04:21 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build
To: devel@edk2.groups.io, liming.gao@intel.com,
 Leif Lindholm <leif.lindholm@linaro.org>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190425123735.10960-1-liming.gao@intel.com>
 <20190425123735.10960-2-liming.gao@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <4c6397c9-a0d8-0624-b41e-8f54e33986de@redhat.com>
Date: Sat, 27 Apr 2019 00:04:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190425123735.10960-2-liming.gao@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 26 Apr 2019 22:04:23 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/25/19 14:37, Liming Gao wrote:
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  NetworkPkg/NetworkPkg.dsc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
> index 66d43bec12..955e45e84d 100644
> --- a/NetworkPkg/NetworkPkg.dsc
> +++ b/NetworkPkg/NetworkPkg.dsc
> @@ -55,6 +55,7 @@
>    FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>    FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
>    SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf

"MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf" seems to be
ARM/AARCH64 only. Packages that are not inherently specific to
ARM/AARCH64 include this library resolution only in the following sections:

[LibraryClasses.ARM, LibraryClasses.AARCH64]

But the above hunk, from NetworkPkg.dsc, seems to fall under
[LibraryClasses]. I think that might break NetworkPkg.dsc builds on
IA32/X64.

>  
>  [LibraryClasses.common.UEFI_DRIVER]
>    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> @@ -72,6 +73,7 @@
>    # [LibraryClasses.ARM] and NULL mean link this library into all ARM images.
>    #
>    NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>  
>  [PcdsFeatureFlag]
>    gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE

I'll let Ard & Leif comment on this.


> @@ -115,7 +117,7 @@
>    NetworkPkg/Application/IpsecConfig/IpSecConfig.inf
>    NetworkPkg/Application/VConfig/VConfig.inf
>  
> -[Components.IA32, Components.X64]
> +[Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
>    NetworkPkg/IpSecDxe/IpSecDxe.inf
>    NetworkPkg/IScsiDxe/IScsiDxe.inf
>    NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> 

Shouldn't we just merge this section into [Components] above?

Or are these modules unsuitable for EBC?

Thanks
Laszlo