From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web11.31715.1677608449490637558 for ; Tue, 28 Feb 2023 10:20:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=HP1okaJc; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C725F5C013E; Tue, 28 Feb 2023 13:20:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 28 Feb 2023 13:20:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1677608448; x= 1677694848; bh=V/grCqrbnN4JiZ3V0HgUZucTPUoGoYRSXH3z25T6WWs=; b=H P1okaJcfsP6g7uPSrxCFBoqtFSN46YP14ZeGakWnPbby+t8f67HL7//1ksdlx0lF qfYJok+4gi+mFnPVdO/sfwcp4HfhhtnjTiODnFm/vM9oqG/yTF88eR0O9efyjrex bFWDN2YpU+SQ0OkvLQ6jT33BaG30AmWSTkW/deyCGIn1UOm2qIF0O1bWxI8Fkv0T CwPgzzPhd1cY7xLBttWMlHeNW18kJiWruQDjucjQBWkFes70K4H1q/lGc8q2KB5y GfrF8bm/ylm5LhkWGChD9gEahGfva/zF0C/crgx1/awuva3512dlP226BWqsfSRD R62ugpuk2JQcvVvBltTVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677608448; x= 1677694848; bh=V/grCqrbnN4JiZ3V0HgUZucTPUoGoYRSXH3z25T6WWs=; b=G Ibq/1l2pw3W0WK4IHK5dI8a+Bjg8NA9daMfLp8CKldfUOnpERjQClXvE40pRRId1 yW70wDHTNqgK1CSOSktXvI4M/HE/0k7LMfchfDn3NBIyEYOBuoIn2tBOhn9l2aOo RQ9dWbiaH40+eJ2MhdDX4pxdWi6juz23v9vK+yC90XrjN9777fj3SE3mbTj5OCVC Zp5z/P3cm4KDVaH5XjEyZvrUcUPx/e0I+ckkOOA/PElw6VR2cI9MHx8W38VYnrD9 MEnzJhchnN59wziqzVAPzfxJYZRxCUhKf3uM/W1fhSeb2Ruf4aLmk5//K4+oknIa SsCDSo5BDdhJTvGEhpK0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelfedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeelkeeihfeiudeludeitefgkeehteehveegfeetfeelvdelfefhvedvgeeh uedtkeenucffohhmrghinhepvgguihhtohhrtghonhhfihhgrdhorhhgnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghs ughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Feb 2023 13:20:47 -0500 (EST) Message-ID: <4c6db5b3-57ad-e3e3-9074-98741b7fd4fb@bsdio.com> Date: Tue, 28 Feb 2023 11:20:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details To: "Kinney, Michael D" , Ard Biesheuvel , "devel@edk2.groups.io" Cc: Andrew Fish , Leif Lindholm References: <20230227034702.82215-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Before I sent out an official v2 patch, does the following look good? diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 000000000000..587d5bbaa884 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,31 @@ +# EditorConfig file: https://EditorConfig.org + +root = true + +[*] +charset = latin1 +end_of_line = crlf +indent_style = space +indent_size = 2 +insert_final_newline = true +trim_trailing_whitespace = true + +[*.py] +charset = utf-8 +indent_style = space +indent_size = 4 + +[*.sh] +end_of_line = lf + +[.gitattributes] +end_of_line = lf + +[.mailmap] +charset = utf-8 + +[Maintainers.txt] +charset = utf-8 + +[Makefile,GNUmakefile] +indent_style = tab -- Rebecca Cran On 2/27/23 11:23 AM, Kinney, Michael D wrote: > .gitmodules also must also use tabs. > >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Monday, February 27, 2023 10:22 AM >> To: Ard Biesheuvel ; devel@edk2.groups.io; rebecca@bsdio.com >> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D >> Subject: RE: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> .gitmodules must be lf. Not sure about other git config files. >> >> Mike >> >>> -----Original Message----- >>> From: Ard Biesheuvel >>> Sent: Monday, February 27, 2023 10:18 AM >>> To: devel@edk2.groups.io; rebecca@bsdio.com >>> Cc: Kinney, Michael D ; Andrew Fish ; Leif Lindholm >>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>> >>> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran wrote: >>>> Is it just .sh files that need lf endings, or are there others? >>>> >>> I think this only applies to .sh files. >>> >>>> >>>> On 2/27/23 9:14 AM, Michael D Kinney wrote: >>>>> There are a few file types that must be lf instead of crlf. Can those be added as well? >>>>> >>>>> Mike >>>>> >>>>>> -----Original Message----- >>>>>> From: devel@edk2.groups.io On Behalf Of Rebecca Cran >>>>>> Sent: Monday, February 27, 2023 5:03 AM >>>>>> To: Ard Biesheuvel ; devel@edk2.groups.io >>>>>> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D >>> >>>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>>> >>>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >>>>>> >>>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote: >>>>>>>> Add a .editorconfig file which editors can use for basic formatting >>>>>>>> details of files, such as tabs/spaces, line endings etc. >>>>>>>> >>>>>>>> Signed-off-by: Rebecca Cran >>>>>>> Thank you very much for this - this is very useful. >>>>>>> >>>>>>> Acked-by: Ard Biesheuvel >>>>>>> >>>>>>> Could we add .dsc/.inf/.dec/etc files as well? >>>>>> I'll move the c/c++ indentation up to the [*] section so it applies to >>>>>> .dsc/.inf/etc too. >>>>>> >>>>>> >>>>>> -- >>>>>> Rebecca Cran >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>>