From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web10.5799.1617875288835640928 for ; Thu, 08 Apr 2021 02:48:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=QEMBhRrw; spf=pass (domain: akeo.ie, ip: 209.85.221.51, mailfrom: pete@akeo.ie) Received: by mail-wr1-f51.google.com with SMTP id q26so1408550wrz.9 for ; Thu, 08 Apr 2021 02:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QKuCMBSyVNgjsc4q3M5O7dTt3YAA9wOPEf31wsJUGHM=; b=QEMBhRrw6mGn8nOESJlDClV6jcH8xmercYnHeGio/VqpLJ9kXgVZF9N+dvqh+H0bbT mBvleiWIodb2cY6fnqXM6s27abfMMxzZ67nWy/JWNzTnf4rbMMkyMhTzing/RRq1O+3X J8BAHtqrgCz9V/ww9rd09ddtGDyxRtpcIu0ub7MQLzO5421KDKr1Z0G0tkzCrSK7ZIi1 XFqeE/DvCABOW07B1+wdkOx8f/ynSy0KevMpQ3BImBDDDF+VcaZHpph1btiXIrtT6Zxk DYAWscfm33utY1V8eXkPXdkaYsn9J3dApqwksLJI/1D/81MqIwHjy25BiqXgD46afJ4l 6ntw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QKuCMBSyVNgjsc4q3M5O7dTt3YAA9wOPEf31wsJUGHM=; b=DUK/MlnmXR3VMSgxFL3ch/Kb0dCfDKZi4va9AstAjAZNI9Js17z0i3SZM4C81dZ7kR Iqi1FZtmyarauNHvNA78c8qr6z9ZUHTuMwTAXS0+AfXWPoDpK77/fWYsKkz/zVileb6g hJQ0FdiIdERvn+rd2bsfJX2GA0QysNWJDio+nlmVp+3mP3t9kj5iUWWo3RluH4gLSZRf VGTWRBbGCDk20fWJfrquMahFO62w6Nt+lctoh7ODDIILRZlV4DB4W2WLQ8g5Xhm5t+dq 9COfrAyYo19RISTRmHAfZmdR7R+gN8TIjUsWXc/WkMHhPTXG1vuVWStsRUwhhcPkBZUk y4XQ== X-Gm-Message-State: AOAM532Lg8O57W9qAzi6HFLgfG05ABKp4WgSb51vkDvwbk66Qq4qzCGr t0l+XGfNd2VJ8fthxBv3wYyKqg== X-Google-Smtp-Source: ABdhPJw4HiMLA2239KjIkL416pLK/mCPubmmj9DFAPt51P9h2W6RE2YA2o4oYem1XXBNLbzwI+q9hg== X-Received: by 2002:a5d:5686:: with SMTP id f6mr10252679wrv.204.1617875287499; Thu, 08 Apr 2021 02:48:07 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.65.130]) by smtp.googlemail.com with ESMTPSA id f2sm13282488wmp.20.2021.04.08.02.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 02:48:07 -0700 (PDT) Subject: Re: [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components To: Jeremy Linton , devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com References: <20210408055843.2883563-1-jeremy.linton@arm.com> <20210408055843.2883563-3-jeremy.linton@arm.com> From: "Pete Batard" Message-ID: <4cdf830d-3a99-9f85-28a7-bc749247fc1b@akeo.ie> Date: Thu, 8 Apr 2021 10:48:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210408055843.2883563-3-jeremy.linton@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021.04.08 06:58, Jeremy Linton wrote: > Add some additional IORT nodes for the USB & EMMC devices, realistically > we probably only need to have a single node with the lowest AddressSizeLimit > but this is conceptually "cleaner" should anyone actually try and use these > values rather than the _DMA provided ones. > > Signed-off-by: Jeremy Linton > --- > Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++++++++++- > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/Platform/RaspberryPi/AcpiTables/Iort.aslc b/Platform/RaspberryPi/AcpiTables/Iort.aslc > index 00720194bb..810307ae37 100644 > --- a/Platform/RaspberryPi/AcpiTables/Iort.aslc > +++ b/Platform/RaspberryPi/AcpiTables/Iort.aslc > @@ -20,6 +20,8 @@ typedef struct { > typedef struct { > > EFI_ACPI_6_0_IO_REMAPPING_TABLE Iort; > > RPI4_NC_NODE NamedCompNode; > > + RPI4_NC_NODE NamedCompNode2; > > + RPI4_NC_NODE NamedCompNode3; > > } RPI4_IO_REMAPPING_STRUCTURE; > > > > STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = { > > @@ -27,7 +29,7 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = { > ACPI_HEADER (EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE, > > RPI4_IO_REMAPPING_STRUCTURE, > > EFI_ACPI_IO_REMAPPING_TABLE_REVISION), > > - 1, // NumNodes > > + 3, // NumNodes > > sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset > > 0 // Reserved > > }, { > > @@ -50,6 +52,46 @@ STATIC RPI4_IO_REMAPPING_STRUCTURE Iort = { > }, { > > "\\_SB_.SCB0.XHC0" // ObjectName > > } > > + }, { > > + // gpu/dwc usb named component node > > + { > > + { > > + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type > > + sizeof (RPI4_NC_NODE), // Length > > + 0x0, // Revision > > + 0x0, // Reserved > > + 0x0, // NumIdMappings > > + 0x0, // IdReference > > + }, > > + 0x0, // Flags > > + 0x0, // CacheCoherent > > + 0x0, // AllocationHints > > + 0x0, // Reserved > > + 0x0, // MemoryAccessFlags > > + 30, // AddressSizeLimit > > + }, { > > + "\\_SB_.GDV0.USB0" // ObjectName > > + } > > + }, { > > + // emmc2 named component node > > + { > > + { > > + EFI_ACPI_IORT_TYPE_NAMED_COMP, // Type > > + sizeof (RPI4_NC_NODE), // Length > > + 0x0, // Revision > > + 0x0, // Reserved > > + 0x0, // NumIdMappings > > + 0x0, // IdReference > > + }, > > + 0x0, // Flags > > + 0x0, // CacheCoherent > > + 0x0, // AllocationHints > > + 0x0, // Reserved > > + 0x0, // MemoryAccessFlags > > + 30, // AddressSizeLimit > > + }, { > > + "\\_SB_.GDV1.SDC3" // ObjectName > > + } > > } > > }; > > > Reviewed-by: Pete Batard