Re: [edk2-devel] [edk2-stable202402][Patch v4 2/7] UnitTestFrameworkPkg: MSFT CC_FLAGS add /MT to for host builds

["Michael Kubacki" <mikuback@linux.microsoft.com>]

After further explanation from Mike:

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 2/13/2024 12:26 PM, Michael D Kinney wrote:
> Add /MT to MSFT CC_FLAGS to always use release libraries
> when building host-based unit tests so any exceptions
> generated during host-based test execution generate an
> error message in stderr instead of a popup window.
> 
> Use /MTd when -D UNIT_TESTING_DEBUG is to use debug
> libraries when building host-based unit tests so any
> exceptions generated during host-based test execution
> generate a popup window with option to attach a debugger.
> 
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf | 2 +-
>   UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc        | 3 ++-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf b/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> index 0104384953c3..83ab9f9b2af8 100644
> --- a/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> +++ b/UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf
> @@ -28,6 +28,6 @@ [Packages]
>     UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec
>   
>   [BuildOptions]
> -  MSFT:*_*_*_CC_FLAGS   == /c /EHsc /Zi /Od
> +  MSFT:*_*_*_CC_FLAGS   == /c /EHsc /Zi /Od /MT
>     GCC:*_*_IA32_CC_FLAGS == -g -c -fshort-wchar -O0 -m32
>     GCC:*_*_X64_CC_FLAGS  == -g -c -fshort-wchar -O0 -m64
> diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> index b8068fd91c98..00f8d9a895be 100644
> --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
> @@ -24,9 +24,10 @@ [LibraryClasses.common.HOST_APPLICATION]
>     PeiServicesTablePointerLib|UnitTestFrameworkPkg/Library/UnitTestPeiServicesTablePointerLib/UnitTestPeiServicesTablePointerLib.inf
>   
>   [BuildOptions]
> +  MSFT:*_*_*_CC_FLAGS = /MT
>     GCC:*_*_*_CC_FLAGS = -fno-pie
>   !ifdef $(UNIT_TESTING_DEBUG)
> -  MSFT:*_*_*_CC_FLAGS  = -D UNIT_TESTING_DEBUG=1
> +  MSFT:*_*_*_CC_FLAGS  = /MTd -D UNIT_TESTING_DEBUG=1
>     GCC:*_*_*_CC_FLAGS   = -D UNIT_TESTING_DEBUG=1
>     XCODE:*_*_*_CC_FLAGS = -D UNIT_TESTING_DEBUG=1
>   !endif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115422): https://edk2.groups.io/g/devel/message/115422
Mute This Topic: https://groups.io/mt/104336759/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-