From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mx.groups.io with SMTP id smtpd.web11.9426.1679693976635478787 for ; Fri, 24 Mar 2023 14:39:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=Xe145KfS; spf=pass (domain: bsdio.com, ip: 64.147.123.25, mailfrom: rebecca@bsdio.com) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C7B10320091B; Fri, 24 Mar 2023 17:39:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 24 Mar 2023 17:39:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679693974; x=1679780374; bh=aUbN4G2Pa2v+LZdnURLzTDqdoac3iHXrMYs LwAa5Lfg=; b=Xe145KfSrwt7+E59fh3mK7KxVLKmsV6aHvF2f7Gk2mAHWJ6OvKn rEPjYkpq4aIAsv44nvrgcZKOrXt86+uuIy4GRUaPtwTP5zWfTNa7sir6p+lKwT32 P6mYyABb6Ibb4at0UymgmKy9Q82KUoJQOG/hDrqAX6WfBTZUL59GWNSaE6aZzZAY /0QXHzM8elxWKa7ZkB10H4JnQnoduig1GnxLfHVeD3w2GcaWt3eGUWbN+rOC3ilu BfSIfdSeurHpizDhn0GXjF/FRVdtajHZ+EijFxg/57bRZUMvI83bYwu3lUdHp0Dm H1WMOwYTlMuKAJJ2oQ7/JTnDhvSbT/dq14w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679693974; x=1679780374; bh=aUbN4G2Pa2v+LZdnURLzTDqdoac3iHXrMYs LwAa5Lfg=; b=G2OpEsh0Z6tNMXpLbu+InnJGZPdwzILuRMtnJ460TA3iYLl/zHL sgXaWUEJv5dhfflOstKoAT2bNmnrPWJsR4ti0WaPMqTQ4O33et7OSgfsQPP3TKsS CX3PjBRXbEcE9pOqm3Qgep60AIBcU6ffZlOitEb46qJyevDEEN/JDX7rPa9w4+hm lB8J26xxytbDd/717omHu8xo5+5lwvfR4n0wU2uhJabHWVB0dWVrzJFO6VNnuqLl kUf2SYKZdqp+FxNkrhxsX1m5DvzZBVaFoW1jgCB8lL7+j3sAYcS69z0WN8DFNVw2 uGeD0rBhlM86folN58uMejAuJ0OpDaKpnCA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedgudehvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfvefhjggtgfesthekredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepfedvkeeltefhuedvgeevfffgleelhefgueeugefffeffleegfefhhfei veetleegnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpthhirghnohgtohhrvgdroh hrghdpghhrohhuphhsrdhiohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 17:39:32 -0400 (EDT) Message-ID: <4cf97bbe-8588-c0b7-fd0e-cf382cb97d58@bsdio.com> Date: Fri, 24 Mar 2023 15:39:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCAwLzNdIEJhc2VUb29sczogYWxsb3cgdXNlcnMgdG8gb3ZlcnJpZGUgQ0MgYW5kIENYWCBvbiB0aGUgbWFrZSBjb21tYW5kIGxpbmU=?= To: gaoliming , devel@edk2.groups.io, 'Andrew Fish' , 'Leif Lindholm' , 'Michael D Kinney' , 'Bob Feng' , 'Yuwei Chen' References: <20230217035101.880854-1-rebecca@quicinc.com> <174ACADCDC6439C2.24021@groups.io> <174EE719E87C3CB3.19937@groups.io> <035101d95e0d$2320acb0$69620610$@byosoft.com.cn> Cc: Bret Barkelew , Sean Brogan , Michael Kubacki From: "Rebecca Cran" In-Reply-To: <035101d95e0d$2320acb0$69620610$@byosoft.com.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I see what's going wrong. First, PatchCheck.py isn't ignoring tabs in files named "*.makefile" or "makefile". Michael Kubacki has a patch to fix that (I also submitted a patch, but I'll let him commit his changes). Secondly, edk2basetools has a copy of Workspace/DscBuildData.py which is still setting BUILD_CFLAGS instead of CFLAGS., and it's that copy that the stuart tools use. I'm not sure how we should coordinate changes between the two repos, since it's a breaking change. -- Rebecca Cran On 3/23/23 10:57 PM, gaoliming wrote: > Rebecca: > I create PR https://github.com/tianocore/edk2/pull/4162 . But PR shows some failure. Can you help fix them? > > Thanks > Liming >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 gaoliming via >> groups.io >> 发送时间: 2023年3月23日 9:10 >> 收件人: devel@edk2.groups.io; rebecca@bsdio.com; 'Andrew Fish' >> ; 'Leif Lindholm' ; 'Michael D >> Kinney' ; 'Bob Feng' ; >> 'Yuwei Chen' >> 主题: 回复: [edk2-devel] [PATCH 0/3] BaseTools: allow users to override CC >> and CXX on the make command line >> >> Rebecca: >> This patch looks good to me. Reviewed-by: Liming Gao >> >> >> I will help to merge this patch set. >> >> Thanks >> Liming >>> -----邮件原件----- >>> 发件人: Rebecca Cran >>> 发送时间: 2023年3月15日 0:17 >>> 收件人: devel@edk2.groups.io; Andrew Fish ; Leif >>> Lindholm ; Michael D Kinney >>> ; Bob Feng ; Liming >>> Gao ; Yuwei Chen >>> 主题: Re: [edk2-devel] [PATCH 0/3] BaseTools: allow users to override CC >> and >>> CXX on the make command line >>> >>> This is a patch series that I'd really like to get committed. >>> >>> It'll allow us to drop the dependency on gcc for building edk2 on FreeBSD. >>> >>> >>> The Github branch is https://github.com/bcran/edk2/tree/mdepkg-c11 and >>> there's a PR at https://github.com/tianocore/edk2/pull/4142. >>> >>> >>> -- >>> >>> Rebecca Cran >>> >>> >>> On 3/9/23 8:47 AM, Rebecca Cran wrote: >>>> Could I get some reviews on this please? >>>> >>>> >>>> Thanks. >>>> >>>> Rebecca Cran >>>> >>>> >>>> On 2/16/23 8:50 PM, Rebecca Cran wrote: >>>>> Currently, the BaseTools Makefiles use BUILD_CC and BUILD_CXX, which >>>>> doesn't allow users to override the compiler to use in the expected way >>>>> by running e.g. "make CC=clang-17 CXX=clang++-17". clang/llvm support >>>>> was added in https://bugzilla.tianocore.org/show_bug.cgi?id=2842 in a >>>>> way that required users to run "make CXX=llvm" and have clang and >>>>> clang++ >>>>> executables under $(CLANG_BIN). As far as I know this isn't a standard >>>>> way of telling a build system to use clang, and so is likely difficult >>>>> to discover by users. >>>>> >>>>> This patch series fixes that, and as a side effect allows the clang >>>>> analyzer to run via "scan-build make". >>>>> >>>>> Since clang 17 defaults to C++17 or newer where the 'register' keyword >>>>> is deprecated and the warning turned into an error, override the >>>>> version used when building C++ code via "-std=c++14". >>>>> >>>>> Rebecca Cran (3): >>>>> BaseTools: Allow users to specify compiler to use with make CC= >>> CXX= >>>>> BaseTools: Improve detection of users wanting to build using clang >>>>> BaseTools: Build against C++14 when building with clang >>>>> >>>>> BaseTools/Source/C/DevicePath/GNUmakefile | 7 ++- >>>>> BaseTools/Source/C/LzmaCompress/GNUmakefile | 2 +- >>>>> BaseTools/Source/C/Makefiles/app.makefile | 2 +- >>>>> BaseTools/Source/C/Makefiles/footer.makefile | 6 +- >>>>> BaseTools/Source/C/Makefiles/header.makefile | 59 >>>>> ++++++++++---------- >>>>> BaseTools/Source/C/VfrCompile/GNUmakefile | 19 >>> ++++--- >>>>> BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 20 +++---- >>>>> BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 31 >> +++++----- >>>>> BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +- >>>>> 9 files changed, 76 insertions(+), 72 deletions(-) >>>>> >> >> >> >> >> > >