From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.48850.1674143743137872804 for ; Thu, 19 Jan 2023 07:55:43 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PWgMVepN; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30JCnjSk016465; Thu, 19 Jan 2023 15:55:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=b9zKMiu2qcfiXoW9Kxsocs+uWyUP/EPBD0SIY+0TlD8=; b=PWgMVepNDnEzIRUSeZG6PLQbcFKlLJ6wGO5ihYgZhav1b9w/LLpcRKolnnILzAyI2Pna iGAt3wVICpeiKW8fw4QZ1qDb+F337Vd2oyxG9aYO8V6AjJl5gTNrxdKt0kR8zPWk/F5s zI/2vHCz4/0sNhLaOHj8oTKhw1QaUDkIZwz0h7sHG4Xt0azV+GRkOvMAA8h48YZ6AMTS Bfa6w+p3d+MhyXi9uh0k+c9fLVfCNsFVEo2QWxkRNTjdX1g8IpvuQSzmoMnYpdA6rmrW lNiDZdaI0yLtsz0CH5HjdbGLdyWe5kkwPJo31raDWFzUmge+hbWeZejXLfUMMDsWBWNy Tg== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n6r59a8gh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Jan 2023 15:55:35 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30JFtZEw027621 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Jan 2023 15:55:35 GMT Received: from [10.110.4.184] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 19 Jan 2023 07:55:34 -0800 Message-ID: <4cfc2fc1-c4d2-e66e-78f3-cedaec02fee6@quicinc.com> Date: Thu, 19 Jan 2023 08:55:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions To: Isaac Oram , CC: Sai Chaganty , Nate DeSimone , Liming Gao , Rebecca Cran References: <393d7af9bcae7e604ea149c80fb8d1b2c97c29e7.1674091122.git.isaac.w.oram@intel.com> From: "Rebecca Cran" In-Reply-To: <393d7af9bcae7e604ea149c80fb8d1b2c97c29e7.1674091122.git.isaac.w.oram@intel.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: S3O75K-NcrcHs7X0LkObN_2uNnHd8CPG X-Proofpoint-GUID: S3O75K-NcrcHs7X0LkObN_2uNnHd8CPG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-19_09,2023-01-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1011 mlxscore=0 mlxlogscore=700 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301190128 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran On 1/18/23 18:20, Isaac Oram wrote: > V1: Make the Windows build example current working directory based instead of > arbitrary. > V2: Fix case mismatch in edk2 repo local name. > > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Rebecca Cran > Signed-off-by: Isaac Oram > --- > Features/Intel/AdvancedFeaturePkg/Readme.md | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/Features/Intel/AdvancedFeaturePkg/Readme.md b/Features/Intel/AdvancedFeaturePkg/Readme.md > index ba50560328..20f456bebe 100644 > --- a/Features/Intel/AdvancedFeaturePkg/Readme.md > +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md > @@ -19,19 +19,21 @@ Supported build targets > * GCC5 > > ## Windows Example: > -With current working directory at O:\ > - > git clone https://github.com/tianocore/edk2.git > > +git clone https://github.com/tianocore/edk2-non-osi.git > + > git clone https://github.com/tianocore/edk2-platforms.git > > -set workspace=O:\ > +set workspace=%cd% > > -set EDK_TOOLS_PATH=O:\Edk2\BaseTools > +set EDK_TOOLS_PATH=%workspace%\edk2\BaseTools > > -set packages_path=O:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel;O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platforms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\Features\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemInformation;O:\edk2-platforms\Features\Intel\UserInterface > +set packages_path=%workspace%\edk2;%workspace%\edk2-non-osi;%workspace%\edk2-platforms\Platform\Intel;%workspace%\edk2-platforms\Silicon\Intel;%workspace%\edk2-platforms\Platform\Qemu;%workspace%\edk2-platforms\Silicon\Qemu;%workspace%\edk2-platforms\Features\Intel;%workspace%\edk2-platforms\Features\Intel\Debugging;%workspace%\edk2-platforms\Features\Intel\Network;%workspace%\edk2-platforms\Features\Intel\OutOfBandManagement;%workspace%\edk2-platforms\Features\Intel\PowerManagement;%workspace%\edk2-platforms\Features\Intel\SystemInformation;%workspace%\edk2-platforms\Features\Intel\UserInterface > > -cd \edk2 > +cd %workspace%\edk2 > + > +git submodule update --init > > edksetup.bat Rebuild >