From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2EE41D80888 for ; Mon, 6 Nov 2023 21:14:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fRJw7jHo2Lr77vjZsyi8H11WBTsSkFQL8q/y5/wil3A=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699305254; v=1; b=cmltiAbtvn8zZUGWwOyj/Ydeq/mu/3K5yCKZFbS0urIjxXrb+bwr9voSfgGnPSPAgFqwVzy4 qzTSTeMr8P4/92yglEePdmxe1tt4Xuz4DJrB0q90bn4heMgVniiQtmELjb+z0gU2QPXSlWwmBaO ZZECumrQz2tC9FWNOsu0sVsE= X-Received: by 127.0.0.2 with SMTP id YOzjYY7687511x8DauOqPyUO; Mon, 06 Nov 2023 13:14:14 -0800 X-Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web10.67901.1699305253252144800 for ; Mon, 06 Nov 2023 13:14:13 -0800 X-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 783535C010E; Mon, 6 Nov 2023 16:14:12 -0500 (EST) X-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 06 Nov 2023 16:14:12 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddugedgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhephffhvdduvdetgffgleettefgjeeuffeghfelledvtddvteefhfefheeu udeiueeknecuffhomhgrihhnpegvgigvrdhrvghvihgvfienucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgt ohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Nov 2023 16:14:11 -0500 (EST) Message-ID: <4d09299c-8951-4b54-b903-838bd9c00461@bsdio.com> Date: Mon, 6 Nov 2023 14:14:08 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild.py: Clarify make error To: Joey Vagedes , devel@edk2.groups.io Cc: Liming Gao , Bob Feng , Yuwei Chen References: <20231106201210.10533-1-joeyvagedes@microsoft.com> <20231106201210.10533-2-joeyvagedes@microsoft.com> From: "Rebecca Cran" In-Reply-To: <20231106201210.10533-2-joeyvagedes@microsoft.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: BO5OYJPE8X6O1JrMgLUT1Tsux7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=cmltiAbt; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none Reviewed-by: Rebecca Cran --=20 Rebecca Cran On 11/6/2023 1:12 PM, Joey Vagedes wrote: > Clarify to users that they should review the build log when make > (POSIX-like system) or nmake (Windows) fails to compile basetools. > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Signed-off-by: Joey Vagedes > --- > BaseTools/Edk2ToolsBuild.py | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py > index 425bb1b63963..4776c583080f 100644 > --- a/BaseTools/Edk2ToolsBuild.py > +++ b/BaseTools/Edk2ToolsBuild.py > @@ -141,7 +141,9 @@ class Edk2ToolsBuild(BaseAbstractInvocable): > for level, problem in problems: > logging.log(level, problem) > if ret !=3D 0: > - raise Exception("Failed to build.") > + e =3D "Failed to run nmake.exe. Review Buildlog at BaseT= ools/BaseToolsBuild/BASETOOLS_BUILD.txt for nmake.exe error." > + logging.error(e) > + return ret > =20 > self.WritePathEnvFile(self.OutputDir) > return ret > @@ -156,7 +158,9 @@ class Edk2ToolsBuild(BaseAbstractInvocable): > for level, problem in problems: > logging.log(level, problem) > if ret !=3D 0: > - raise Exception("Failed to build.") > + e =3D "Failed to run make. Review Buildlog at BaseTools/= BaseToolsBuild/BASETOOLS_BUILD.txt for make error." > + logging.error(e) > + return ret > =20 > self.OutputDir =3D os.path.join( > shell_env.get_shell_var("EDK_TOOLS_PATH"), "Source", "C= ", "bin") -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110759): https://edk2.groups.io/g/devel/message/110759 Mute This Topic: https://groups.io/mt/102428862/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-