From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 07 Aug 2019 09:00:06 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6555165401; Wed, 7 Aug 2019 16:00:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E9BA60628; Wed, 7 Aug 2019 16:00:04 +0000 (UTC) Subject: Re: [PATCH 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix coding style To: Shenglei Zhang , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: <20190807020902.9972-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <4d0d707a-5ada-74e1-c99c-ca19edb38fb0@redhat.com> Date: Wed, 7 Aug 2019 18:00:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190807020902.9972-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 07 Aug 2019 16:00:05 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/07/19 04:09, Shenglei Zhang wrote: > 1. Update CPUStatus to CpuStatus in comments to align comments > with code. > 2. Add "OUT" attribute for "ProcedureArguments" parameter in function > header. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > index a0e59f20886b..7b3fbc8b55ec 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h > @@ -1311,7 +1311,7 @@ RestoreCr2 ( > Note that timeout support is optional. Whether an implementation > supports this feature can be determined via the Attributes data > member. > - @param[in,out] CPUStatus This optional pointer may be used to get the status code returned > + @param[in,out] CpuStatus This optional pointer may be used to get the status code returned > by Procedure when it completes execution on the target AP, or with > EFI_TIMEOUT if the Procedure fails to complete within the optional > timeout. The implementation will update this variable with > @@ -1437,8 +1437,8 @@ InternalSmmStartupAllAPs ( > **/ > EFI_STATUS > RegisterStartupProcedure ( > - IN EFI_AP_PROCEDURE Procedure, > - IN VOID *ProcedureArguments OPTIONAL > + IN EFI_AP_PROCEDURE Procedure, > + IN OUT VOID *ProcedureArguments OPTIONAL > ); > > /** > scrambling to wade through my email backlog after being away for a few days, so I'm skipping this thanks Laszlo