public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Marcin Wojtas <mw@semihalf.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com, jsd@semihalf.com
Subject: Re: [platforms: PATCH] Silicon/Marvell: Fix RngLib build error
Date: Sun, 4 Oct 2020 18:36:18 +0200	[thread overview]
Message-ID: <4d1d1a61-1b23-979a-312b-37aa0ab0b26f@arm.com> (raw)
In-Reply-To: <20201004142223.12272-1-mw@semihalf.com>

On 10/4/20 4:22 PM, Marcin Wojtas wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused Marvell platforms build to break for lack of an RngLib instance.
> 
> This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
> around the the EFI_RNG_PROTOCOL that the platform already produces.
> 
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as b728a4ef5038..96a98e4d3255

Thanks,

> ---
>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 42f8bbba92..ce8e120ea4 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -27,6 +27,7 @@
>     FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
>     IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
>     PlatformFlashAccessLib|Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
> +  RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
>   !endif
>   
>   !if $(NETWORK_TLS_ENABLE)
> 


      reply	other threads:[~2020-10-04 16:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04 14:22 [platforms: PATCH] Silicon/Marvell: Fix RngLib build error Marcin Wojtas
2020-10-04 16:36 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d1d1a61-1b23-979a-312b-37aa0ab0b26f@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox