From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.14219.1601829390140446589 for ; Sun, 04 Oct 2020 09:36:30 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 29709101E; Sun, 4 Oct 2020 09:36:29 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E6DF3F70D; Sun, 4 Oct 2020 09:36:27 -0700 (PDT) Subject: Re: [platforms: PATCH] Silicon/Marvell: Fix RngLib build error To: Marcin Wojtas , devel@edk2.groups.io Cc: leif@nuviainc.com, jsd@semihalf.com References: <20201004142223.12272-1-mw@semihalf.com> From: "Ard Biesheuvel" Message-ID: <4d1d1a61-1b23-979a-312b-37aa0ab0b26f@arm.com> Date: Sun, 4 Oct 2020 18:36:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201004142223.12272-1-mw@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/4/20 4:22 PM, Marcin Wojtas wrote: > Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate > entropy in rand_pool") introduced RngLib dependency for OpensslLib > and caused Marvell platforms build to break for lack of an RngLib instance. > > This patch adds RngLib using the DxeRngLib flavor, which is a wrapper > around the the EFI_RNG_PROTOCOL that the platform already produces. > > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Pushed as b728a4ef5038..96a98e4d3255 Thanks, > --- > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > index 42f8bbba92..ce8e120ea4 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -27,6 +27,7 @@ > FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf > IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf > PlatformFlashAccessLib|Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf > + RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf > !endif > > !if $(NETWORK_TLS_ENABLE) >