* [platforms: PATCH] Silicon/Marvell: Fix RngLib build error
@ 2020-10-04 14:22 Marcin Wojtas
2020-10-04 16:36 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Wojtas @ 2020-10-04 14:22 UTC (permalink / raw)
To: devel; +Cc: leif, ard.biesheuvel, mw, jsd
Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
entropy in rand_pool") introduced RngLib dependency for OpensslLib
and caused Marvell platforms build to break for lack of an RngLib instance.
This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
around the the EFI_RNG_PROTOCOL that the platform already produces.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index 42f8bbba92..ce8e120ea4 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -27,6 +27,7 @@
FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
PlatformFlashAccessLib|Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
+ RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
!endif
!if $(NETWORK_TLS_ENABLE)
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [platforms: PATCH] Silicon/Marvell: Fix RngLib build error
2020-10-04 14:22 [platforms: PATCH] Silicon/Marvell: Fix RngLib build error Marcin Wojtas
@ 2020-10-04 16:36 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-10-04 16:36 UTC (permalink / raw)
To: Marcin Wojtas, devel; +Cc: leif, jsd
On 10/4/20 4:22 PM, Marcin Wojtas wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused Marvell platforms build to break for lack of an RngLib instance.
>
> This patch adds RngLib using the DxeRngLib flavor, which is a wrapper
> around the the EFI_RNG_PROTOCOL that the platform already produces.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Pushed as b728a4ef5038..96a98e4d3255
Thanks,
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 42f8bbba92..ce8e120ea4 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -27,6 +27,7 @@
> FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
> IniParsingLib|SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.inf
> PlatformFlashAccessLib|Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
> + RngLib|MdePkg/Library/DxeRngLib/DxeRngLib.inf
> !endif
>
> !if $(NETWORK_TLS_ENABLE)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-04 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-04 14:22 [platforms: PATCH] Silicon/Marvell: Fix RngLib build error Marcin Wojtas
2020-10-04 16:36 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox