Re: [PATCH] UefiCpuPkg/CpuDxe: Replace EFI_D_xxx with DEBUG_xxx in DEBUG()

[Laszlo Ersek <lersek@redhat.com>]

On 02/22/17 08:55, Jeff Fan wrote:
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff.fan@intel.com>
> ---
>  UefiCpuPkg/CpuDxe/CpuDxe.c | 8 ++++----
>  UefiCpuPkg/CpuDxe/CpuMp.c  | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

> 
> diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c
> index 1a5a725..2fd2f31 100644
> --- a/UefiCpuPkg/CpuDxe/CpuDxe.c
> +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c
> @@ -403,7 +403,7 @@ CpuSetMemoryAttributes (
>    // to avoid unnecessary computing.
>    //
>    if (mIsFlushingGCD) {
> -    DEBUG((EFI_D_INFO, "  Flushing GCD\n"));
> +    DEBUG((DEBUG_INFO, "  Flushing GCD\n"));
>      return EFI_SUCCESS;
>    }
>  
> @@ -979,13 +979,13 @@ IntersectMemoryDescriptor (
>                      IntersectionBase, IntersectionEnd - IntersectionBase,
>                      Capabilities);
>  
> -    DEBUG ((EFI_ERROR (Status) ? EFI_D_ERROR : EFI_D_VERBOSE,
> +    DEBUG ((EFI_ERROR (Status) ? DEBUG_ERROR : DEBUG_VERBOSE,
>        "%a: %a: add [%Lx, %Lx): %r\n", gEfiCallerBaseName, __FUNCTION__,
>        IntersectionBase, IntersectionEnd, Status));
>      return Status;
>    }
>  
> -  DEBUG ((EFI_D_ERROR, "%a: %a: desc [%Lx, %Lx) type %u cap %Lx conflicts "
> +  DEBUG ((DEBUG_ERROR, "%a: %a: desc [%Lx, %Lx) type %u cap %Lx conflicts "
>      "with aperture [%Lx, %Lx) cap %Lx\n", gEfiCallerBaseName, __FUNCTION__,
>      Descriptor->BaseAddress, Descriptor->BaseAddress + Descriptor->Length,
>      (UINT32)Descriptor->GcdMemoryType, Descriptor->Capabilities,
> @@ -1018,7 +1018,7 @@ AddMemoryMappedIoSpace (
>  
>    Status = gDS->GetMemorySpaceMap (&NumberOfDescriptors, &MemorySpaceMap);
>    if (EFI_ERROR (Status)) {
> -    DEBUG ((EFI_D_ERROR, "%a: %a: GetMemorySpaceMap(): %r\n",
> +    DEBUG ((DEBUG_ERROR, "%a: %a: GetMemorySpaceMap(): %r\n",
>        gEfiCallerBaseName, __FUNCTION__, Status));
>      return Status;
>    }
> diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
> index 9659bd2..4456946 100644
> --- a/UefiCpuPkg/CpuDxe/CpuMp.c
> +++ b/UefiCpuPkg/CpuDxe/CpuMp.c
> @@ -1,7 +1,7 @@
>  /** @file
>    CPU DXE Module to produce CPU MP Protocol.
>  
> -  Copyright (c) 2008 - 2016, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD License
>    which accompanies this distribution.  The full text of the license may be found at
> @@ -571,7 +571,7 @@ CollectBistDataFromHob (
>        BspCpuInstance.InfoRecord.IA32HealthFlags.Uint32  = SecPlatformInformation->IA32HealthFlags.Uint32;
>        CpuInstance = &BspCpuInstance;
>      } else {
> -      DEBUG ((EFI_D_INFO, "Does not find any HOB stored CPU BIST information!\n"));
> +      DEBUG ((DEBUG_INFO, "Does not find any HOB stored CPU BIST information!\n"));
>        //
>        // Does not find any HOB stored BIST information
>        //
> @@ -622,7 +622,7 @@ InitializeMpSupport (
>  
>    MpInitLibGetNumberOfProcessors (&NumberOfProcessors, &NumberOfEnabledProcessors);
>    mNumberOfProcessors = NumberOfProcessors;
> -  DEBUG ((EFI_D_ERROR, "Detect CPU count: %d\n", mNumberOfProcessors));
> +  DEBUG ((DEBUG_ERROR, "Detect CPU count: %d\n", mNumberOfProcessors));
>  
>    //
>    // Update CPU healthy information from Guided HOB
>