From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 498F282175 for ; Thu, 23 Feb 2017 01:29:06 -0800 (PST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9296C0092DE; Thu, 23 Feb 2017 09:29:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-58.phx2.redhat.com [10.3.116.58]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1N9T4Fo011338; Thu, 23 Feb 2017 04:29:05 -0500 To: Jeff Fan , edk2-devel@ml01.01.org References: <20170222075559.29704-1-jeff.fan@intel.com> Cc: Feng Tian , Michael D Kinney From: Laszlo Ersek Message-ID: <4d1ee4ae-b82d-96b6-3330-22c821dfc343@redhat.com> Date: Thu, 23 Feb 2017 10:29:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170222075559.29704-1-jeff.fan@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 23 Feb 2017 09:29:06 +0000 (UTC) Subject: Re: [PATCH] UefiCpuPkg/CpuDxe: Replace EFI_D_xxx with DEBUG_xxx in DEBUG() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 09:29:06 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/22/17 08:55, Jeff Fan wrote: > Cc: Laszlo Ersek > Cc: Feng Tian > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan > --- > UefiCpuPkg/CpuDxe/CpuDxe.c | 8 ++++---- > UefiCpuPkg/CpuDxe/CpuMp.c | 6 +++--- > 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Laszlo Ersek Thanks Laszlo > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c > index 1a5a725..2fd2f31 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.c > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c > @@ -403,7 +403,7 @@ CpuSetMemoryAttributes ( > // to avoid unnecessary computing. > // > if (mIsFlushingGCD) { > - DEBUG((EFI_D_INFO, " Flushing GCD\n")); > + DEBUG((DEBUG_INFO, " Flushing GCD\n")); > return EFI_SUCCESS; > } > > @@ -979,13 +979,13 @@ IntersectMemoryDescriptor ( > IntersectionBase, IntersectionEnd - IntersectionBase, > Capabilities); > > - DEBUG ((EFI_ERROR (Status) ? EFI_D_ERROR : EFI_D_VERBOSE, > + DEBUG ((EFI_ERROR (Status) ? DEBUG_ERROR : DEBUG_VERBOSE, > "%a: %a: add [%Lx, %Lx): %r\n", gEfiCallerBaseName, __FUNCTION__, > IntersectionBase, IntersectionEnd, Status)); > return Status; > } > > - DEBUG ((EFI_D_ERROR, "%a: %a: desc [%Lx, %Lx) type %u cap %Lx conflicts " > + DEBUG ((DEBUG_ERROR, "%a: %a: desc [%Lx, %Lx) type %u cap %Lx conflicts " > "with aperture [%Lx, %Lx) cap %Lx\n", gEfiCallerBaseName, __FUNCTION__, > Descriptor->BaseAddress, Descriptor->BaseAddress + Descriptor->Length, > (UINT32)Descriptor->GcdMemoryType, Descriptor->Capabilities, > @@ -1018,7 +1018,7 @@ AddMemoryMappedIoSpace ( > > Status = gDS->GetMemorySpaceMap (&NumberOfDescriptors, &MemorySpaceMap); > if (EFI_ERROR (Status)) { > - DEBUG ((EFI_D_ERROR, "%a: %a: GetMemorySpaceMap(): %r\n", > + DEBUG ((DEBUG_ERROR, "%a: %a: GetMemorySpaceMap(): %r\n", > gEfiCallerBaseName, __FUNCTION__, Status)); > return Status; > } > diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c > index 9659bd2..4456946 100644 > --- a/UefiCpuPkg/CpuDxe/CpuMp.c > +++ b/UefiCpuPkg/CpuDxe/CpuMp.c > @@ -1,7 +1,7 @@ > /** @file > CPU DXE Module to produce CPU MP Protocol. > > - Copyright (c) 2008 - 2016, Intel Corporation. All rights reserved.
> + Copyright (c) 2008 - 2017, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > which accompanies this distribution. The full text of the license may be found at > @@ -571,7 +571,7 @@ CollectBistDataFromHob ( > BspCpuInstance.InfoRecord.IA32HealthFlags.Uint32 = SecPlatformInformation->IA32HealthFlags.Uint32; > CpuInstance = &BspCpuInstance; > } else { > - DEBUG ((EFI_D_INFO, "Does not find any HOB stored CPU BIST information!\n")); > + DEBUG ((DEBUG_INFO, "Does not find any HOB stored CPU BIST information!\n")); > // > // Does not find any HOB stored BIST information > // > @@ -622,7 +622,7 @@ InitializeMpSupport ( > > MpInitLibGetNumberOfProcessors (&NumberOfProcessors, &NumberOfEnabledProcessors); > mNumberOfProcessors = NumberOfProcessors; > - DEBUG ((EFI_D_ERROR, "Detect CPU count: %d\n", mNumberOfProcessors)); > + DEBUG ((DEBUG_ERROR, "Detect CPU count: %d\n", mNumberOfProcessors)); > > // > // Update CPU healthy information from Guided HOB >