* Shell Non-conformity to the Spec
@ 2017-10-24 18:20 Jim.Dailey
2017-10-24 18:28 ` Carsey, Jaben
0 siblings, 1 reply; 5+ messages in thread
From: Jim.Dailey @ 2017-10-24 18:20 UTC (permalink / raw)
To: jaben.carsey, ruiyu.ni; +Cc: edk2-devel
The shell spec says that "Each environment variable has a case-sensitive
name ...".
In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
compare is performed against the variable that is to be set to see if it
is one of the read-only variables. That means one cannot set a variable
named, for example, CWD, even though "cwd" and "CWD" are two different
variable names according to the spec.
Should this be changed to a case-sensitive comparison?
Regards,
Jim
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Shell Non-conformity to the Spec
2017-10-24 18:20 Shell Non-conformity to the Spec Jim.Dailey
@ 2017-10-24 18:28 ` Carsey, Jaben
2017-10-24 19:14 ` Tim Lewis
0 siblings, 1 reply; 5+ messages in thread
From: Carsey, Jaben @ 2017-10-24 18:28 UTC (permalink / raw)
To: Jim.Dailey@dell.com, Ni, Ruiyu; +Cc: edk2-devel@lists.01.org
Yes.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jim.Dailey@dell.com
> Sent: Tuesday, October 24, 2017 11:20 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] Shell Non-conformity to the Spec
> Importance: High
>
> The shell spec says that "Each environment variable has a case-sensitive
> name ...".
>
> In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> compare is performed against the variable that is to be set to see if it
> is one of the read-only variables. That means one cannot set a variable
> named, for example, CWD, even though "cwd" and "CWD" are two different
> variable names according to the spec.
>
> Should this be changed to a case-sensitive comparison?
>
> Regards,
> Jim
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Shell Non-conformity to the Spec
2017-10-24 18:28 ` Carsey, Jaben
@ 2017-10-24 19:14 ` Tim Lewis
2017-10-24 20:11 ` Carsey, Jaben
0 siblings, 1 reply; 5+ messages in thread
From: Tim Lewis @ 2017-10-24 19:14 UTC (permalink / raw)
To: 'Carsey, Jaben', Jim.Dailey, 'Ni, Ruiyu'; +Cc: edk2-devel
Jaben --
Wasn't there are previous e-mail thread about this?
Tim
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
Carsey, Jaben
Sent: Tuesday, October 24, 2017 11:29 AM
To: Jim.Dailey@dell.com; Ni, Ruiyu <ruiyu.ni@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] Shell Non-conformity to the Spec
Yes.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jim.Dailey@dell.com
> Sent: Tuesday, October 24, 2017 11:20 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] Shell Non-conformity to the Spec
> Importance: High
>
> The shell spec says that "Each environment variable has a
> case-sensitive name ...".
>
> In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> compare is performed against the variable that is to be set to see if
> it is one of the read-only variables. That means one cannot set a
> variable named, for example, CWD, even though "cwd" and "CWD" are two
> different variable names according to the spec.
>
> Should this be changed to a case-sensitive comparison?
>
> Regards,
> Jim
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Shell Non-conformity to the Spec
2017-10-24 19:14 ` Tim Lewis
@ 2017-10-24 20:11 ` Carsey, Jaben
2017-10-24 20:13 ` Tim Lewis
0 siblings, 1 reply; 5+ messages in thread
From: Carsey, Jaben @ 2017-10-24 20:11 UTC (permalink / raw)
To: Tim Lewis, Jim.Dailey@dell.com, Ni, Ruiyu; +Cc: edk2-devel@lists.01.org
I don't remember. Is there a defect in the Bugzilla?
> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Tuesday, October 24, 2017 12:14 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Jim.Dailey@dell.com; Ni, Ruiyu
> <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [edk2] Shell Non-conformity to the Spec
> Importance: High
>
> Jaben --
>
> Wasn't there are previous e-mail thread about this?
>
> Tim
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Tuesday, October 24, 2017 11:29 AM
> To: Jim.Dailey@dell.com; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] Shell Non-conformity to the Spec
>
> Yes.
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Jim.Dailey@dell.com
> > Sent: Tuesday, October 24, 2017 11:20 AM
> > To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> > <ruiyu.ni@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: [edk2] Shell Non-conformity to the Spec
> > Importance: High
> >
> > The shell spec says that "Each environment variable has a
> > case-sensitive name ...".
> >
> > In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> > compare is performed against the variable that is to be set to see if
> > it is one of the read-only variables. That means one cannot set a
> > variable named, for example, CWD, even though "cwd" and "CWD" are two
> > different variable names according to the spec.
> >
> > Should this be changed to a case-sensitive comparison?
> >
> > Regards,
> > Jim
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Shell Non-conformity to the Spec
2017-10-24 20:11 ` Carsey, Jaben
@ 2017-10-24 20:13 ` Tim Lewis
0 siblings, 0 replies; 5+ messages in thread
From: Tim Lewis @ 2017-10-24 20:13 UTC (permalink / raw)
To: Carsey, Jaben, Jim.Dailey@dell.com, Ni, Ruiyu; +Cc: edk2-devel@lists.01.org
Ah, now I remember. It was about aliases and case sensitivity, not environment variables. Tim
Sent from my Windows 10 phone
From: Carsey, Jaben
Sent: Tuesday, October 24, 2017 1:11 PM
To: Tim Lewis; Jim.Dailey@dell.com; Ni, Ruiyu
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] Shell Non-conformity to the Spec
I don't remember. Is there a defect in the Bugzilla?
> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Tuesday, October 24, 2017 12:14 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Jim.Dailey@dell.com; Ni, Ruiyu
> <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [edk2] Shell Non-conformity to the Spec
> Importance: High
>
> Jaben --
>
> Wasn't there are previous e-mail thread about this?
>
> Tim
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Tuesday, October 24, 2017 11:29 AM
> To: Jim.Dailey@dell.com; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] Shell Non-conformity to the Spec
>
> Yes.
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Jim.Dailey@dell.com
> > Sent: Tuesday, October 24, 2017 11:20 AM
> > To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> > <ruiyu.ni@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: [edk2] Shell Non-conformity to the Spec
> > Importance: High
> >
> > The shell spec says that "Each environment variable has a
> > case-sensitive name ...".
> >
> > In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> > compare is performed against the variable that is to be set to see if
> > it is one of the read-only variables. That means one cannot set a
> > variable named, for example, CWD, even though "cwd" and "CWD" are two
> > different variable names according to the spec.
> >
> > Should this be changed to a case-sensitive comparison?
> >
> > Regards,
> > Jim
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-24 20:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-24 18:20 Shell Non-conformity to the Spec Jim.Dailey
2017-10-24 18:28 ` Carsey, Jaben
2017-10-24 19:14 ` Tim Lewis
2017-10-24 20:11 ` Carsey, Jaben
2017-10-24 20:13 ` Tim Lewis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox