Shell Non-conformity to the Spec

Shell Non-conformity to the Spec

[Jim.Dailey]

The shell spec says that "Each environment variable has a case-sensitive
name ...".

In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
compare is performed against the variable that is to be set to see if it
is one of the read-only variables.  That means one cannot set a variable
named, for example, CWD, even though "cwd" and "CWD" are two different
variable names according to the spec.

Should this be changed to a case-sensitive comparison?

Regards,
Jim

Re: Shell Non-conformity to the Spec

[Carsey, Jaben]

Yes.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jim.Dailey@dell.com
> Sent: Tuesday, October 24, 2017 11:20 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] Shell Non-conformity to the Spec
> Importance: High
> 
> The shell spec says that "Each environment variable has a case-sensitive
> name ...".
> 
> In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> compare is performed against the variable that is to be set to see if it
> is one of the read-only variables.  That means one cannot set a variable
> named, for example, CWD, even though "cwd" and "CWD" are two different
> variable names according to the spec.
> 
> Should this be changed to a case-sensitive comparison?
> 
> Regards,
> Jim
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell Non-conformity to the Spec

[Tim Lewis]

Jaben --

Wasn't there are previous e-mail thread about this?

Tim

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
Carsey, Jaben
Sent: Tuesday, October 24, 2017 11:29 AM
To: Jim.Dailey@dell.com; Ni, Ruiyu <ruiyu.ni@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] Shell Non-conformity to the Spec

Yes.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Jim.Dailey@dell.com
> Sent: Tuesday, October 24, 2017 11:20 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu 
> <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] Shell Non-conformity to the Spec
> Importance: High
> 
> The shell spec says that "Each environment variable has a 
> case-sensitive name ...".
> 
> In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive 
> compare is performed against the variable that is to be set to see if 
> it is one of the read-only variables.  That means one cannot set a 
> variable named, for example, CWD, even though "cwd" and "CWD" are two 
> different variable names according to the spec.
> 
> Should this be changed to a case-sensitive comparison?
> 
> Regards,
> Jim
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell Non-conformity to the Spec

[Carsey, Jaben]

I don't remember.  Is there a defect in the Bugzilla?

> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Tuesday, October 24, 2017 12:14 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Jim.Dailey@dell.com; Ni, Ruiyu
> <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [edk2] Shell Non-conformity to the Spec
> Importance: High
> 
> Jaben --
> 
> Wasn't there are previous e-mail thread about this?
> 
> Tim
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Tuesday, October 24, 2017 11:29 AM
> To: Jim.Dailey@dell.com; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] Shell Non-conformity to the Spec
> 
> Yes.
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Jim.Dailey@dell.com
> > Sent: Tuesday, October 24, 2017 11:20 AM
> > To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> > <ruiyu.ni@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: [edk2] Shell Non-conformity to the Spec
> > Importance: High
> >
> > The shell spec says that "Each environment variable has a
> > case-sensitive name ...".
> >
> > In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> > compare is performed against the variable that is to be set to see if
> > it is one of the read-only variables.  That means one cannot set a
> > variable named, for example, CWD, even though "cwd" and "CWD" are two
> > different variable names according to the spec.
> >
> > Should this be changed to a case-sensitive comparison?
> >
> > Regards,
> > Jim
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: Shell Non-conformity to the Spec

[Tim Lewis]

Ah, now I remember. It was about aliases and case sensitivity, not environment variables. Tim

Sent from my Windows 10 phone

From: Carsey, Jaben
Sent: Tuesday, October 24, 2017 1:11 PM
To: Tim Lewis; Jim.Dailey@dell.com; Ni, Ruiyu
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] Shell Non-conformity to the Spec

I don't remember.  Is there a defect in the Bugzilla?

> -----Original Message-----
> From: Tim Lewis [mailto:tim.lewis@insyde.com]
> Sent: Tuesday, October 24, 2017 12:14 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Jim.Dailey@dell.com; Ni, Ruiyu
> <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: RE: [edk2] Shell Non-conformity to the Spec
> Importance: High
> 
> Jaben --
> 
> Wasn't there are previous e-mail thread about this?
> 
> Tim
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Tuesday, October 24, 2017 11:29 AM
> To: Jim.Dailey@dell.com; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] Shell Non-conformity to the Spec
> 
> Yes.
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Jim.Dailey@dell.com
> > Sent: Tuesday, October 24, 2017 11:20 AM
> > To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> > <ruiyu.ni@intel.com>
> > Cc: edk2-devel@lists.01.org
> > Subject: [edk2] Shell Non-conformity to the Spec
> > Importance: High
> >
> > The shell spec says that "Each environment variable has a
> > case-sensitive name ...".
> >
> > In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> > compare is performed against the variable that is to be set to see if
> > it is one of the read-only variables.  That means one cannot set a
> > variable named, for example, CWD, even though "cwd" and "CWD" are two
> > different variable names according to the spec.
> >
> > Should this be changed to a case-sensitive comparison?
> >
> > Regards,
> > Jim
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel