public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>, devel@edk2.groups.io
Cc: Jared McNeill <jmcneill@invisible.ca>,
	Andrei Warkentin <awarkentin@vmware.com>,
	Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Jeremy Linton <lintonrjeremy@gmail.com>
Subject: Re: [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot
Date: Thu, 4 Jun 2020 13:27:22 +0100	[thread overview]
Message-ID: <4d28d975-c978-805f-f5ab-5a12f626209a@akeo.ie> (raw)
In-Reply-To: <20200604095007.45693-4-ard.biesheuvel@arm.com>

On 2020.06.04 10:50, Ard Biesheuvel wrote:
> The BDS will connect device paths that are considered as boot options,
> so there is really no reason to always connect absolutely everything.
> So now that all the drivers have been updated to play nice in this
> case, remove the ConnectAll() call from the RPi BDS code.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>   Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> index 2bd625ad7e7c..253614a646c1 100644
> --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -655,11 +655,6 @@ PlatformBootManagerAfterConsole (
>       Print (BOOT_PROMPT);
> 
>     }
> 
>   
> 
> -  //
> 
> -  // Connect the rest of the devices.
> 
> -  //
> 
> -  EfiBootManagerConnectAll ();
> 
> -
> 
>     Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, (VOID**)&EsrtManagement);
> 
>     if (!EFI_ERROR (Status)) {
> 
>       EsrtManagement->SyncEsrtFmp ();
> 

Reviewed-by: Pete Batard <pete@akeo.ie>
For the series (after application of the planned edk2 commits to confirm 
that UEFI Shell is now added as an option in Boot Manager):
Tested-by: Pete Batard <pete@akeo.ie>

  reply	other threads:[~2020-06-04 12:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  9:50 [PATCH edk2-platforms 0/3] Platform/RaspberryPi: omit ConnectAll() on regular boot Ard Biesheuvel
2020-06-04  9:50 ` [PATCH edk2-platforms 1/3] Silicon/Broadcom/BcmGenetDxe: program MAC also when not connected Ard Biesheuvel
2020-06-04 12:27   ` Pete Batard
2020-06-04 14:53   ` Leif Lindholm
2020-06-04 14:57     ` Ard Biesheuvel
2020-06-04 15:00       ` Leif Lindholm
2020-06-04  9:50 ` [PATCH edk2-platforms 2/3] Platform/RaspberryPi: add UEFI Shell to boot manager menu Ard Biesheuvel
2020-06-04 12:27   ` Pete Batard
2020-06-04  9:50 ` [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot Ard Biesheuvel
2020-06-04 12:27   ` Pete Batard [this message]
2020-06-05  8:10     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d28d975-c978-805f-f5ab-5a12f626209a@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox