From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.12640.1591273645204968287 for ; Thu, 04 Jun 2020 05:27:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=WXIOiJyH; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.66, mailfrom: pete@akeo.ie) Received: by mail-wr1-f66.google.com with SMTP id x14so5897911wrp.2 for ; Thu, 04 Jun 2020 05:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4XzF+ajjLGjJJL9PAB3BpitsDX+7R5X8W1+JAZfO/vM=; b=WXIOiJyHd/INLIfZjIiHtY9ovDCyczv/iT3HfW+r81w3+iW5Ag5/4rVldZ+P6LinTE ZgAkR9XfFXFpq2kWtAIhgdc5EDOpBJY9WSzchbSx77qsIqo+HWnEYYCWfpK2bkSb51XO ak1w3V0wzzzrhrBTNYJpFUQYs+hbrTkY5wVShFOLDgCh4iYLbzQN09W+hKuq3SsX6I0i +/WmQY5dJfDfefHNhS3xK5p9P52ebfopOky2hRp1bCFlqIleMScY9bWUd5LFA9/5kHOS 29Rpn8yt+pXqXlTsB1MKQIlUVgLFhPQln0Ok88N4/R8imQmI664++u2yFwFcwMBs9eck zHyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4XzF+ajjLGjJJL9PAB3BpitsDX+7R5X8W1+JAZfO/vM=; b=FKavRM3NBEsrlcYTGdDQ3hjJVlm8pvwN9FJUo0eIBJJLk30YB+ReI9Mh6GgVb9Oew0 HIxjXVOoM47mwtPcXDcHcu/aUDUnmB74qOa/qxJ/gTMUD/3ycO4jg96AA3Q87ypxhcV3 4ZBOIjtlLvEArv6wlVAKdYrNlP69vNYRaLWJzWiLjQrw2IPJYnqwFiMnQ9Y1l1m+QhcL /RiaEuWOEzBwcaN2Xks8YHxtVWYFJ/xSiF0sZxvz6t3DUQ/wdKoFyddCasBH5U8HKIzv qpkybvekeliHUdBeK34SE02be+X6QFm3ZHdSEJ4wYNuS9DURCoQyGIxvO637lwWimn2V UDOw== X-Gm-Message-State: AOAM533ks+fes8Z/fAlVxhVNNaR2JJCDokrgwH3RT3qKjJNCD5eXEGz5 tWOqCYcnBfV6ujU9LVc2+2RFAQ== X-Google-Smtp-Source: ABdhPJzVoJCr5KgswnZ1VIkB4mxgHYgdWBYY8DifP+esQmxpkUXQmQV8laoyQya01NQU44BlE8lRWA== X-Received: by 2002:adf:9481:: with SMTP id 1mr4203583wrr.396.1591273643800; Thu, 04 Jun 2020 05:27:23 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.48.247]) by smtp.googlemail.com with ESMTPSA id p16sm8386843wru.27.2020.06.04.05.27.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 05:27:23 -0700 (PDT) Subject: Re: [PATCH edk2-platforms 3/3] Platform/RaspberryPi: don't connect all devices on an ordinary boot To: Ard Biesheuvel , devel@edk2.groups.io Cc: Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud , Leif Lindholm , Jeremy Linton References: <20200604095007.45693-1-ard.biesheuvel@arm.com> <20200604095007.45693-4-ard.biesheuvel@arm.com> From: "Pete Batard" Message-ID: <4d28d975-c978-805f-f5ab-5a12f626209a@akeo.ie> Date: Thu, 4 Jun 2020 13:27:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200604095007.45693-4-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2020.06.04 10:50, Ard Biesheuvel wrote: > The BDS will connect device paths that are considered as boot options, > so there is really no reason to always connect absolutely everything. > So now that all the drivers have been updated to play nice in this > case, remove the ConnectAll() call from the RPi BDS code. > > Signed-off-by: Ard Biesheuvel > --- > Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > index 2bd625ad7e7c..253614a646c1 100644 > --- a/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/Platform/RaspberryPi/Library/PlatformBootManagerLib/PlatformBm.c > @@ -655,11 +655,6 @@ PlatformBootManagerAfterConsole ( > Print (BOOT_PROMPT); > > } > > > > - // > > - // Connect the rest of the devices. > > - // > > - EfiBootManagerConnectAll (); > > - > > Status = gBS->LocateProtocol (&gEsrtManagementProtocolGuid, NULL, (VOID**)&EsrtManagement); > > if (!EFI_ERROR (Status)) { > > EsrtManagement->SyncEsrtFmp (); > Reviewed-by: Pete Batard For the series (after application of the planned edk2 commits to confirm that UEFI Shell is now added as an option in Boot Manager): Tested-by: Pete Batard