From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B1F6020958BF8 for ; Sat, 16 Sep 2017 15:13:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E078780B22; Sat, 16 Sep 2017 22:17:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E078780B22 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-8.rdu2.redhat.com [10.10.120.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9015F60BE6; Sat, 16 Sep 2017 22:16:57 +0000 (UTC) To: Paulo Alcantara References: From: Laszlo Ersek Cc: edk2-devel@lists.01.org, Eric Dong , Liming Gao , Michael D Kinney , Ruiyu Ni , Star Zeng Message-ID: <4d74e669-964e-7910-2de6-b7e831f9c2eb@redhat.com> Date: Sun, 17 Sep 2017 00:16:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sat, 16 Sep 2017 22:17:01 +0000 (UTC) Subject: Re: [PATCH 0/3] UDF partition driver fix X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Sep 2017 22:13:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Paulo, On 09/16/17 23:36, Paulo Alcantara wrote: > This series fixes an UDF issue with Partition driver as discussed in ML: > > https://lists.01.org/pipermail/edk2-devel/2017-September/014694.html > > Thanks! > Paulo > > Repo: https://github.com/pcacjr/edk2.git > Branch: udf-partition-fix > > Paulo Alcantara (3): > MdePkg: Add UDF volume structure definitions > MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition > MdeModulePkg/UdfDxe: Rework driver to support PartitionDxe changes > > MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 307 +++++++++++- > MdeModulePkg/Universal/Disk/UdfDxe/File.c | 13 +- > .../Universal/Disk/UdfDxe/FileSystemOperations.c | 525 ++++++++------------- > MdeModulePkg/Universal/Disk/UdfDxe/Udf.c | 7 - > MdeModulePkg/Universal/Disk/UdfDxe/Udf.h | 88 +--- > MdePkg/Include/IndustryStandard/Udf.h | 63 +++ > 6 files changed, 560 insertions(+), 443 deletions(-) > Thank you very much for submitting this patchset quickly. I hope it will work out, and we won't need the PartitionExperimentalDxe.inf file! I have some trivial process-level suggestions: * when submitting a patchset, please collect the Cc: tags from all the commit messages, and add them to the cover letter manually. This way everybody you CC on at least some of the patches will get the cover letter too, presonally. This matters because otherwise replies to the blurb will also miss those people, personally. (I'm now adding everyone manually.) * Because edk2 uses long directory and file names, the diffstats are frequently truncated like above (see "..."). You can avoid this if you format the patches like this: --stat=1000 --stat-graph-width=20 this will make the pathname column just as wide as necessary, and will also keep the chart to the right reasonably narrow. * It's probably best to include a reference to in the commit messages (in particular patch #2). * Once you post a patchset for a TianoCore BZ, it's useful to link the series (from the mailing list archive) in the BZ itself. Regarding the code itself, I don't think I can help here in any sensible way. (If UDF support were located under OvmfPkg, I would totally consider you the owner of those files, verify your patches for them on a formal level only, and if that part was fine, I'd give an Acked-by.) Thanks! Laszlo