From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1B646D811C3 for ; Fri, 8 Mar 2024 09:34:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0lHeX1RPQWrr37jB5M+z03p/eei8CklgL7yilz0+M2g=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709890469; v=1; b=dVw/eia8EaaKg2R2MfiR+epet7/odM09GK7mVJxCRtgD54Nttad8JBNueQaYuOB51/x5kSF2 THEUGANeV47304Geq7tLExX8HdfwbOM0XlX3SWm0c8mRSv2OiZ5SbUmVGrw9xitqHTV/3XLFKuc FZE85amwdxQwSLHjZ1Iw/xkwIOJeS4kGyHbfp4D5IJ2AUFJHWcHzuUxl7s9h9QrFqip+zYucfoo 3Gau/l/V5fTe6XQGVMgA8J72WIcs7xI7hp1Zk8QXRW8sCa/X4dFQKCbsaqTln6NaoZzMVJ88l1V EzWoJDERYM7Hu+PYtPxxEZamk/LfK47clvk3af7SWKqeQ== X-Received: by 127.0.0.2 with SMTP id zYJYYY7687511xsbdephztn6; Fri, 08 Mar 2024 01:34:29 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.18066.1709890469028459950 for ; Fri, 08 Mar 2024 01:34:29 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-64swybzpMHGSTNJPWWOh4Q-1; Fri, 08 Mar 2024 04:34:25 -0500 X-MC-Unique: 64swybzpMHGSTNJPWWOh4Q-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7D69A185A786; Fri, 8 Mar 2024 09:34:23 +0000 (UTC) X-Received: from [10.39.192.88] (unknown [10.39.192.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CE676C478A0; Fri, 8 Mar 2024 09:34:17 +0000 (UTC) Message-ID: <4d9233ee-1b8e-da54-6035-c6ef12aff01e@redhat.com> Date: Fri, 08 Mar 2024 01:34:29 -0800 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 00/10] clean up ProcessLibraryConstructorList() declarations in SEC modules From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Andrei Warkentin , Andrew Fish , Ard Biesheuvel , Ashraf Ali S , Bob Feng , Catharine West , Chasel Chiu , Duggapu Chinni B , Erdem Aktas , Gerd Hoffmann , Gua Guo , Guo Dong , James Lu , Jiewen Yao , Joey Vagedes , Leif Lindholm , Liming Gao , Michael D Kinney , Michael Roth , Min Xu , Nate DeSimone , Rahul Kumar , Ray Ni , Rebecca Cran , Sami Mujawar , Sean Brogan , Sean Rhodes , Star Zeng , Sunil V L , Susovan Mohapatra , Ted Kuo , Tom Lendacky , Yuwei Chen Reply-To: devel@edk2.groups.io,lersek@redhat.com References: <20240305113843.68812-1-lersek@redhat.com> In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: a3UJUfqUIlfKDf8qZ1jUED7bx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="dVw/eia8"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 3/8/24 10:13, Laszlo Ersek wrote: > On 3/5/24 12:38, Laszlo Ersek wrote: >> Bugzillas: >> - https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=3D991 >> - https://bugzilla.tianocore.org/show_bug.cgi?id=3D4643 >> >> CI: >> - https://github.com/tianocore/edk2/pull/5442 >> >> Branch: >> - https://github.com/lersek/edk2/tree/ProcessLibraryConstructorList-SEC-= 990-991-v2 >> >> This patch series puts the recent BaseTools feature to use in which >> AutoGen generates the ProcessLibraryConstructorList() declaration in >> "AutoGen.h" for such non-library SEC modules whose INF_VERSION is at >> least 1.30. The BaseTools feature is present in both edk2 [1] and >> edk2-basetools [2], and has been documented in the Build spec [3] and >> the Inf spec [4]. Kudos to Rebecca for tagging a new edk2-basetools >> release [5] [6] with the new feature. >> >> [1] edk2 commit bac9c74080cf >> [2] edk2-basetools commit 5b7161de22ee >> [3] edk2-BuildSpecification commit range db69f5661cae..7a7165a7d199 >> [4] edk2-InfSpecification commit range a31e3c842bee..1ea6546578fe >> [5] https://github.com/tianocore/edk2-basetools/releases/tag/v0.1.51 >> [6] https://pypi.org/project/edk2-basetools/0.1.51/ >> >> The edk2-basetools part is adopted in the first patch (for >> "pip-requirements.txt"). >> >> The rest of the patches clean up -- superfluous, or even incorrect -- >> ProcessLibraryConstructorList() declarations (and, in some cases, >> incorrect calls), together with raising the INF_VERSIONs in the related >> SEC module INF files to 1.30. >> >> Comparing this version to v1 is not useful, as the compatibility >> approach is different, and so this version is structured differently. >> Please review any patches for your subsystem from scratch (they are not >> difficult or large). >> >> Cc: Andrei Warkentin >> Cc: Andrew Fish >> Cc: Ard Biesheuvel >> Cc: Ashraf Ali S >> Cc: Bob Feng >> Cc: Catharine West >> Cc: Chasel Chiu >> Cc: Duggapu Chinni B >> Cc: Erdem Aktas >> Cc: Gerd Hoffmann >> Cc: Gua Guo >> Cc: Guo Dong >> Cc: James Lu >> Cc: Jiewen Yao >> Cc: Joey Vagedes >> Cc: Leif Lindholm >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Michael Roth >> Cc: Min Xu >> Cc: Nate DeSimone >> Cc: Rahul Kumar >> Cc: Ray Ni >> Cc: Rebecca Cran >> Cc: Sami Mujawar >> Cc: Sean Brogan >> Cc: Sean Rhodes >> Cc: Star Zeng >> Cc: Sunil V L >> Cc: Susovan Mohapatra >> Cc: Ted Kuo >> Cc: Tom Lendacky >> Cc: Yuwei Chen >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (10): >> pip-requirements.txt: require edk2-basetools version 0.1.51 >> OvmfPkg: auto-generate (and fix) SEC ProcessLibraryConstructorList() >> decl >> OvmfPkg/IntelTdx: auto-gen & fix SEC ProcessLibraryConstructorList() >> decl >> OvmfPkg/RiscVVirt/Sec: clean up ProcessLibraryConstructorList() decl >> ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> EmulatorPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> IntelFsp2Pkg: auto-generate SEC ProcessLibraryConstructorList() decl >> UefiCpuPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> UefiPayloadPkg: auto-generate SEC ProcessLibraryConstructorList() decl >> >> ArmPlatformPkg/PrePeiCore/PrePeiCore.h | 10 -----= ----- >> ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 2 +- >> ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 2 +- >> ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- >> ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- >> ArmPlatformPkg/PrePi/PrePi.h | 6 -----= - >> ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 2 +- >> ArmVirtPkg/PrePi/PrePi.c | 6 -----= - >> EmulatorPkg/Sec/Sec.h | 9 -----= ---- >> EmulatorPkg/Sec/Sec.inf | 2 +- >> IntelFsp2Pkg/FspSecCore/Fsp24SecCoreM.inf | 2 +- >> IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 2 +- >> IntelFsp2Pkg/FspSecCore/SecMain.h | 12 -----= ------- >> OvmfPkg/IntelTdx/Sec/SecMain.c | 3 +-- >> OvmfPkg/IntelTdx/Sec/SecMain.inf | 2 +- >> OvmfPkg/RiscVVirt/Sec/Memory.c | 1 - >> OvmfPkg/RiscVVirt/Sec/SecMain.h | 12 -----= ------- >> OvmfPkg/RiscVVirt/Sec/SecMain.inf | 2 +- >> OvmfPkg/Sec/SecMain.c | 3 +-- >> OvmfPkg/Sec/SecMain.inf | 2 +- >> UefiCpuPkg/SecCore/SecCore.inf | 2 +- >> UefiCpuPkg/SecCore/SecCoreNative.inf | 2 +- >> UefiCpuPkg/SecCore/SecMain.h | 12 -----= ------- >> UefiPayloadPkg/UefiPayloadEntry/FitUniversalPayloadEntry.inf | 2 +- >> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 10 -----= ----- >> UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf | 2 +- >> UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.inf | 2 +- >> pip-requirements.txt | 4 ++-- >> 28 files changed, 20 insertions(+), 100 deletions(-) >> >> >> base-commit: 918288ab5a7c3abe9c58d576ccc0ae32e2c7dea0 >=20 > Series merged as commit range e60529df58e4..1c0db2315109, via > . Forgot to say: many thanks for the quick reviews! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116498): https://edk2.groups.io/g/devel/message/116498 Mute This Topic: https://groups.io/mt/104742520/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-