From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E244E21A07A82 for ; Tue, 25 Sep 2018 13:12:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CEF230E684A; Tue, 25 Sep 2018 20:12:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-71.rdu2.redhat.com [10.10.120.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id DD28B5D6B3; Tue, 25 Sep 2018 20:12:41 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Shao Ming , Fu Siyuan References: <20180925011145.14316-1-Jiaxin.wu@intel.com> <20180925011145.14316-2-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: <4dbed8c5-8899-81b8-ff41-2e0fe659d2c0@redhat.com> Date: Tue, 25 Sep 2018 22:12:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180925011145.14316-2-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 25 Sep 2018 20:12:43 +0000 (UTC) Subject: Re: [PATCH v2 4/5] NetworkPkg: Define one PCD for PXE to specify MTFTP windowsize. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 20:12:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/25/18 03:11, Jiaxin Wu wrote: > *v2: Rename and redefine the PCD in NetworkPkg instead of MdeModulePkg. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886 > > This patch is to define one new PCD for PXE driver to specify MTFTP windowsize so as > to improve the PXE download performance. The default value is set to 4. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Shao Ming > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/NetworkPkg.dec | 6 ++++++ > NetworkPkg/NetworkPkg.uni | 6 ++++++ > 2 files changed, 12 insertions(+) git-am complained about trailing whitespace: > diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec > index aae36226d5..aa721d8315 100644 > --- a/NetworkPkg/NetworkPkg.dec > +++ b/NetworkPkg/NetworkPkg.dec > @@ -90,10 +90,16 @@ > # TRUE - HTTP connections are allowed. Both the "https://" and "http://" URI schemes are permitted. > # FALSE - HTTP connections are denied. Only the "https://" URI scheme is permitted. > # @Prompt Indicates whether HTTP connections are permitted or not. > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|FALSE|BOOLEAN|0x00000008 > > + ## This setting is to specify the MTFTP windowsize used by UEFI PXE driver. (1) here > + # A value of 0 indicates the default value of windowsize(1). (2) here > + # A non-zero value will be used as windowsize. > + # @Prompt PXE TFTP windowsize. > + gEfiNetworkPkgTokenSpaceGuid.PcdPxeTftpWindowSize|0x4|UINT64|0x10000008 (3) here > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355). > # 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] > # 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) > # 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] (not supported) > diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni > index 5604b1bf32..07585680e3 100644 > --- a/NetworkPkg/NetworkPkg.uni > +++ b/NetworkPkg/NetworkPkg.uni > @@ -53,10 +53,16 @@ > > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdAllowHttpConnections_HELP #language en-US "Indicates whether HTTP connections are permitted or not.\n" > "TRUE - HTTP connections are allowed.\n" > "FALSE - HTTP connections are denied." > > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdPxeTftpWindowSize_PROMPT #language en-US "This setting is to specify the MTFTP windowsize used by UEFI PXE driver." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdPxeTftpWindowSize_HELP #language en-US "Specify MTFTP windowsize used by UEFI PXE driver.\n" > + "A value of 0 indicates the default value of windowsize(1).\n" > + "A non-zero value will be used as windowsize." (4) and here. With those fixed: Reviewed-by: Laszlo Ersek Thanks Laszlo > + > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIpsecCertificateEnabled_PROMPT #language en-US "Enable IPsec IKEv2 Certificate Authentication." > > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIpsecCertificateEnabled_HELP #language en-US "Indicates if the IPsec IKEv2 Certificate Authentication feature is enabled or not.

\n" > "TRUE - Certificate Authentication feature is enabled.
\n" > "FALSE - Does not support Certificate Authentication.
" >