From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Wed, 05 Jun 2019 01:13:10 -0700 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8237E30C0DEA; Wed, 5 Jun 2019 08:13:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-4.ams2.redhat.com [10.36.117.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id B508B5D9CD; Wed, 5 Jun 2019 08:13:00 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed" To: devel@edk2.groups.io, liming.gao@intel.com Cc: Ard Biesheuvel , "Wu, Hao A" , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" References: <20190604185843.22059-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E46BCEC@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <4de12a3f-ba2c-2565-7ae8-0cb2b18c0d9f@redhat.com> Date: Wed, 5 Jun 2019 10:12:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E46BCEC@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 05 Jun 2019 08:13:03 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/05/19 02:23, Liming Gao wrote: > Reviewed-by: Liming Gao Thanks, patch pushed as commit be689ecc93e5. Laszlo >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, June 05, 2019 2:59 AM >> To: edk2-devel-groups-io >> Cc: Ard Biesheuvel ; Wu, Hao A >> ; Wang, Jian J ; Gao, Liming >> ; Ni, Ray ; Zeng, Star >> >> Subject: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: >> don't display the cpu current speed" >> >> This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9. >> >> Said commit was not suitable for pushing during the edk2-stable201905 hard >> feature freeze; it was pushed only by mistake. The subject line referenced >> EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the >> display of the CPU speed from SMBIOS in multiple platforms. >> >> Cc: Ard Biesheuvel >> Cc: Hao A Wu >> Cc: Jian J Wang >> Cc: Liming Gao >> Cc: Ray Ni >> Cc: Star Zeng >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1877 >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> Repo: https://github.com/lersek/edk2.git >> Branch: revert_cpu_speed_hide >> >> MdeModulePkg/Application/UiApp/FrontPage.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c >> b/MdeModulePkg/Application/UiApp/FrontPage.c >> index fded7634062a..4b95cccb5cf5 100644 >> --- a/MdeModulePkg/Application/UiApp/FrontPage.c >> +++ b/MdeModulePkg/Application/UiApp/FrontPage.c >> @@ -621,6 +621,11 @@ UpdateFrontPageBannerStrings ( >> HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN >> (STR_FRONT_PAGE_CPU_MODEL), NewString, NULL); >> FreePool (NewString); >> >> + ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString); >> + UiCustomizeFrontPageBanner (2, FALSE, &NewString); >> + HiiSetString (gFrontPagePrivate.HiiHandle, STRING_TOKEN >> (STR_FRONT_PAGE_CPU_SPEED), NewString, NULL); >> + FreePool (NewString); >> + >> FoundCpu = TRUE; >> } >> } >> -- >> 2.19.1.3.g30247aa5d201 >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this group. >> >> View/Reply Online (#41886): https://edk2.groups.io/g/devel/message/41886 >> Mute This Topic: https://groups.io/mt/31929712/1759384 >> Group Owner: devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [liming.gao@intel.com] >> -=-=-=-=-=-= > > > >