From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 16 Jul 2019 10:15:25 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A918E3008A5F; Tue, 16 Jul 2019 17:15:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-187.ams2.redhat.com [10.36.117.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA84060928; Tue, 16 Jul 2019 17:15:20 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl To: "Gao, Liming" , "devel@edk2.groups.io" , "Kinney, Michael D" Cc: Marvin H?user , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Gao, Zhichao" References: <20190702102836.27589-1-lersek@redhat.com> <20190702102836.27589-2-lersek@redhat.com> <7013183a-31b7-d2a4-4656-d226e166e9da@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A91BF@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <4e20da31-8cce-8412-f3ae-0f2870c60b84@redhat.com> Date: Tue, 16 Jul 2019 19:15:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A91BF@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 16 Jul 2019 17:15:24 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/16/19 16:56, Gao, Liming wrote: > Laszlo: > Yes. Patch 1 & Patch 2 in MdePkg are both good to me. I have no other comments. Reviewed-by: Liming Gao Many thanks! Laszlo