From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web08.10387.1634917716187203612 for ; Fri, 22 Oct 2021 08:48:36 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=QAsCCh8R; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19MFP1AA024271; Fri, 22 Oct 2021 11:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=SVgcNz9Oz3cwe/LP1a1ed+m65jnUx7PMG7VXddKZRkU=; b=QAsCCh8RU7l7tEymEaQgzk6JcspNUl2kuzAgPuYhHe7Q+adVh2ykeep1iKyGHycP3Jnw IJou613Im/l2tDsF64tUcjwtqBHRXg4Qg1xfPAWSc/EHfbOf1v5EvQnuOLlGXwccbc+d lahOSt8km17ivh2OIUco6/MFD/FXkhBqSDKt6sapUqbFZ8+nAKsPUR/aVG5xRhxA8EMj HHfM/DX0Ojn6htHfgwk3o5HTb7rMSubnHOMLOOuSYQxuCx7YCDqKueaIfV87ppLor0h+ 8XzbgQSSrFzlCHLufGeERLxJIoU3YKK1sdYH+0iBSUUNIgnlVqAVLTKPVX5mz+8EV/yT lg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3buue0pj8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 11:48:33 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 19MFleT6017409; Fri, 22 Oct 2021 11:48:33 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 3buue0pj86-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 11:48:33 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19MFlhfi019800; Fri, 22 Oct 2021 15:48:32 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma04dal.us.ibm.com with ESMTP id 3bqpcemg7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Oct 2021 15:48:32 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19MFmVmC20906482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Oct 2021 15:48:31 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 08224136055; Fri, 22 Oct 2021 15:48:31 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4E8B7136065; Fri, 22 Oct 2021 15:48:30 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 22 Oct 2021 15:48:30 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option To: jejb@linux.ibm.com, devel@edk2.groups.io, Gerd Hoffmann Cc: Min Xu , Jordan Justen , Erdem Aktas , Ard Biesheuvel , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Jiewen Yao , Tom Lendacky , Brijesh Singh References: <20211021122003.2008499-1-kraxel@redhat.com> <20211021122003.2008499-5-kraxel@redhat.com> <03a75199-000f-5575-8898-6d9b113f2bee@linux.ibm.com> <20211022063948.mratwrzgponwiulg@sirius.home.kraxel.org> <46963c6b6e0eea2bf0b3629031f6f04232ea7528.camel@linux.ibm.com> <84d94886-bc85-9b98-6c7e-59207e6ea741@linux.ibm.com> <5fa198e0c4df2436ebbbe01cc8ebad4062e679b5.camel@linux.ibm.com> From: "Stefan Berger" Message-ID: <4e216f5f-edd8-61c3-529b-54eab3abf00a@linux.ibm.com> Date: Fri, 22 Oct 2021 11:48:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5fa198e0c4df2436ebbbe01cc8ebad4062e679b5.camel@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: tOxCTmAQ9hdk6lDdxRwWjtYrQuxdfT92 X-Proofpoint-ORIG-GUID: Pn4Hpqet8a93iUomfYFJ2KObaPWq1Lmb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-22_04,2021-10-22_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=995 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110220089 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-001b2d01.pphosted.com id 19MFP1AA024271 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/22/21 11:01 AM, James Bottomley wrote: > On Fri, 2021-10-22 at 10:52 -0400, Stefan Berger wrote: > >> along with the quote on the sha1 bank. > The validator shouldn't accept that quote ... it should require a quote > covering all banks. This is the point: you can't fake the quote and > the quote should cover all banks to assure you that unextended banks > really are. Unfortunately this seems to be flawed on the TPM2_Quote level... =C2=A0=C2=A0 Stefan