From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0089.outbound.protection.outlook.com [104.47.40.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D57E5208F7A8B for ; Thu, 10 Aug 2017 11:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=y/vtN2kIbERbjRJzVNvwj1y1jirWj7Tj6xbZafV/1mk=; b=vHUnIgz+jptHz9M9zSZEc9oppTFdTGSSgCLotnHqv90qYD6dQ/eEXps2FhFZkdWoDi50peX6QHss8j97NXk46vRxfFdUftui2fh4sS2/ovwc1SVyCgt2nNMeTnASi2c9R+VWcZCFwOnBDISrPHM1u+eYxgfA3xfc8ff9ciO9BSk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Thu, 10 Aug 2017 18:41:48 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1502107139-412-1-git-send-email-brijesh.singh@amd.com> <1502107139-412-4-git-send-email-brijesh.singh@amd.com> <3a8ede72-03f0-5627-f680-72f41da588e9@redhat.com> From: Brijesh Singh Message-ID: <4e2203d0-ae4a-67ae-2f1b-9d1908010b3d@amd.com> Date: Thu, 10 Aug 2017 13:41:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <3a8ede72-03f0-5627-f680-72f41da588e9@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR2201CA0040.namprd22.prod.outlook.com (10.172.59.14) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 598a70fa-1eb9-4e18-0bc7-08d4e01f762b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 3:wGPivC69lq/8eC+Potz8B0OFu9qRFKY88QPMDMG0fknSusn2odAV8rco1sQe270UA0K1nyZxbNC0bPI8UJ4MOjksiXnxBrHi7/bV+pbj0Z1eI/Wj5kPmyMV9UFqm2NX7e3HgHG0y10hNyybyma2zHTmBUnnULFxgXVqpu1qH4s37yUOLyMsPFHBAx4N42Yqom3aMTyZ7qeb9r9tJttP+Tu0D7krvFy+cJmme/3kTh8Fr9cAZw8h+jC8a39ChDIps; 25:JPd9XVnxpDTeX6Gpx4+Nal2VRQjNNWw5JWixgry6T3I6ddbBt3N1aVSZNi/YOhVEXvIK2od9HCSvv5wWw0gDTN4jviWT5D6QXHu0szjl+bEtPLuUw1dYCSGlZaxkFZhTuNUrM2Murig2v4543Qx3pX3yPa70ab9APUtnTzqVSMUdDhmh6+N74cwMO4WtDo5+v4YnsjtEf1OigKsNAorjzOPICeR7rb7jWxY69ZgS9IQSte+0wXnoyb3kWGCQFRNGxJGULzyHJ2fl+g+MJ5pDPt4nQkyBKmNO7EoHuBqqjY7MY8AQPnUairZOvIGeOzpJu+kAPpDGJwrdK+tKF8prug==; 31:fgycuyR+P8bpT5bcwcqNEMuwnIa9tJnueYbexclTWVIcuAnkZiyX4zlNGTykr7aUvMNnNDQqei4Pyr3cZ/8M91LwVr2DiQLLqNTlR91oITteGwOLHW48qddBJ/PF7zZeoiZ0r+vGeCcoVAMNHC2oAXXf6O1PvIF6k+brPJQYYk4Er5Vog7rNmTtTJ6k9IAJkOjC+zFAF897ZgPfPRV2VwrSv64dLllBk0gu93BtE7LM= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:wy54h/xcNGwyENF3uVbxXKN1i9u8zx7ZOoPPQVNkgqlRDlfMGnSJA1+ltpjjexr+Nl/n88q+AZcyQlXAOcDZlcToAnToNhIIsq/mLA5TdCCztO6i7Y6D9h/vy+RXBDdrgHxFVH5/PozTA9g7lUU6uMKNkLksYy/JNCKrgkGPOykeyw4G4PqSmoQhAo3rXprnTkh/D9g4dbR7gwl9dIpfOqzzFrmdcI6TUk/S79/3F9SdS5wkgYz00oz+VMv+WadxbUv7swggkGjgP4LpvRiQhEyyokmVcbIxR6WjDR6ZtLOrazao6YRS0fATWS7hHx2VUOVzj+zwwZb8+9fg+wDEpcTxE4pWp7PAsLFRBm+8bYHaykLPdlOuY3Gzk3IbJzvpeQA4PHwDnMaPnz6VTPSp169+x9SF2XcOnSct8LRBQdkYnb9/oK4TwUjavvWE7TJ01bVipqtfroYODc18FGs/Ejr06jtvkPVuqig7o7l7bcv/y2ComVJLfQfqbAfntKYv; 4:qrxREmTaVq0iBmLFJuQMRQctcXogqgFC4v6k6HxMKmYpcZnSkYuCg9ps7KeLYRTq8gSYV9mofQvfBBYFtwhoFIpkL3YGvo3N9NZQB79HguhxAKbWwTVtyVM+RbaLHda+ej0Rao9DiGGVuijc77N/oiw6FqEo8hsFpdESDUTq2jrPGk2jpJZ0HCpm2hadxS8Uak+7Dg1TJ+kf1cCcH3ACAortYSGyGld2cUOqpTWiBk4jpouSgvmR+RlEVcgRJR7e X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0151; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0151; X-Forefront-PRVS: 03950F25EC X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(6049001)(39450400003)(39840400002)(39860400002)(39400400002)(39850400002)(39410400002)(199003)(377454003)(24454002)(189002)(25786009)(76176999)(106356001)(42186005)(2906002)(86362001)(6246003)(50986999)(54906002)(50466002)(83506001)(53936002)(4326008)(105586002)(478600001)(31686004)(38730400002)(110136004)(54356999)(23676002)(33646002)(68736007)(6116002)(3846002)(97736004)(53546010)(65956001)(66066001)(4001350100001)(65806001)(6666003)(305945005)(47776003)(2950100002)(31696002)(230700001)(101416001)(7736002)(8676002)(5660300001)(81156014)(189998001)(77096006)(7350300001)(64126003)(65826007)(229853002)(81166006)(6486002)(90366009)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0151; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOnBRZW9oQ2pyRWFkUFM1enh6cjRCSjNLSGFx?= =?utf-8?B?UkNEMzRHOXoxRTN1QkpTb3lsbDZvb2o0eXlnOTFXeFVoV1VUK2dPMGY0bE9B?= =?utf-8?B?UVloL1ZxM0puT2ZpRjRPVXhFVmhqZnJFZnJWa1NCUnlDUXFrdDcvTytSekNR?= =?utf-8?B?Zkx2b0dNN09LSFdJV09qYTgzSDB6bitnalZRcVZCREFGcGI5TEhyZTViSmhU?= =?utf-8?B?UHk0bnFoaS9DeHcxT1IrZk5Iait4cXI1Vi9wNVVqdDIxMWpPSUpZMjRNY0p6?= =?utf-8?B?N0prRVZjR1orYXhpZ0paS01vak8vWm13OUl1RjI1YUhhdHByWkw0eVJuTWpT?= =?utf-8?B?TktMY0pYbmZna3JhUm5jaDlKZkFKTit2L0RvWlNsbGxzL01EMGltWlZpWDFS?= =?utf-8?B?NGlEcjEwMWIxSW5RVWs4Y0FMc1FsemdjYTN0OHF3aHRIS0paTzNjM08rMFdl?= =?utf-8?B?ejFlTVZCSkZKYndkdTN3UmZaK1lEVnRRMUN1c2JBaHFpWHZNTHdNMVZnUjZ2?= =?utf-8?B?UHdwaVFsUVN4OVJnL3B3R21jVG4raDFYdlh4a1ZVdHJjODRnRVNKWnNyb3Ni?= =?utf-8?B?am9QMEx6OGwwV0s4VjFzTldOUzdHY2RDRFRRNmZDZ2U0ZUw1MTdhN25HL1Uy?= =?utf-8?B?cU8rODhzalhTUzdSR1Fxb1hCb0N1SU1xZnZqd2pPNzV4eWZqVzQwT0RRVHF2?= =?utf-8?B?OGdHUnRCdmRsZmJmK1hLSW9pYWlTSlk5M213bTJMQm1xRExHOGRPa0MrbFBk?= =?utf-8?B?Y2JIUytZZmdRd1RPUHppR2t5bmExcVZ0RmNjYlhPOUdXQ2grNTVqOGhSRjho?= =?utf-8?B?Wm16Q2ljeEdWRCtPZEkxKzhCeDF2dHZ3d2ZZd2c5THAxMUpnaDlWZWNwbjc1?= =?utf-8?B?NFRPOUhSd3RCblBVK284Q0dBYUFDVGk5V3BkMnp1bko3MnM2MVpNNFF2SG9v?= =?utf-8?B?ODNkVEk1NVhQT0FiZit3TmMxMnBUUDZxZ2pPVzlLNjd6U1d2K1gra0xsNHlF?= =?utf-8?B?TXFiLzZLajFYV09XYk9ZL3UxSWpKL2EvVXA4WU5OSFA1WVZyUTBEN2NKUFFD?= =?utf-8?B?L1JXYS9xMG1MWGhxWWNLcktCc0REU3I0QlFjczdZY2NnM2MvZ1Ivbmk1Nk4y?= =?utf-8?B?ejdCSWovR0xWcHFXV25KV3V1Nkl4Qm1DLzAzS0hVdGU3VWRuMW03MWJzM2ZE?= =?utf-8?B?S0EyRmcwaFF4UVN4QVNnalRMbkxYV1hmWXloMlBvYUN2MGtXZndFTFJOTFlq?= =?utf-8?B?cC9RWlY1eGhXUXRjRHg1L3pBck0wd0c4NWwxZzFMU0xWT0FqTnVmc3lEa2Q5?= =?utf-8?B?eVJlaTFzbDNraGt3SFd6a09tWHYzaGpYUCtKVmRvK1Z0U09jSFJUV1E5cFdx?= =?utf-8?B?RC8zTFpnMmZkZXlXbmJweDZzZGxTdjRoUmx6Uk9FazRJcTI3SmFUSGFsQWEw?= =?utf-8?B?ZkRyaGlMbGZxdVJFdjhpV04rTy84em1NQTdad2lxbWFhM3BpK3FRR21MMHRY?= =?utf-8?B?TW02NEo2Snh6bmJkU3FrS2dmdXdEVTFEK0tZTzlMaTdicGRVSG0zZi9tS0Ex?= =?utf-8?B?SG5vRVZpck1tZVRKUGdqcmpPV1dGVC9TZjIzNC82dFpRVnJCTEtQeWVXYVFG?= =?utf-8?B?OGdiRFdqaUtvenRWYzc4aFR0TnNuSGVZQVkwZHl5dW8zSXNwR251RWlweTUw?= =?utf-8?B?VVh4VU9rc002ZDR0TlV4ZUZ6MjhlZExzZFpkUFhwTmhub3A4MDNnZ09MVVc4?= =?utf-8?B?QkRLTG9KaEdPV0t3ZnZTR2xXRDQyZTlvR1VXWms4ejNPYUpGQXRIVjJlVGVJ?= =?utf-8?B?RjFLNGxWcEdXNUJiOFFScjJZS3lSUDZzSEQ0ZGJMNnJyclhVMVdYR01tRG9U?= =?utf-8?B?YUxRUko4VCtoNkRsMUszRzJKOEE0bVUxbWJ3bUNYc1JZUFpFZzArMGpQMWxS?= =?utf-8?B?QUFRNkdmVExnVktOUVdJVjIvQSttUzZ5U1JnNDIwU1JRbWdmbkYraCtQT0Fr?= =?utf-8?B?MGpTNmdRM3VrRTdPc294YkNyTS9YWUFkWjFKclgwNXNVbG9kSnNxVDNuaVZL?= =?utf-8?B?dUpGZVplZUFPOXJUTGZzSHFXb2Y5ZkxiRlp0YVFNNHUwSlpDOUNxRU1aSWVW?= =?utf-8?Q?+J6r/+mgLpHOMiujqh+U9K8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 6:K2OEA9cJB72o27dvC6mDwwJUwqIoEwoRj8MmivDR4C0lrTOgwwiW/hOsEvdt0VPm7ffQQpwJ+InHwiUuMhakxCqISislIPDaFf/icQH0gzrOdEfc6cmUv6aB8M9Yx3VkeSWnkSuSSksu1XbJpKl8i/lqWTAMWdr3sE0CAHEJuCJMn2geAJ73YukPNQmQL9BJdBgbkRJpGosBKC/fffW3pweMg82T43AQFHpXZQCB28fmlzZLNtbHHZ2nITr8UEasjzJQ5dJqDtnEynxtu9KX0dtL0+pwS+BHyMr5u8XSDduhsLKSnIwGDu7sdN1T9ybDSp8hRVnzpVl7hJcMBZWFDw==; 5:Wy8mXV5yI7pgvs5DjIiDqMTCpCmtfZnR3gPzAx6VGOAkgE1rMpWCr81eqy/QkxEi0lsnU4oQwZXwXAq61NWcd1y1YMf3ahH7Y0paYlLyMMf+lKz0JBZLw/Qx7bfUr7sVgw3PiFbchdMe8ZmHTTd7bA==; 24:a1FLS7mkzhoj7Hl8t6sG1z612fMGC1rPsmALUq3wmWEf/SWNuOT6I8cSsvNdiqGGOSFf9fkDGlxD5ySM7cY7faGJtV3crN1Mx9hbI0cV7O0=; 7:HXLFul06u5QReyz0jVrO1i13Df+3reiu2QaoW4fFz2687dteqtfbNQvZirh0X3QGDw2RCOuekPgORsVt1NnTdibpRTm9hCr+JgaM+MF8J0k35AHDZPL2N9NsZPzzOd9/NcDiZ7d9cPRRNrToXYnS3noM9dxpGgvGPiAW65FXzd8b/Xg0YoAav8msYdsEGIHphZ6AQeBdnbz+O4grwqUtclqMnN7G5VM0udz+LWSl2QM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:CU8vgfp6gKq3CT6CCgxH2EygiHM7LOvjP6CWBCa0ii2Pw9Tmp5kt6YfT13z3QvnHmV4t8haxQ5et0xIPL37073/B0j0cr1xowVLf70Sg0PKcdk0GAZDl45NDwZQTh7vZxibXaBxrE3NIHLSHHe8OniuKp8mNF4CN9EJAHLl8dWVNkC6sIgxKopuW+ccBi9/RKsBagsLcpIVlLaFlOig7CqCVbxtzv4HBjWQCXdF9VjHIjbD0Uze5bWU+JbYO70V2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2017 18:41:48.6597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Subject: Re: [PATCH v1 03/14] OvmfPkg/VirtioPciDeviceDxe: Implement new member functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2017 18:39:32 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, On 08/09/2017 12:09 PM, Laszlo Ersek wrote: [Snip] > >> + >> +EFI_STATUS >> +EFIAPI >> +VirtioPciUnmapSharedBuffer ( >> + VIRTIO_DEVICE_PROTOCOL *This, >> + VOID *Mapping >> + ) >> +{ >> + return EFI_SUCCESS; >> +} >> > > (9) Please refresh the function signatures in both "VirtioPciDevice.h" > and "VirtioPciFunctions.c", from the protocol definition in > "OvmfPkg/Include/Protocol/VirtioDevice.h". > > In particular, all the IN and OUT decoration is missing here. I see that several functions defined in VirtioPciDevice.h is missing IN and OUT, do you want me to send a separate patch to fix that too ? -Brijesh