From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.30647.1583660456713928642 for ; Sun, 08 Mar 2020 01:40:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R4UqnK40; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583660455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gfmAx8sxgpYTboRXRKtiUqVrKc534gh8D6HQQONLJr0=; b=R4UqnK40wOqKZV7nKVImHSZuSH5imakE/Vq8l7SN4L1m4/B/813z+Ub1Z7C3k9pL86z6y9 vBhZbm9t3yuNQ6PEJOhvyEal+PRLzl+Of4omQidnuzl6kgI4RBC3Q9MDy1SWWO7FHhA2Hb ISLmfWgIY4FnCY4r2/atvWsbB4SetJA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-smZfvHdAM7KSMxBre54Hog-1; Sun, 08 Mar 2020 05:40:51 -0400 X-MC-Unique: smZfvHdAM7KSMxBre54Hog-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB18613EA; Sun, 8 Mar 2020 09:40:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-62.ams2.redhat.com [10.36.116.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E9AB5D9C5; Sun, 8 Mar 2020 09:40:49 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: fix "unused variable" error in X64 DXE builds To: Ard Biesheuvel , edk2-devel-groups-io Cc: Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200306230442.24100-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <4e32dfd7-a4f7-4644-654a-24b72dda9416@redhat.com> Date: Sun, 8 Mar 2020 10:40:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/07/20 15:34, Ard Biesheuvel wrote: > On Sat, 7 Mar 2020 at 00:04, Laszlo Ersek wrote: >> >> When the MDE_CPU_IA32 macro is not defined, there is no access to the >> "KernelImageHandle" local variable in QemuStartKernelImage(). This break= s >> the OvmfPkgIa32X64 and OvmfPkgX64 platform builds, at least with gcc-8. >> >> Move the local variable to the inner scope, where declaration and usage >> are inseparable. >> >> (Note that such inner-scope declarations are frowned upon in the wider >> edk2 codebase, but we use them liberally in ArmVirtPkg and OvmfPkg anywa= y, >> because they help us reason about variable lifetime and visibility.) >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Philippe Mathieu-Daud=C3=A9 >> Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d14cc >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2572 >> Signed-off-by: Laszlo Ersek >=20 > Reviewed-by: Ard Biesheuvel >=20 > (in case you still need it) Thanks. If the workaround for the current github / mergify outage turns out to be "resubmit pending PRs", then I'll likely pick up your R-b too. Seeing how your latest is also stuck, I must wonder what is going on at github. They have not responded to my ticket (592107) and their status page claims "All Systems Operational": https://www.githubstatus.com/ Which is not the case. Mergify have their own status page: https://www.notion.so/Mergify-Status-Page-7803a762235d4ee6bed1f9976d17bd83 and that also claims "Dashboard Operational" and "Engine Operational". I've now sent an email to too. Laszlo