From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 42A63D80127 for ; Thu, 1 Aug 2024 11:28:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gAjZ/9ztt3MLe2tGNw5gFOJaYD+A8E8QoqW88xBV/tI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:To:From:Subject:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1722511728; v=1; b=XMpLNugQQJce4qhfJPAMSqxoEy5c/cV+iO2CIUcVhBz3ZnlVwhxsHauhv/w8+dGPFnsCM+2t 00mH+5fandu2d3hoS7e6RAt3BTR1oJJLQthr/39pSMZ6V94FJW1ZpozQSQ87KCqNQpgKP0ejy/z x+hZhkwQ4ZsCv8taWmtbfMJm3BRkX48qlF+QKybipOoblHikjVxLfXHG7Ny+weegC2rqtePXPc4 1/WYdbTMISZK711a02wJpWw64zw8kAjN+e4FMNqhT4OTmWfO0cddsNcRaJVpPlpZhB1NscAioHt z43NUYrHzMZfKaEe91YAblncEAxqr+GPs348FXoVEVZXQ== X-Received: by 127.0.0.2 with SMTP id 3cHCYY7687511xDKNokXrarp; Thu, 01 Aug 2024 04:28:47 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.67]) by mx.groups.io with SMTP id smtpd.web10.65815.1722511726878965275 for ; Thu, 01 Aug 2024 04:28:47 -0700 X-Received: from IA1PR12MB6460.namprd12.prod.outlook.com (2603:10b6:208:3a8::13) by BL3PR12MB6377.namprd12.prod.outlook.com (2603:10b6:208:3b0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.22; Thu, 1 Aug 2024 11:28:43 +0000 X-Received: from IA1PR12MB6460.namprd12.prod.outlook.com ([fe80::c819:8fc0:6563:aadf]) by IA1PR12MB6460.namprd12.prod.outlook.com ([fe80::c819:8fc0:6563:aadf%4]) with mapi id 15.20.7807.026; Thu, 1 Aug 2024 11:28:42 +0000 Message-ID: <4e3b70bf-2655-46da-bcc8-ba1c57ae4382@amd.com> Date: Thu, 1 Aug 2024 16:58:35 +0530 User-Agent: Mozilla Thunderbird To: devel@edk2.groups.io, sami.mujawar@arm.com, Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann From: "Aithal, Srikanth via groups.io" Subject: [edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression X-ClientProxiedBy: MA1P287CA0021.INDP287.PROD.OUTLOOK.COM (2603:1096:a00:35::29) To IA1PR12MB6460.namprd12.prod.outlook.com (2603:10b6:208:3a8::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6460:EE_|BL3PR12MB6377:EE_ X-MS-Office365-Filtering-Correlation-Id: 75726cf7-6c1e-4088-3424-08dcb21d191b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?utf-8?B?WURiSWFUR0J6cEhha2REVEhMZnVJV0pDVm90ajNEQ1FCamNYUkNOYnhSK2oy?= =?utf-8?B?QmJMTSswRFdlZXBTbU4zTVk4ZUpDRVYxZm5JSGJHRW82QWRteG9wOGxNQWpF?= =?utf-8?B?K05IN3pyc1prbWJGYkIySTBYRkU2dld0YnVocSszTDVYVThBZ01YaGd5RXZz?= =?utf-8?B?QW1qOHpBMXpLVkNoaFVObWdZVUhFeVlCdjM5cHNDcDhaNHY1bHE3MWZWcFlD?= =?utf-8?B?VThXcHlhVGdUQWZCeW5wNWRzcjhWYjlJZEt1R295elJVQzBkcXBPVmQxZWhj?= =?utf-8?B?QXdnWmFKQW5wdnhhS2NvUkd5THI2RUFlR3lpRkIwSDZ3UWdoYWZhOFZCVzZr?= =?utf-8?B?dUxOOUorRTQ3WmYyQ2hNWW0xNkw2dyt2VmhjRTVSMVFES0k0VWdMaUhtRXpX?= =?utf-8?B?ZWc5bnFzbjNFYmN2dlZHT2t2aXVVTk5Mb0svVGRMQjdicVNJd2l4anZFcHBj?= =?utf-8?B?WGpFMU8vbi9FQnJaaFdDRExVMDNIMGxTd1BjNmFtbE5wdXNqWTAzTlhiZkUw?= =?utf-8?B?N3Q4NmprVDcveU5GVERBMXV3MGFPOGUycUlBSFlEZ2plcERmSi9tdnlOTzhS?= =?utf-8?B?VWZNZnV2WStPVFBuNERXL0ppbU00VllJRnZRd21OekVZOG5CcGlwWmhOczRv?= =?utf-8?B?MXVNcFF2SGJyWldjZlZMRWVOMFdtb3lQTnBJelE4TjZTK1cxZy9KWSt6VWY2?= =?utf-8?B?eWxhY01KWG4zeStqT2JCSEVEU0lvQVlJL2dCREo1U21zd091Q0s2THlFYWoy?= =?utf-8?B?VUxIUXpKQjY2NGY0VVdUWmtTc1JLNjdFQ3JzWHpMQ0JXRnEwbzhRUndFWUJw?= =?utf-8?B?M3d1aGlSZGIwdVBUU05hcEthR3lueWpDcktMQnJPSTMvdFZzNWRXRU5SRjds?= =?utf-8?B?TWFlcUExUVlYUFBIRlViUldGclBkeGlWbVh5R3l6c3hkQkhRSk5FVWt3blBk?= =?utf-8?B?b0hRU0xhQ0NXNnlUN3NLMWZmbDJybHNvRzJBMzRzV2U3RkpLOUxSMWE1N2pQ?= =?utf-8?B?WEZpaVZMbmpEYUxlK0xUVXRrcWZBZHpsSUpHYllHdVV5UDNOZmVYUmVvdkxy?= =?utf-8?B?RitiNENDdnlzeng2R3pacG1QUFArdzhKQ01qY2FOTkluVElFSkhKdW1pM1FR?= =?utf-8?B?b1dDcU1RYVdsM3dpUGxIbmkrekZJU2lBWlJZbjJBSUdyVWxoZGJRZDN6d0NW?= =?utf-8?B?aGF3S3Z4SlhadlVKUGNrVDJNVHI4S2dXbWFxMG1QM2FDYWRPNzdRNHdoc3Er?= =?utf-8?B?bG96RUduNnh1OVVVMEs3UUFUdWVrRDQvaGNBL01PUWd6TzBCaTBCcWdWVjVs?= =?utf-8?B?a1d6cVZqVVkvd0N5elcrdTJ5aVBnWnc3M1Zva0tMN3p0OUhPSk1MUWJ3MzNz?= =?utf-8?B?QWpCMVlNVFgzVUNrcTAzQXcxRERkN3NyZEs2ai9PTUdJdXhKR2tDeFNnZVJO?= =?utf-8?B?YUVpR0I4UmZVS2FyTS9aN2FVQ2pmTFpOMU5KUWFDYVMzVTdNTXg2b2drTHBS?= =?utf-8?B?ZUtWMkJUczhIdW5zdXN3UFZBNHBremFOL1VFNVk2SkJUUldva1hCYy92YXhz?= =?utf-8?B?TnUxcTVkdXpiVVdLZ29XYStxL241QXFXWmNYWk9TanFtb09pTHk1NTNHSnBu?= =?utf-8?B?SXlzL1VYUjFrNVV4c1VwY2N3M3ZXVDZUTVFIYlhLUFdpQ281d1daU2ZjOXVp?= =?utf-8?B?eWFFbkJEdlAraTNUWXFzZ2pqWDI5dTNQaTh6Z1pwVU10TnNoUjNsemZBdnYw?= =?utf-8?B?UUJndjl4eUFOWGxpNndwM3VaRXVta3E4S3RCN0FvUFFxMGUwVGwrQjE5bG1p?= =?utf-8?B?OVNEVksrSUhBVFY1VGQ3UT09?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bnlyMlU5bld0cEN1SFBMeG9zMFQrVGRMYzdCTXl6T0tLVFNEa3c5aWU0SzZV?= =?utf-8?B?NDZ4enFJbkt3Wi9haGVqYXAxMzNxNGFHK0pDNDVpR2drUXRGTmFVZGlpL1FK?= =?utf-8?B?QWRaUTdkZ3AwenlBUHlRMld6QW9OVUJXZGZaVHhDcmlWZTJBd0ZHdUF0SEFj?= =?utf-8?B?ajVEWHBndE1hcTF6LytMdEtXTnRDNXV1cjVneGZtY1VKdmlNMjBHSWs1cU9K?= =?utf-8?B?MG5QZHIwWDZoNE9CS1o0b3BvM3BlZVJRYkhRYWY4SFZkSUJFQkoxeWg3bVMy?= =?utf-8?B?U3AxSEdYWW1EWng1dEluRElCOHBWK3BWSFc0dTJPZ0RJWk5QUXRpTWRhSjZs?= =?utf-8?B?SWRCQ1k4QVRSNGtxeE5TTitmdmtFN3BuSEZqVnRCV01mZnFmSTBSdjgzckcz?= =?utf-8?B?YmMyV0NVVE9UMkRUU21tWWlWYUVySWdoT1psQ2ZVMXFhTGdvNlUzZE9wbEk1?= =?utf-8?B?OUdBOWZOL05vNEN1b1h6MU50ZmdCRkcxUGxSaU9WMGJFUE5mNDJsbitxMi9i?= =?utf-8?B?aWNkK2dsQ25qVGNkSlM0RTM2N0JNSnd6UndQOUZJaXJpc2wzampRWmlRT3E4?= =?utf-8?B?bk5lVndWSnltQTd6eHJJMkNGSDZNNEgxMVhhc0toYVY4bjRURGpxRjlmMTFS?= =?utf-8?B?V0ZzWmpRMFVMSlZmS1FkMHRCMjZpN1VuaUFwTEVPQXZYNjkzbGJoekIybWkr?= =?utf-8?B?YS9ycFpoSDlpc25HWTQzS1c3WHRrNkN2emxlMXpoYW42ejBQTkF0alFWMDg4?= =?utf-8?B?R2NGcFI0cHR3QkRiMjB4ZFREenI5aUkwUm45a1hmQXhXRWplQkVaQ1RldzBv?= =?utf-8?B?amFhOWp4QlVmV1E4Z3FpWEUraE5LTU9jaVVPNW1IeWtudmRJNk5YLzY3d3Fz?= =?utf-8?B?NFQxTFdtcmxqRUtOaXg1c05McUhJMWp0Y0l5RVkrQVBvTXJHcG1IMDQxMjZH?= =?utf-8?B?RitWVWJCdHJwU2wxVnFXR0hVdzBGaW12eE9KQmphQW0xUWd1L1pDaTNuNFpq?= =?utf-8?B?bERYYkx2bU1OU092K2NuZko5bkgrODUvQWFkZkR2cm1mRDJUQStXOWlDVG1N?= =?utf-8?B?RXlrS1R4L3FGK244MWExeW5sd1BDZmJBODhLUEI3ZURQMkc0emljTFN1WEVM?= =?utf-8?B?ekRTQXFRc2lQQVdMUGVGZVljSWZDaDFNd0R4ZVo0Y3M1bFBTdXlBSDIzRlNY?= =?utf-8?B?TFhwZ0hIOXVBcW9pajJJOHdBZXYwTE9UanluL09oZFpmK2lxUTVUbFR0WjdH?= =?utf-8?B?KzNZQXIzWHZVR003MGhYeGpqaDJLdDFHUFA3d09oYXI0YTUrNzVnV3ZlVmtF?= =?utf-8?B?WVRnVEhIaktabVJOenRYUFJmV2VqVk5qWDc4OHdobi9nV3JQSEJaZjdDUWVC?= =?utf-8?B?SGpmSnFtblRTQ0E4N1ZtRDZRVnRxOGx5aEZsSHZJQUNxTzlTVGFDTnRDWkM2?= =?utf-8?B?a1FnTWxYL1FOOWIwYlRXcHYwUUtybE5qUjZnZDRaMTJ5dWFCR3lsVW81NWlY?= =?utf-8?B?QVI4SWdndEU4S1BGYUZDOGxhb2FKVldWY05vOXFxUzVHTXpab1pBWUxHdkQ0?= =?utf-8?B?aW1hUTNoN01JcmkzaGtHWGFpU0NlYkZJdVZramlNT0Y2aTNaYTlNNEdnWVlD?= =?utf-8?B?VDI4aXRFRktuZWpUd3BuVmNVYWVhMEp0RWVrV2hvOURhN1Zhd291UXcyYThB?= =?utf-8?B?WFNiUHZQRitjT2JmcG9VTHJ3dUhLZzhZbjljQTFxZ04wRDdKSjVnMTNtVmVr?= =?utf-8?B?V3VTTCtacUJaYnBLZ2kzY0ZSdzBick5uVWFsVlJLbnFWemJzSS9hTFZKY0pD?= =?utf-8?B?T0FtTXl6UTVNRHd2N1A1TzljVFczajlNOGZoSy9TN0dKdUlTU1hCN3VMQVRY?= =?utf-8?B?dmJpeFJjaTRZWG03OUZXT09ZaC82NjR6NkF1VFk3a3F0K3R6STc3Vm9wM3ZN?= =?utf-8?B?TTQ3YVZoWDF1ckU2S05RbzVPeFBTTFJNQXBDanoyNWMwQjc5cStiZlBodnpw?= =?utf-8?B?V0QrSllaQ1VSTXd2SXBFSUV1ZVBnUmk0ZVBrSXRuVzNlT2xlZkFPOUovY2Yz?= =?utf-8?B?bGQ3ZlAva085dGVqLzAvbVVHR2lrbzZjeUxrR0dKQk9kUzJlSVRZWGU0N0pM?= =?utf-8?Q?l7kPnWZSIDJcUd65FfAd99aNL?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75726cf7-6c1e-4088-3424-08dcb21d191b X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6460.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2024 11:28:42.7582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HUDmpToxMBhcKeKbTW32mNss2xKXn3059xS+Or6fFLz64CZD0ftfsytqZTx6BA6eqzNA8xuiJij+kwo1DuPJrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6377 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 01 Aug 2024 04:28:47 -0700 Resent-From: srikanth.aithal@amd.com Reply-To: devel@edk2.groups.io,srikanth.aithal@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: srXhstT6F7kVTmRTN1IJWxwox7686176AA= Content-Type: multipart/alternative; boundary="------------zJgyEUkTGg0j9rR0qRlWhZOh" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=XMpLNugQ; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io --------------zJgyEUkTGg0j9rR0qRlWhZOh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello all, After the patches [1fc55a39, b342070c] OvmfPkg: Use heap memory for virtio-blk request/OvmfPkg: Use heap memory for virtio-scsi request got merged, this regression is spotted. AMD SVM/SEV/SEVES guest boot fails with OVMF packages [Ia3264/X64] built from today's upstream edk2 repository[Head: 85fad99]. Guest boot with OVMF.fd or only with OVMF_CODE.fd gets stuck at below point: /Divisor   = 1 BaudRate/Actual (115200/115200) = 100% PciSioSerial: Create SIO child serial device - Device Error PlatformBootManagerAfterConsole Found Mass Storage device: PciRoot(0x0)/Pci(0x3,0x0) InstallProtocolInterface: FA920010-6785-4941-B6EC-498C579F160A 3DEB82A0 InstallProtocolInterface: 143B7632-B81B-4CB7-ABD3-B625A5B9BFFE 3DE10AA0 InstallProtocolInterface: 0167CCC4-D0F7-4F21-A3EF-9E64B7CDCE8B 3DE5D4A0 qemu-system-x86_64: wrong size for virtio-scsi headers <========== gets hung/ If both OVMF code and vars file are provided the issue is not hit. Qemu command line to recreate the issue: /qemu-system-x86_64 \ -machine q35,kernel_irqchip=split \ -name guest=vm,debug-threads=on \ -drive if=pflash,format=raw,unit=0,file=OVMF_CODE.fd,readonly \ -cpu host \ -m 1024 \ -smp 1,cores=1,threads=1,dies=1,sockets=1 \ -kernel bzImage \ -append "root=/dev/sda rw console=ttyS0 net.ifnames=0 biosdevname=0 movable_node swiotlb=65536 " \ -drive id=disk0,file=22.04-server.qcow2,format=qcow2,if=none \ -device virtio-scsi-pci,id=scsi0,disable-legacy=on,iommu_platform=true \ -device scsi-hd,drive=disk0 \ --enable-kvm \ --nographic / Thanks, Srikanth Aithal -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120171): https://edk2.groups.io/g/devel/message/120171 Mute This Topic: https://groups.io/mt/107663187/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------zJgyEUkTGg0j9rR0qRlWhZOh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hello all,

After the patches [1fc55a39, b342070c] OvmfPkg: Use heap memory for virtio-blk request/OvmfPkg: Use heap memory for virtio-scsi request got merged, this regression is spotted.

AMD SVM/SEV/SEVES guest boot fails with OVMF packages [Ia3264/X64] built from today's upstream edk2 repository[Head: 85fad99]. 

Guest boot with OVMF.fd or only with OVMF_CODE.fd gets stuck at below point:

Divisor   = 1
BaudRate/Actual (115200/115200) = 100%
PciSioSerial: Create SIO child serial device - Device Error
PlatformBootManagerAfterConsole
Found Mass Storage device: PciRoot(0x0)/Pci(0x3,0x0)
InstallProtocolInterface: FA920010-6785-4941-B6EC-498C579F160A 3DEB82A0
InstallProtocolInterface: 143B7632-B81B-4CB7-ABD3-B625A5B9BFFE 3DE10AA0
InstallProtocolInterface: 0167CCC4-D0F7-4F21-A3EF-9E64B7CDCE8B 3DE5D4A0
qemu-system-x86_64: wrong size for virtio-scsi headers   <========== gets hung

If both OVMF code and vars file are provided the issue is not hit.

Qemu command line to recreate the issue:

qemu-system-x86_64 \
-machine q35,kernel_irqchip=split \
-name guest=vm,debug-threads=on \
-drive if=pflash,format=raw,unit=0,file=OVMF_CODE.fd,readonly \
-cpu host \
-m 1024 \
-smp 1,cores=1,threads=1,dies=1,sockets=1 \
-kernel bzImage \
-append "root=/dev/sda rw console=ttyS0 net.ifnames=0 biosdevname=0 movable_node swiotlb=65536 " \
-drive id=disk0,file=22.04-server.qcow2,format=qcow2,if=none \
-device virtio-scsi-pci,id=scsi0,disable-legacy=on,iommu_platform=true \
-device scsi-hd,drive=disk0 \
--enable-kvm \
--nographic

Thanks,

Srikanth Aithal

_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#120171) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------zJgyEUkTGg0j9rR0qRlWhZOh--