Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 3448 bytes --]

Hi Ard and Gerd and other maintainers,

Could you review this version and give your suggestions?


Thanks,
Chao
On 2024/4/26 16:28, Chao Li wrote:
> Patch1: Added three PCDs for QemuFwCfgLibMmio
> Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE
> stage library.
> Patch3: Added QemuFwCfgMmiLib PEI version
> Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and
> enable it in AARCH64 and RISCV64.
>
> V1 -> V2:
> 1. Use HOBs instead of PCD.
> 2. The old patch2 is divided into two parts, one is code splitting, and
> the other is functional changes.
> 3. add two patches to keep the safe when change the platform DSC file.
>
> V2 -> V3:
> 1. Merge three HOBs into a single HOB.
> 2. Remove the dynamic global variables in PEI.
>
> V3 -> V4:
> 1. Adjust the HOB content, this version saves all of structual contents
> in HOB.
> 2. Remove the Loongson copyright in separation patch, and add it in the
> funciton change patch.
> 3. Restored some variables as static in DXE version.
> 4. Added the HOB GUID in OvmfPkg.dec.
>
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4755
>
> PR:https://github.com/tianocore/edk2/pull/5568
>
> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
> Cc: Jiewen Yao<jiewen.yao@intel.com>
> Cc: Gerd Hoffmann<kraxel@redhat.com>
> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
> Cc: Sami Mujawar<sami.mujawar@arm.com>
> Cc: Sunil V L<sunilvl@ventanamicro.com>
> Cc: Andrei Warkentin<andrei.warkentin@intel.com>
>
> Chao Li (8):
>    OvmfPkg: Add a GUID for QemuFwCfgLib
>    OvmfPkg: Separate QemuFwCfgLibMmio.c into two files
>    OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio
>    OvmfPkg: Add the QemuFwCfgMmioLib PEI stage version
>    OvmfPkg: Copy the same new INF as QemuFwCfgLibMmio.inf
>    ArmVirtPkg: Enable QemuFwCfgMmioDxeLib.inf
>    OvmfPkg/RiscVVirt: Enable QemuFwCfgMmioDxeLib.inf
>    OvmfPkg: Remove QemuFwCfgLibMmio.inf
>
>   ArmVirtPkg/ArmVirtQemu.dsc                    |   2 +-
>   ArmVirtPkg/ArmVirtQemuKernel.dsc              |   2 +-
>   .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c   | 243 +++++------------
>   .../QemuFwCfgLib/QemuFwCfgLibMmioInternal.h   | 244 ++++++++++++++++++
>   .../Library/QemuFwCfgLib/QemuFwCfgMmioDxe.c   | 214 +++++++++++++++
>   ...CfgLibMmio.inf => QemuFwCfgMmioDxeLib.inf} |   8 +-
>   .../Library/QemuFwCfgLib/QemuFwCfgMmioPei.c   | 235 +++++++++++++++++
>   .../QemuFwCfgLib/QemuFwCfgMmioPeiLib.inf      |  52 ++++
>   OvmfPkg/OvmfPkg.dec                           |   1 +
>   OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc           |   2 +-
>   10 files changed, 814 insertions(+), 189 deletions(-)
>   create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmioInternal.h
>   create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioDxe.c
>   rename OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgLibMmio.inf => QemuFwCfgMmioDxeLib.inf} (78%)
>   create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioPei.c
>   create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioPeiLib.inf
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118361): https://edk2.groups.io/g/devel/message/118361
Mute This Topic: https://groups.io/mt/105746786/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5235 bytes --]