From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 750F978003C for ; Mon, 29 Apr 2024 01:17:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=n50x48Egvd0AmOqVtJHvzCZGchpnWs/TFuQkM2wcWZA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1714353448; v=1; b=ok20N4guKDEAYGfQKcPRxWmgCnQMs+WoOrSBfCeAS3sA3Q6zArZbIWJstXPxHWRjqudX5UsI iBZegfFuIru17ij4EyS7exsAsojb3w5CM50UqifefOorvqU/qM2F5IAdiKAGyLfcZ8K8OiL9EWf COwGwSL/7t0Mp0xo+dV+ZcAM0YPQZT5wpkwzjic0EYiS9c0gMmxfnU7OQO1G+rijDBgHAo0KJ1J ODfdnHpnDqLyxPUmO0HKhjwV9j6YTqZggMaIlhKU/u9ca1FQ3CmvLqR5uMCcbYU6Kb/Bz74LDwS H6wEpCj7qJxalZDSSfdONTwXtXMzQDf8WbxQ3WPDMSjCQ== X-Received: by 127.0.0.2 with SMTP id H7nAYY7687511xavbXLyhfXw; Sun, 28 Apr 2024 18:17:28 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.10090.1714353446550704675 for ; Sun, 28 Apr 2024 18:17:27 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxTesf9S5mRpgEAA--.9670S3; Mon, 29 Apr 2024 09:17:19 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax690b9S5m8KwIAA--.23358S3; Mon, 29 Apr 2024 09:17:16 +0800 (CST) Message-ID: <4e7dc099-7b05-4a8f-8fa9-a72784507adf@loongson.cn> Date: Mon, 29 Apr 2024 09:17:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage From: "Chao Li" To: devel@edk2.groups.io, Ard Biesheuvel , Gerd Hoffmann Cc: Jiewen Yao , Leif Lindholm , Sami Mujawar , Sunil V L , Andrei Warkentin References: <20240426082827.68489-1-lichao@loongson.cn> In-Reply-To: <20240426082827.68489-1-lichao@loongson.cn> X-CM-TRANSID: AQAAf8Ax690b9S5m8KwIAA--.23358S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQABCGYtuRMFXwARsi X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 28 Apr 2024 18:17:27 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qTuV8n7BTa1Cr5Jhe2T3KVEfx7686176AA= Content-Type: multipart/alternative; boundary="------------z2d9ulqIZHQLV9gpQOQdCTSR" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ok20N4gu; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --------------z2d9ulqIZHQLV9gpQOQdCTSR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Ard and Gerd and other maintainers, Could you review this version and give your suggestions? Thanks, Chao On 2024/4/26 16:28, Chao Li wrote: > Patch1: Added three PCDs for QemuFwCfgLibMmio > Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE > stage library. > Patch3: Added QemuFwCfgMmiLib PEI version > Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and > enable it in AARCH64 and RISCV64. > > V1 -> V2: > 1. Use HOBs instead of PCD. > 2. The old patch2 is divided into two parts, one is code splitting, and > the other is functional changes. > 3. add two patches to keep the safe when change the platform DSC file. > > V2 -> V3: > 1. Merge three HOBs into a single HOB. > 2. Remove the dynamic global variables in PEI. > > V3 -> V4: > 1. Adjust the HOB content, this version saves all of structual contents > in HOB. > 2. Remove the Loongson copyright in separation patch, and add it in the > funciton change patch. > 3. Restored some variables as static in DXE version. > 4. Added the HOB GUID in OvmfPkg.dec. > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4755 > > PR:https://github.com/tianocore/edk2/pull/5568 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Sunil V L > Cc: Andrei Warkentin > > Chao Li (8): > OvmfPkg: Add a GUID for QemuFwCfgLib > OvmfPkg: Separate QemuFwCfgLibMmio.c into two files > OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio > OvmfPkg: Add the QemuFwCfgMmioLib PEI stage version > OvmfPkg: Copy the same new INF as QemuFwCfgLibMmio.inf > ArmVirtPkg: Enable QemuFwCfgMmioDxeLib.inf > OvmfPkg/RiscVVirt: Enable QemuFwCfgMmioDxeLib.inf > OvmfPkg: Remove QemuFwCfgLibMmio.inf > > ArmVirtPkg/ArmVirtQemu.dsc | 2 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- > .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 243 +++++------------ > .../QemuFwCfgLib/QemuFwCfgLibMmioInternal.h | 244 ++++++++++++++++++ > .../Library/QemuFwCfgLib/QemuFwCfgMmioDxe.c | 214 +++++++++++++++ > ...CfgLibMmio.inf =3D> QemuFwCfgMmioDxeLib.inf} | 8 +- > .../Library/QemuFwCfgLib/QemuFwCfgMmioPei.c | 235 +++++++++++++++++ > .../QemuFwCfgLib/QemuFwCfgMmioPeiLib.inf | 52 ++++ > OvmfPkg/OvmfPkg.dec | 1 + > OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 2 +- > 10 files changed, 814 insertions(+), 189 deletions(-) > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmioInterna= l.h > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioDxe.c > rename OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgLibMmio.inf =3D> QemuFwCf= gMmioDxeLib.inf} (78%) > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioPei.c > create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioPeiLib.inf > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118361): https://edk2.groups.io/g/devel/message/118361 Mute This Topic: https://groups.io/mt/105746786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------z2d9ulqIZHQLV9gpQOQdCTSR Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Ard and Gerd and other maintainers,

Could you review this version and give your suggestions?


=
Thanks,
Chao
On 2024/4/26 16:28, Chao Li wrote:
Patch1: Added three PCDs for QemuFwCfgLibMmio
Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE
stage library.
Patch3: Added QemuFwCfgMmiLib PEI version
Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and
enable it in AARCH64 and RISCV64.

V1 -> V2:
1. Use HOBs instead of PCD.
2. The old patch2 is divided into two parts, one is code splitting, and
the other is functional changes.
3. add two patches to keep the safe when change the platform DSC file.

V2 -> V3:
1. Merge three HOBs into a single HOB.
2. Remove the dynamic global variables in PEI.

V3 -> V4:
1. Adjust the HOB content, this version saves all of structual contents
in HOB.
2. Remove the Loongson copyright in separation patch, and add it in the
funciton change patch.
3. Restored some variables as static in DXE version.
4. Added the HOB GUID in OvmfPkg.dec.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D4755

PR: https://github.com/tianocore/edk2/pull/5568

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Andrei Warkentin <andrei.warkentin@intel.com>

Chao Li (8):
  OvmfPkg: Add a GUID for QemuFwCfgLib
  OvmfPkg: Separate QemuFwCfgLibMmio.c into two files
  OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio
  OvmfPkg: Add the QemuFwCfgMmioLib PEI stage version
  OvmfPkg: Copy the same new INF as QemuFwCfgLibMmio.inf
  ArmVirtPkg: Enable QemuFwCfgMmioDxeLib.inf
  OvmfPkg/RiscVVirt: Enable QemuFwCfgMmioDxeLib.inf
  OvmfPkg: Remove QemuFwCfgLibMmio.inf

 ArmVirtPkg/ArmVirtQemu.dsc                    |   2 +-
 ArmVirtPkg/ArmVirtQemuKernel.dsc              |   2 +-
 .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c   | 243 +++++------------
 .../QemuFwCfgLib/QemuFwCfgLibMmioInternal.h   | 244 ++++++++++++++++++
 .../Library/QemuFwCfgLib/QemuFwCfgMmioDxe.c   | 214 +++++++++++++++
 ...CfgLibMmio.inf =3D> QemuFwCfgMmioDxeLib.inf} |   8 +-
 .../Library/QemuFwCfgLib/QemuFwCfgMmioPei.c   | 235 +++++++++++++++++
 .../QemuFwCfgLib/QemuFwCfgMmioPeiLib.inf      |  52 ++++
 OvmfPkg/OvmfPkg.dec                           |   1 +
 OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc           |   2 +-
 10 files changed, 814 insertions(+), 189 deletions(-)
 create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmioInternal.h
 create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioDxe.c
 rename OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgLibMmio.inf =3D> QemuFwCf=
gMmioDxeLib.inf} (78%)
 create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioPei.c
 create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgMmioPeiLib.inf
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118361) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------z2d9ulqIZHQLV9gpQOQdCTSR--