From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::444; helo=mail-pf1-x444.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 06A0C202E53B2 for ; Tue, 12 Feb 2019 22:01:22 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id c123so676857pfb.0 for ; Tue, 12 Feb 2019 22:01:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DUNuSkUbgWBo7RkPNz/rjxZlq24tL35jT14uOcQ9Vko=; b=Pq1bB3NRMIzdepVtZg6DHHsDJj16nmjQwUyxxkcG3BIzO7rgwxewHAmaEvWoDo8RuY P0KgzTIC6nP7+hBz/E8LZ9Fl7Cq2iE/fXa1Gt1FNn/VEwdjy8UMuDPyAQ2jJyBLxVfbH 1zmCX1VkjPrlHHia+pIu4JuJaKTnI5AyQif1aBb1Gk80T4MaYiFO7ddz8HqS4jkQdcRA ZtDXdoWU89aRAfqTEVUdebXXSbV90E4CK/A/jqUlx2MujqAw+Ugq8RSRBr0KW/7Og+tW Kkw8jEChryhP+Ze+JKC+3S5MbCQQpv140Xp1yTWmBuhNMKUDcA24YMCBuumopqj0BRia zQSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DUNuSkUbgWBo7RkPNz/rjxZlq24tL35jT14uOcQ9Vko=; b=XaJBnSa+UHxaruPR0478mPLJeb/IsYCo2Sk9eEcGPN6ypbm7pe1RGE2/LJ7oXAUuPG EZ05300EOkd7CSZ+sIyTCj8Tt9OXYWuKX8VVh827NG7c+9ffINgR5WyxWPe6fZezTj0P DH52nw23ecZ1f+4jBDL5aArGl7Hbc77CwM9HGQJBwNUM7p583j00v1pY6NqYXntkvUm/ 9goOU6uLakqs4aA7IwlvWS0MupdTrbj6it78t3BKIQOvnmekdKQGSRf/QRnyZfCb/Jqd OxHYQVxr0ut7YIIWPGQfF58QN2HpRZxKK8C8U1UPQ1D5v364zYrypX+Wh/cVdG0viykg OmZw== X-Gm-Message-State: AHQUAuZb8nY75OBLLfzuRJA/CBO4PHJSQwDCvd/ptPSdeShvpqwYYXYA lhYGRiVg+R1A+QTZNMvSaBMWMQ== X-Google-Smtp-Source: AHgI3Ibcemc5m3pn83GWef/KV01Pxq6M7xllk3YoXbP/v1nd3LQFMdBdS+OxTw+KTvjYD8c7zON/fQ== X-Received: by 2002:a63:eb0c:: with SMTP id t12mr7090399pgh.105.1550037682159; Tue, 12 Feb 2019 22:01:22 -0800 (PST) Received: from [10.58.0.74] ([64.64.108.254]) by smtp.gmail.com with ESMTPSA id n25sm7523253pfi.173.2019.02.12.22.01.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 22:01:21 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-4-ming.huang@linaro.org> <20190212151238.hudsqbg2qiqp7qwa@bivouac.eciton.net> From: Ming Huang Message-ID: <4e80c1d1-b59f-b173-d197-a9216e1e2f58@linaro.org> Date: Wed, 13 Feb 2019 14:01:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190212151238.hudsqbg2qiqp7qwa@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 03/16] Hisilicon/D06: Optimize SAS driver for reducing boot time X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 06:01:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2019 11:12 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:23PM +0800, Ming Huang wrote: >> SAS controller is always existed, so accessing SAS register don't >> depend on PciBusDxe (pci enumeration). >> Move the SAS module early in D06.fdf for dispatching SAS driver >> early. This can avoid wait in BDS normally and reduce boot time. >> >> This patch is relative with SasDriverDxe in edk2-non-osi. > > I think you are saying that this change is only valid after the > update to SasDriverDxe in edk2-non-osi has been applied? > Or does it mean that it only improves performance after that > edk2-non-osi patch has been applied? This change is only valid after the update to SasDriverDxe in edk2-non-osi has been applied. Thanks > > Please be more explicit in the commit message. > > Other than that. I'm OK with this patch. > > / > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Platform/Hisilicon/D06/D06.fdf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf >> index a937660a09e2..d495ad7f264c 100644 >> --- a/Platform/Hisilicon/D06/D06.fdf >> +++ b/Platform/Hisilicon/D06/D06.fdf >> @@ -165,6 +165,7 @@ [FV.FvMain] >> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> >> INF Platform/Hisilicon/D06/Drivers/IoInitDxe/IoInitDxe.inf >> + INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf >> # >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> # >> @@ -296,7 +297,6 @@ [FV.FvMain] >> # >> INF Platform/Hisilicon/D06/Drivers/Sm750Dxe/UefiSmi.inf >> INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf >> - INF Platform/Hisilicon/D06/Drivers/Sas/SasDxeDriver.inf >> INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >> INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf >> INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf >> -- >> 2.9.5 >>