From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Fri, 13 Sep 2019 15:31:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2019 15:31:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="386552714" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga006.fm.intel.com with ESMTP; 13 Sep 2019 15:31:25 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Sep 2019 15:31:25 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX161.amr.corp.intel.com ([169.254.4.111]) with mapi id 14.03.0439.000; Fri, 13 Sep 2019 15:31:25 -0700 From: "Nate DeSimone" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chiu, Chasel" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers Thread-Topic: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers Thread-Index: AQHVaRV0kn3ItU3EP0CFm/kIatT4h6coZJpggAJEgQA= Date: Fri, 13 Sep 2019 22:31:24 +0000 Message-ID: <4e8f9867-73b8-9ca8-aafc-b4a1567ca61c@intel.com> References: <20190912025442.36436-1-shenglei.zhang@intel.com> <15C3C5B9A4267C61.28831@groups.io> In-Reply-To: <15C3C5B9A4267C61.28831@groups.io> Reply-To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 x-originating-ip: [10.7.159.63] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <279BCDD80D6F0A47B64CADCEB2D67686@intel.com> Content-Transfer-Encoding: base64 SGkgU2hlbmdsZWksDQoNCkxvb2tpbmcgYXQgdGhpcyBwYXRjaCBtb3JlIGNsb3NlbHkuIFRoZXJl IGFwcGVhciB0byBiZSBidWdzLi4uIHBsZWFzZSANCnNlZSBiZWxvdy4gUGxlYXNlIGZpeCB0aGlz IGFsb25nIHdpdGggeW91ciBwb29yIHVzZSBvZiBzZW1pLWNvbG9ucyBhbmQgDQp3aGl0ZS1zcGFj ZS4NCg0KVGhhbmtzLA0KDQpOYXRlDQoNCk9uIDkvMTIvMjAxOSAxMTo1NCBBTSwgTmF0ZSBEZVNp bW9uZSB3cm90ZToNCj4gWW91ciB3aGl0ZXNwYWNlIGRvZXNuJ3QgcXVpdGUgbWF0Y2ggdGhlIGVk azIgY29kaW5nIHN0eWxlIGd1aWRlbGluZXMsIGJ1dCB3ZSBjYW4gZml4IHRoYXQgZHVyaW5nIGNv bW1pdC4NCj4NCj4gUmV2aWV3ZWQtYnk6IE5hdGUgRGVTaW1vbmUgPG5hdGhhbmllbC5sLmRlc2lt b25lQGludGVsLmNvbT4NCj4NCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTog WmhhbmcsIFNoZW5nbGVpDQo+IFNlbnQ6IFdlZG5lc2RheSwgU2VwdGVtYmVyIDExLCAyMDE5IDc6 NTUgUE0NCj4gVG86IGRldmVsQGVkazIuZ3JvdXBzLmlvDQo+IENjOiBLdWJhY2tpLCBNaWNoYWVs IEEgPG1pY2hhZWwuYS5rdWJhY2tpQGludGVsLmNvbT47IENoaXUsIENoYXNlbCA8Y2hhc2VsLmNo aXVAaW50ZWwuY29tPjsgRGVzaW1vbmUsIE5hdGhhbmllbCBMIDxuYXRoYW5pZWwubC5kZXNpbW9u ZUBpbnRlbC5jb20+OyBHYW8sIExpbWluZyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+IFN1Ympl Y3Q6IFtQQVRDSF0gTWluUGxhdGZvcm1Qa2cvVGVzdFBvaW50Q2hlY2tMaWI6IEFkZCBjaGVjayBm b3IgcG9pbnRlcnMNCj4NCj4gSW4gRHhlQ2hlY2tCb290VmFyaWFibGUuYywgYWRkIGNoZWNrIGZv ciBCb290T3JkZXIgYW5kIFZhcmlhYmxlIHRoYXQgcmV0dXJuIEVGSV9OT1RfRk9VTkQgd2hlbiB0 aGV5IGFyZSBOVUxMLg0KPiBJbiBEeGVDaGVja0djZC5jLCBhZGQgY2hlY2sgZm9yIEdjZElvTWFw IHRvIGVuc3VyZSBpdCBub3QgTlVMTCB3aGVuIGFsbG9jYXRpbmcgbWVtb3J5IHRvIHdoYXQgaXQg cG9pbnRzIHRvLg0KPg0KPiBDYzogTWljaGFlbCBLdWJhY2tpIDxtaWNoYWVsLmEua3ViYWNraUBp bnRlbC5jb20+DQo+IENjOiBDaGFzZWwgQ2hpdSA8Y2hhc2VsLmNoaXVAaW50ZWwuY29tPg0KPiBD YzogTmF0ZSBEZVNpbW9uZSA8bmF0aGFuaWVsLmwuZGVzaW1vbmVAaW50ZWwuY29tPg0KPiBDYzog TGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IFNoZW5n bGVpIFpoYW5nIDxzaGVuZ2xlaS56aGFuZ0BpbnRlbC5jb20+DQo+IC0tLQ0KPg0KPiB2MjogVXBk YXRlIGNvcHlyaWdodA0KPg0KPiAgIC4uLi9UZXN0L0xpYnJhcnkvVGVzdFBvaW50Q2hlY2tMaWIv RHhlQ2hlY2tCb290VmFyaWFibGUuYyB8IDggKysrKysrKy0NCj4gICAuLi4vVGVzdC9MaWJyYXJ5 L1Rlc3RQb2ludENoZWNrTGliL0R4ZUNoZWNrR2NkLmMgICAgICAgICAgfCA2ICsrKystLQ0KPiAg IDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkNCj4NCj4g ZGlmZiAtLWdpdCBhL1BsYXRmb3JtL0ludGVsL01pblBsYXRmb3JtUGtnL1Rlc3QvTGlicmFyeS9U ZXN0UG9pbnRDaGVja0xpYi9EeGVDaGVja0Jvb3RWYXJpYWJsZS5jIGIvUGxhdGZvcm0vSW50ZWwv TWluUGxhdGZvcm1Qa2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNrTGliL0R4ZUNoZWNrQm9v dFZhcmlhYmxlLmMNCj4gaW5kZXggODViZDViM2QuLjk4MTMwNjgzIDEwMDY0NA0KPiAtLS0gYS9Q bGF0Zm9ybS9JbnRlbC9NaW5QbGF0Zm9ybVBrZy9UZXN0L0xpYnJhcnkvVGVzdFBvaW50Q2hlY2tM aWIvRHhlQ2hlY2tCb290VmFyaWFibGUuYw0KPiArKysgYi9QbGF0Zm9ybS9JbnRlbC9NaW5QbGF0 Zm9ybVBrZy9UZXN0L0xpYnJhcnkvVGVzdFBvaW50Q2hlY2tMaWIvRHhlQ2gNCj4gKysrIGVja0Jv b3RWYXJpYWJsZS5jDQo+IEBAIC0xLDYgKzEsNiBAQA0KPiAgIC8qKiBAZmlsZQ0KPiAgIA0KPiAt Q29weXJpZ2h0IChjKSAyMDE3LCBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyByZXNlcnZl ZC48QlI+DQo+ICtDb3B5cmlnaHQgKGMpIDIwMTctMjAxOSwgSW50ZWwgQ29ycG9yYXRpb24uIEFs bCByaWdodHMgcmVzZXJ2ZWQuPEJSPg0KPiAgIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBCU0Qt Mi1DbGF1c2UtUGF0ZW50DQo+ICAgDQo+ICAgKiovDQo+IEBAIC0xMzAsNiArMTMwLDkgQEAgVGVz dFBvaW50Q2hlY2tMb2FkT3B0aW9uVmFyaWFibGUgKA0KPiAgICAgZm9yIChMaXN0SW5kZXggPSAw OyBMaXN0SW5kZXggPCBzaXplb2YobUxvYWRPcHRpb25WYXJpYWJsZUxpc3QpL3NpemVvZihtTG9h ZE9wdGlvblZhcmlhYmxlTGlzdFswXSk7IExpc3RJbmRleCsrKSB7DQo+ICAgICAgIFVuaWNvZGVT UHJpbnQgKEJvb3RPcmRlck5hbWUsIHNpemVvZihCb290T3JkZXJOYW1lKSwgTCIlc09yZGVyIiwg bUxvYWRPcHRpb25WYXJpYWJsZUxpc3RbTGlzdEluZGV4XSk7DQo+ICAgICAgIFN0YXR1cyA9IEdl dFZhcmlhYmxlMiAoQm9vdE9yZGVyTmFtZSwgJmdFZmlHbG9iYWxWYXJpYWJsZUd1aWQsIChWT0lE ICoqKSZCb290T3JkZXIsICZPcmRlclNpemUpOw0KPiArICAgIGlmKEJvb3RPcmRlciA9PSBOVUxM KSB7DQo+ICsgICAgICByZXR1cm4gRUZJX05PVF9GT1VORDs7DQo+ICsgICAgfQ0KPiAgICAgICBp ZiAoRUZJX0VSUk9SKFN0YXR1cykpIHsNCj4gICAgICAgICBjb250aW51ZTsNCj4gICAgICAgfQ0K PiBAQCAtMjIyLDYgKzIyNSw5IEBAIFRlc3RQb2ludENoZWNrS2V5T3B0aW9uVmFyaWFibGUgKA0K PiAgICAgICBmb3IgKEluZGV4ID0gMDsgOyBJbmRleCsrKSB7DQo+ICAgICAgICAgVW5pY29kZVNQ cmludCAoS2V5T3B0aW9uTmFtZSwgc2l6ZW9mKEtleU9wdGlvbk5hbWUpLCBMIiVzJTA0eCIsIG1L ZXlPcHRpb25WYXJpYWJsZUxpc3RbTGlzdEluZGV4XSwgSW5kZXgpOw0KPiAgICAgICAgIFN0YXR1 cyA9IEdldFZhcmlhYmxlMiAoS2V5T3B0aW9uTmFtZSwgJmdFZmlHbG9iYWxWYXJpYWJsZUd1aWQs ICZWYXJpYWJsZSwgJlNpemUpOw0KPiArICAgICAgaWYoVmFyaWFibGUgPT0gTlVMTCkgew0KPiAr ICAgICAgICByZXR1cm4gRUZJX05PVF9GT1VORDs7DQo+ICsgICAgICB9DQo+ICAgICAgICAgaWYg KCFFRklfRVJST1IoU3RhdHVzKSkgew0KPiAgICAgICAgICAgRHVtcEtleU9wdGlvbiAoS2V5T3B0 aW9uTmFtZSwgVmFyaWFibGUsIFNpemUpOw0KPiAgICAgICAgIH0gZWxzZSB7DQo+IGRpZmYgLS1n aXQgYS9QbGF0Zm9ybS9JbnRlbC9NaW5QbGF0Zm9ybVBrZy9UZXN0L0xpYnJhcnkvVGVzdFBvaW50 Q2hlY2tMaWIvRHhlQ2hlY2tHY2QuYyBiL1BsYXRmb3JtL0ludGVsL01pblBsYXRmb3JtUGtnL1Rl c3QvTGlicmFyeS9UZXN0UG9pbnRDaGVja0xpYi9EeGVDaGVja0djZC5jDQo+IGluZGV4IDgyNzA5 ZDQ0Li5jOTBiMzdmMiAxMDA2NDQNCj4gLS0tIGEvUGxhdGZvcm0vSW50ZWwvTWluUGxhdGZvcm1Q a2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNrTGliL0R4ZUNoZWNrR2NkLmMNCj4gKysrIGIv UGxhdGZvcm0vSW50ZWwvTWluUGxhdGZvcm1Qa2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNr TGliL0R4ZUNoDQo+ICsrKyBlY2tHY2QuYw0KPiBAQCAtMSw2ICsxLDYgQEANCj4gICAvKiogQGZp bGUNCj4gICANCj4gLUNvcHlyaWdodCAoYykgMjAxNywgSW50ZWwgQ29ycG9yYXRpb24uIEFsbCBy aWdodHMgcmVzZXJ2ZWQuPEJSPg0KPiArQ29weXJpZ2h0IChjKSAyMDE3LTIwMTksIEludGVsIENv cnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLjxCUj4NCj4gICBTUERYLUxpY2Vuc2UtSWRl bnRpZmllcjogQlNELTItQ2xhdXNlLVBhdGVudA0KPiAgIA0KPiAgICoqLw0KPiBAQCAtMjQxLDcg KzI0MSw5IEBAIFRlc3RQb2ludER1bXBHY2QgKA0KPiAgICAgICAgIH0NCj4gICAgICAgfQ0KPiAg ICAgICBpZiAoR2NkTWVtb3J5TWFwICE9IE5VTEwpIHsNCj4gLSAgICAgICpHY2RJb01hcCA9IEFs bG9jYXRlQ29weVBvb2wgKE51bWJlck9mRGVzY3JpcHRvcnMgKiBzaXplb2YoRUZJX0dDRF9JT19T UEFDRV9ERVNDUklQVE9SKSwgSW9NYXApOw0KPiArICAgICAgaWYgKEdjZElvTWFwICE9IE5VTEwp ew0KPiArICAgICAgICAqR2NkSW9NYXAgPSBBbGxvY2F0ZUNvcHlQb29sIChOdW1iZXJPZkRlc2Ny aXB0b3JzICogc2l6ZW9mKEVGSV9HQ0RfSU9fU1BBQ0VfREVTQ1JJUFRPUiksIElvTWFwKTsNCj4g KyAgICAgIH0NCg0KR2NkSW9NYXAgd2lsbCBhbHdheXMgYmUgTlVMTC4gUGxlYXNlIHNlZSBsaW5l IDE5OSBvZiB0aGlzIGZpbGUuIEkgDQpiZWxpZXZlIHlvdXIgcGF0Y2ggaXMgaW50cm9kdWNpbmcg YSBuZXcgYnVnLg0KDQo+ICAgICAgICAgKkdjZElvTWFwTnVtYmVyT2ZEZXNjcmlwdG9ycyA9IE51 bWJlck9mRGVzY3JpcHRvcnM7DQo+ICAgICAgIH0NCj4gICAgIH0NCj4gLS0NCj4gMi4xOC4wLndp bmRvd3MuMQ0KPg0KPg0KPiANCj4=