From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from muon.bsdio.com (muon.bsdio.com [65.103.231.193]) by mx.groups.io with SMTP id smtpd.web12.13289.1573234998346586177 for ; Fri, 08 Nov 2019 09:43:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=temperror, err=temporary DNS error (domain: bsdio.com, ip: 65.103.231.193, mailfrom: rebecca@bsdio.com) Received: from muon.bsdio.com (localhost [127.0.0.1]) by muon.bsdio.com (Postfix) with ESMTP id A3070A9BC; Fri, 8 Nov 2019 10:45:57 -0700 (MST) Received: from muon.bsdio.com ([127.0.0.1]) by muon.bsdio.com (muon.bsdio.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yuWjs_2qzI4r; Fri, 8 Nov 2019 10:45:56 -0700 (MST) Received: from [10.0.10.115] (unknown [10.0.10.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by muon.bsdio.com (Postfix) with ESMTPSA; Fri, 8 Nov 2019 10:45:56 -0700 (MST) Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate To: devel@edk2.groups.io, michael.d.kinney@intel.com, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <5ccaa1d4-714d-f785-e57d-bbd2c8e4596e@redhat.com> From: rebecca@bsdio.com Message-ID: <4e99e2d6-3bec-ef16-8ed5-f73ac9db0ebb@bsdio.com> Date: Fri, 8 Nov 2019 10:43:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 11/8/19 10:10 AM, Michael D Kinney wrote: > 1) You can run the CI tests on your local dev system. > Fix issues locally and rerun as needed before sending > patch review email. This will only perform build > tests with your local compiler. > > 2) You can push a branch with changes to your personal > fork of the edk2 repository (edk2-staging in the > review period) and submit a pull request to the > tianocore repo *without* the 'push' label set . This > is considered a personal build. If all CI checks pass > then the PR is auto closed with a comment on the > PR. If the PR fails, then the PR is left open with > comment on the PR. In the failure case, you can fix > the issue on your local branch and do a forced > push to your personal fork. GitHub sees the forced > push and reruns the CI tests automatically. Today > this runs build tests for VS2019 and GCC, so you get > better coverage than local testing. Once your personal > build passes, you can send patch review email and can > even point to the PR for your personal build so > reviewers and maintainers can view the CI results. > > NOTE: (1) does not send any public emails. > (2) will send a public email when a comment or > close action is performed on a PR to all > GitHub users that are watching that repo.\ In addition, if there's interest I can set up my Jenkins system again, which would allow developers to run a Python script against their edk2 clone to submit builds on the build farm I have - which has Windows (VS2015, VS2017 and VS2019), Linux (GCC4.9, GCC5), and macOS (Clang) agents. Unfortunately using pull requests to submit personal CI builds seems a bit suboptimal to me. But perhaps that's just because I'm not used to using them. -- Rebecca Cran