Re: [PATCH 02/22] .mailmap: add entry for Ching JenX Cheng

["Laszlo Ersek" <lersek@redhat.com>]

On 09/17/20 18:45, Philippe Mathieu-Daudé wrote:
> On 9/17/20 5:28 PM, Laszlo Ersek wrote:
>> On 09/17/20 16:47, Philippe Mathieu-Daudé wrote:
>>> On 9/7/20 9:30 PM, Laszlo Ersek wrote:
>>>> ... for git-shortlog purposes.
>>>>
>>>> Cc: Ching JenX Cheng <ching.jenx.cheng@intel.com>
>>>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>>>> ---
>>>>  .mailmap | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/.mailmap b/.mailmap
>>>> index f173754d7ee8..c2eeee2834e2 100644
>>>> --- a/.mailmap
>>>> +++ b/.mailmap
>>>> @@ -16,6 +16,7 @@ Ard Biesheuvel <ard.biesheuvel@linaro.org> <abiesheuvel@Edk2>
>>>>  Ashley DeSimone <ashley.e.desimone@intel.com> <ashdesimone@6f19259b-4bc3-4df7-8a09-765794883524>
>>>>  Baraneedharan Anbazhagan <anbazhagan@hp.com>
>>>>  Chasel Chiu <chasel.chiu@intel.com>
>>>> +Ching JenX Cheng <ching.jenx.cheng@intel.com>
>>>
>>> In my mailmap I have:
>>>
>>> Cheng Ching Jen <ching.jenx.cheng@intel.com>
>>
>> - Do you mean your local / personal mailmap?
> 
> Yes, the EDK2 mailmap I keep rebasing for EDK2
> statistics using git-dm.
> 
> IIUC from my previous series I'm not authorized
> to contribute it, so I stopped posting the updates.

I don't understand ("not authorized to contribute it"). Can you explain?
How can be "authorization" missing for contributing changes to a mailmap
file? Do you have a link perhaps?

That said... seeing how few people have responded to this patch series,
especially from Intel, I'm inclined to just merge the patches that have
been approved by the subject contributors, and simply drop the rest.

And then -- for the sake of QEMU (= git-shortlog), and for git-dm --, we
could maintain our own separate mailmap file, *on top*. We could start
with what you already have, just move it to a git repository somewhere
(internally to RH, or under your public gitlab space, or wherever). So
that multiple folks could rely on that mailmap (when updating the
bundled binaries in QEMU), and multiple folks could propose updates.

What do you think?

Thanks!
Laszlo


> 
>>
>> - Intel email addresses have the format
>> <given_name.family_name@intel.com>, where given_name may carry a "middle
>> name" (initial) as well, plus it may be terminated with an X, to show
>> that the person is a contractor. So with <ching.jenx.cheng@intel.com>,
>> the developer is a contractor, not an employee, their family name is
>> "Cheng", and their given names are "Ching Jen".
>>
>> Then, in the mailmap file, we use the "FirstName LastName" format (to
>> stick with the English / international custom). So I think my proposal
>> is the correct one; at most I should drop the X. Your version ("Cheng
>> Ching Jen") is the native Chinese name order, which is the inverse of
>> the English one.
> 
> OK I didn't know the format has to follow the English name order.
> I used the Chinese name order because I found somewhere in the
> EDK2 archives some posts signed as "Cheng Ching Jen", so I took
> this order to respect the author preference.
> 
>>
>> Thanks
>> Laszlo
>>
>>>
>>>>  Christopher J Zurcher <christopher.j.zurcher@intel.com>
>>>>  Eric Dong <eric.dong@intel.com>
>>>>  Eric Dong <eric.dong@intel.com> Eric Dong <eirc.dong@intel.com>
>>>>
>>>
>>
>