From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.3126.1587029815065045495
 for <devel@edk2.groups.io>;
 Thu, 16 Apr 2020 02:36:55 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79723C14;
	Thu, 16 Apr 2020 02:36:53 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0A2293F73D;
	Thu, 16 Apr 2020 02:36:51 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: Liming Gao <liming.gao@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
 Hao A Wu <hao.a.wu@intel.com>, Bob Feng <bob.c.feng@intel.com>
References: <20200401083157.23960-1-shenglei.zhang@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <4ed0b0fd-ae8d-8571-e562-1a143280382f@arm.com>
Date: Thu, 16 Apr 2020 11:36:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200401083157.23960-1-shenglei.zhang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/1/20 10:31 AM, Zhang, Shenglei via Groups.Io wrote:
> Currently brotli is used and customized by edk2 in BaseTools
> and MdeModulePkg. These two patches make brotli a submodule in
> edk2.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2558
> https://bugzilla.tianocore.org/show_bug.cgi?id=2559
> 
> v2: Add submodule path in CISettings.py
> 

So with this changes, we have two copies of the entire brotli repository 
in the source directory? Is that really necessary?